From nobody Mon Oct 31 01:50:46 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N0x1y6g8qz4gDmS; Mon, 31 Oct 2022 01:50:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N0x1y5vTVz3SXy; Mon, 31 Oct 2022 01:50:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667181046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s9uu4cYydgaRN5K1KUpTa5wWW3uyiKGVS0u0HBUZS/U=; b=kPLp0QUkNQoprLxxhfc91YmTna6cTgbEQqh17fPDnJL+f8qyehB5E3eo7gwt9q+5u3mkuW zgVa1Jt39rEwLfSaq+KFKfXpwPp2XZNUOvB7ciHvdplDu85RIdEboDhayhnPHlQW5V89sT 55B7zjJ1ucPF7Vx2jthaCjLU5I/HDlgxEreUkRRHcHsH4cLNJNQyv8boW24yXtXhEKnuvn PY3xxsfKjcuyJjwFTPXeFCtt77WxoSbK5zIeFlRxIV4PUAcGMnqeaOpQf5EVl3uPL5O1gA SqYPopTl4Dr6WSyWyZVYzjzx86Slhf5MZZbiG7NVnqpmUkM/UXaTZHE8QuIEvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N0x1y4zMzzJdg; Mon, 31 Oct 2022 01:50:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29V1okdc099760; Mon, 31 Oct 2022 01:50:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29V1okIb099759; Mon, 31 Oct 2022 01:50:46 GMT (envelope-from git) Date: Mon, 31 Oct 2022 01:50:46 GMT Message-Id: <202210310150.29V1okIb099759@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: faea785d3053 - stable/13 - fusefs: After successful F_GETLK, l_whence should be SEEK_SET List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: faea785d30533566fa03807cdbd8a49d5fd16254 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667181046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s9uu4cYydgaRN5K1KUpTa5wWW3uyiKGVS0u0HBUZS/U=; b=aIgwp5cXRkNBdceRRTveIHPPRVdiUhPA3xTBcOTKxrivOARiEOgoCF4Fo5GyTkjygHFZRb a5C1w9oFy0YZnHHsXAlu50ghXwX2/aVNaSilbubaS28RzWgrb5YycRGfJ6X5dECA5gdG8Z PXldtnx3kh0IMm9yVJGicm0mMmt+aQrI6svrhIpbsI3QL0n1qD3xh3104tj4iLexakIKSc B1DXTohwbyhYpO/HSIbtOZjEewO5NUqC7Wmyu15CEh4Cgh1oVi9F7drc/TdI0W98siWnEa s+xeND4vos0WI9yMR316uCKHUkKesNW6h64Eke5SMLzcgXxe4By7TCzpGHtDHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667181046; a=rsa-sha256; cv=none; b=lSaq01FsaZPuypSQhEZNn/ywM6F3A5a1fbV3+1yIBQBHuGKJaFCnMQFIkefxuIPzSk4meG M7RbyJJPFFIxEVdjjVFZwjAViiGBkCPIWogjMZ/pIkt8Ouuao2tQGNyTBwLLirCTL+FHdY A4T5ZBhZbT54RtgaI/LtAgyWjFLENybGAjGyXERV5/CWM/fOqqNPmcbuovdd3VCv/6gZKt 0Ly+8rt6niuZOl3vn/8MOs38TtUm/ypE+5CMC4Wtzkzk2k3uch/Wq/lHYqu/NXrklCwy3p 19J9sZosy6xza+lyo6tcHtXAx51IPKx+od0zyxMHxgwmK7oQBwAouYJdsH1h3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=faea785d30533566fa03807cdbd8a49d5fd16254 commit faea785d30533566fa03807cdbd8a49d5fd16254 Author: Alan Somers AuthorDate: 2022-10-11 23:00:07 +0000 Commit: Alan Somers CommitDate: 2022-10-31 00:51:33 +0000 fusefs: After successful F_GETLK, l_whence should be SEEK_SET PR: 266886 Reported by: John Millikin Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D37014 (cherry picked from commit 3c3b906b54236841d813fd9a01b1e090f39558ea) --- sys/fs/fuse/fuse_vnops.c | 1 + tests/sys/fs/fusefs/locks.cc | 69 ++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 68 insertions(+), 2 deletions(-) diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c index cd3985049576..fb94be178743 100644 --- a/sys/fs/fuse/fuse_vnops.c +++ b/sys/fs/fuse/fuse_vnops.c @@ -535,6 +535,7 @@ fuse_vnop_advlock(struct vop_advlock_args *ap) if (err == 0 && op == FUSE_GETLK) { flo = fdi.answ; fl->l_type = flo->lk.type; + fl->l_whence = SEEK_SET; if (flo->lk.type != F_UNLCK) { fl->l_pid = flo->lk.pid; fl->l_start = flo->lk.start; diff --git a/tests/sys/fs/fusefs/locks.cc b/tests/sys/fs/fusefs/locks.cc index aeb24704624b..f637c65cff24 100644 --- a/tests/sys/fs/fusefs/locks.cc +++ b/tests/sys/fs/fusefs/locks.cc @@ -47,9 +47,9 @@ using namespace testing; class Fallback: public FuseTest { public: -void expect_lookup(const char *relpath, uint64_t ino) +void expect_lookup(const char *relpath, uint64_t ino, uint64_t size = 0) { - FuseTest::expect_lookup(relpath, ino, S_IFREG | 0644, 0, 1); + FuseTest::expect_lookup(relpath, ino, S_IFREG | 0644, size, 1); } }; @@ -355,6 +355,71 @@ TEST_F(Getlk, lock_exists) leak(fd); } +/* + * F_GETLK with SEEK_CUR + */ +TEST_F(Getlk, seek_cur) +{ + const char FULLPATH[] = "mountpoint/some_file.txt"; + const char RELPATH[] = "some_file.txt"; + uint64_t ino = 42; + struct flock fl; + int fd; + pid_t pid = getpid(); + + expect_lookup(RELPATH, ino, 1024); + expect_open(ino, 0, 1); + EXPECT_CALL(*m_mock, process( + ResultOf([=](auto in) { + return (in.header.opcode == FUSE_GETLK && + in.header.nodeid == ino && + in.body.getlk.fh == FH && + /* + * Though it seems useless, libfuse expects the + * owner and pid fields to be set during + * FUSE_GETLK. + */ + in.body.getlk.owner == (uint32_t)pid && + in.body.getlk.lk.pid == (uint64_t)pid && + in.body.getlk.lk.start == 500 && + in.body.getlk.lk.end == 509 && + in.body.getlk.lk.type == F_RDLCK); + }, Eq(true)), + _) + ).WillOnce(Invoke(ReturnImmediate([=](auto in __unused, auto& out) { + SET_OUT_HEADER_LEN(out, getlk); + out.body.getlk.lk.start = 400; + out.body.getlk.lk.end = 499; + out.body.getlk.lk.type = F_WRLCK; + out.body.getlk.lk.pid = (uint32_t)pid + 1; + }))); + + fd = open(FULLPATH, O_RDWR); + ASSERT_LE(0, fd) << strerror(errno); + ASSERT_NE(-1, lseek(fd, 500, SEEK_SET)); + + fl.l_start = 0; + fl.l_len = 10; + fl.l_pid = 42; + fl.l_type = F_RDLCK; + fl.l_whence = SEEK_CUR; + fl.l_sysid = 0; + ASSERT_NE(-1, fcntl(fd, F_GETLK, &fl)) << strerror(errno); + + /* + * After a successful F_GETLK request, the value of l_whence is + * SEEK_SET. + */ + EXPECT_EQ(F_WRLCK, fl.l_type); + EXPECT_EQ(fl.l_pid, pid + 1); + EXPECT_EQ(fl.l_start, 400); + EXPECT_EQ(fl.l_len, 100); + EXPECT_EQ(fl.l_whence, SEEK_SET); + ASSERT_EQ(fl.l_sysid, 0); + + leak(fd); +} + /* * If the fuse filesystem does not support posix file locks, then the kernel * should fall back to local locks.