From nobody Sat Oct 29 21:10:55 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N0BsW3WqTz4gshC; Sat, 29 Oct 2022 21:10:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N0BsW2k1lz3ZZN; Sat, 29 Oct 2022 21:10:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667077855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yWwRl/nxnUcCj8e7226cmYOQ1hUUlR9Bl8ME/sk87Tw=; b=I8CRBSRd/e127ODJpRAm2UC9PNMgDpz9HxhaiCK1LRnePGEOpUQsuoIym/gqO+1Cdfu7se rU/IDCZzBRKvTwmGCybZ6zDVd3QvwwFdTZQnepWc5iS/NDblOi2vZqD+Uf4TCOguZouz7z ajJlz0vrkMgTk3QgFlSb6KucBDfUMQIkzw8otVQKqJGv3LDTVzXZQHB87iPHRr/K6TZN9H 3crJ6FeQl8nT1lGrQLA+DKiRiXBq//qzmattqcqJcfwU552a7aFndkTUAc1WCkylPw5e0x mlVnBibfnT1UEUGjAKdNJtjs2ZgiMnchBl4Iso07jV21ZZTzf/ln8mpjonMk+g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N0BsW1pDDzXWK; Sat, 29 Oct 2022 21:10:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29TLAtDb068041; Sat, 29 Oct 2022 21:10:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29TLAtD6068040; Sat, 29 Oct 2022 21:10:55 GMT (envelope-from git) Date: Sat, 29 Oct 2022 21:10:55 GMT Message-Id: <202210292110.29TLAtD6068040@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: f0a15aafcb86 - main - strfmon: Remove XXX marks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f0a15aafcb863f796e2a7f94d0fd8a857fb56103 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667077855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yWwRl/nxnUcCj8e7226cmYOQ1hUUlR9Bl8ME/sk87Tw=; b=WoLj3DnGgtUSIQd2y0ieqX1PZAyryYnKpryVJ6rYrlrRWGlKLYz77WyKy0d4Yo1jkKsTyJ gZ9InjFT/FrCCdotEgJJi4zwY3VU9mKNAbFmrMRlxTiuA3nzxVYFZG+TdvFyw/Ibs6dDQs EySqUMluvOozw1dFubomsgJAvMNxCxmpi4HtFf/d6jw0lYrOdLyI9qfdesBVE1B9eYOtif lZUUbKvteJhhpCy7nf+xNsUmxa3u1WiL46ZtGBYGEldlKGwAEXa+yF5lxiqALs91CLGzcM GHeDG92u2GnqLSBubyiwzrgDV3PqM7DFdALCC8LCJ1lVJTWLKSlqAj26MxjMog== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667077855; a=rsa-sha256; cv=none; b=gdvkvUaHKtlyIKUpyBy3TqxXYR2QykYC8VNInn4LIUvFODlZoT2gA3NB6nHgoETBgkgnCZ kjxcMgqg+fhK3GyNJEZ2uXGdlLz6jlWz9RfbyCFWa0gMEyVtXoGxm/VUBYqDtotL8wJjZP Mc+ecFiAgsEmi485VQocFP5DYtPO9aDVkByVRe/E0HRg36MNiGRL9N/H979j3sakq0vMys /x3XUJQYl2/Agc683lAPMlVb2BvJsswEB74DuQlUti2Ivjgt+MIcGXqD3+9sGfEv4W/WA3 bxus95A0AewD3rh0kqhNEU32rfbFRhaaAv5cJLjK6zDcZjWKogp72PuhbMKXLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=f0a15aafcb863f796e2a7f94d0fd8a857fb56103 commit f0a15aafcb863f796e2a7f94d0fd8a857fb56103 Author: Jose Luis Duran AuthorDate: 2022-10-28 09:20:33 +0000 Commit: Konstantin Belousov CommitDate: 2022-10-29 21:09:32 +0000 strfmon: Remove XXX marks phantom@'s HDD crashed with the final version of strfmon.c, as explained in 9d430a5991d3f64a75fee951a1efab3593207832. Now there are tests in place that cover these code paths. Reviewed by: kib PR: 267410 Github PR: #620 MFC after: 1 week --- lib/libc/stdlib/strfmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/libc/stdlib/strfmon.c b/lib/libc/stdlib/strfmon.c index aee053a26ec8..ba02544eb2ec 100644 --- a/lib/libc/stdlib/strfmon.c +++ b/lib/libc/stdlib/strfmon.c @@ -324,7 +324,7 @@ vstrfmon_l(char * __restrict s, size_t maxsize, locale_t loc, if (cs_precedes == 1) { if (sign_posn == 1 || sign_posn == 3) { PRINTS(signstr); - if (sep_by_space == 2) /* XXX: ? */ + if (sep_by_space == 2) PRINT(' '); } @@ -363,7 +363,7 @@ vstrfmon_l(char * __restrict s, size_t maxsize, locale_t loc, || sign_posn == 2 || sign_posn == 4))) PRINT(space_char); - PRINTS(currency_symbol); /* XXX: len */ + PRINTS(currency_symbol); if (sign_posn == 4) { if (sep_by_space == 2) PRINT(' '); @@ -597,7 +597,7 @@ __format_grouped_double(double value, int *flags, } if ((*flags & NEED_GROUPING) && - thousands_sep_size > 0 && /* XXX: need investigation */ + thousands_sep_size > 0 && *grouping != CHAR_MAX && *grouping > 0) { while (avalue_size > (int)*grouping) {