From nobody Mon Oct 24 15:57:49 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mx08Y55bdz4g3Ss; Mon, 24 Oct 2022 15:57:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mx08Y4Vv9z3Z16; Mon, 24 Oct 2022 15:57:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666627069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WfrwuYEey8W1+hhvQjbCHgugZxM6vb34dSLgOvEFG4k=; b=UlbUZQhbsYIfWMHSNOglYtqOQadft0oPEt52+c4QYg6fzZHr1lKNjHhd8gWeuwz9OIQbr/ ikKd0Guk0iuMVOliJmUUg/2D7CPYP4d/Af6iui2FLeUW5gesgcA64HfZLKyfH/tRXUy2gW AS1dhElR8f64ASwGtyOFBoGO9K2xUjqcMHXWVOGAW++BUIrHG49okjRdaboG1EGbVbI3wA JNLItEm11mpj0iex+Nef7ol2ep1GFiLYSrGnhlAdsTuemO+zQz5eBgOZGHBPRNKDdUbuMk WQyRfSCMy4Puj/VNBkgqrtpqyEGpmNvZfKk3FIUQg/iOw1gVACWhZUuKKgfu4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Mx08Y3SPHzHXt; Mon, 24 Oct 2022 15:57:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29OFvnow014254; Mon, 24 Oct 2022 15:57:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29OFvnGS014253; Mon, 24 Oct 2022 15:57:49 GMT (envelope-from git) Date: Mon, 24 Oct 2022 15:57:49 GMT Message-Id: <202210241557.29OFvnGS014253@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mitchell Horne Subject: git: a55b3c12a884 - stable/12 - ksched: correct return code for invalid priority List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: a55b3c12a88476e5cfb65ac3c88aebc17015a82f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666627069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WfrwuYEey8W1+hhvQjbCHgugZxM6vb34dSLgOvEFG4k=; b=jZRLYSDKVEdjno7T1QSEbIdeywES46EzTVnuSGsLqo64XfvfCITATm0qfip4c7+a1TOMCI 6/OmDjABBojVfPCvWqnYjcVxnYfiV+nFNFN0P9G5/XrogCaDYtMcSu+lR/V4Xfmo/W4bng vYGxPB9TMqUj5WrhRxYLwthFUWHQmBXD26/szWTCYkJw+wnCNFXUXnMRn4OSmrpKFM7hM1 DEkEbabuGiNY0KzPe5nAydlyCiaBKBImoH4BreOSkKSQTfzoMsk7VoZMvrsiAv9QUP2Dtx PcJFUH2jPfd4BB/AHWoNey/LWu9t76AjWcAJ+F+R27ydE+qpHfRuPqgpkjv8eg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666627069; a=rsa-sha256; cv=none; b=wDCy+WWEEdQ+IBU79KKT5rYdAjV2QAuZ7RHx7FV2oHtqnYWjZms8AM9r6zr0jBF461vkBj FH2zsK1Y6SE+5ANDhwcQTeqcFx6XecFVlZ/FOu4w9htAPAhvqsv0v33PxYCQCn2LuVo84d s7HdpyE8EVJ/qOc5BfmFp641VlUIIO2qxH70izZdZyzVRa1JvGI4aSZ/5/SmutZLuE+m3x 3hbGtQHNAnRuA+7WZ9vbYHgzPF+WZ5a4AjmlymUz3t2LQI/HA3i4xIa2bygStK1Tx5Bu3C cYXet+7eCDuLpLt6wJRGGhvy4pmesUmWneTOLXwZDybSsFR3EFNsY1h01U5w/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=a55b3c12a88476e5cfb65ac3c88aebc17015a82f commit a55b3c12a88476e5cfb65ac3c88aebc17015a82f Author: Ali Abdallah AuthorDate: 2022-10-17 18:11:48 +0000 Commit: Mitchell Horne CommitDate: 2022-10-24 15:56:13 +0000 ksched: correct return code for invalid priority By convention, EINVAL is returned when validating arguments, not EPERM. This matches the documented behaviour of sched_setscheduler(3), and that of SCHED_OTHER. PR: 227735 MFC after: 1 week Reviewed by: kib, markj Differential Revision: https://reviews.freebsd.org/D37021 (cherry picked from commit ba4782022ac840bd20f4e10cb95ca27d2742333a) --- sys/kern/ksched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/ksched.c b/sys/kern/ksched.c index bf03a46315c2..1d5cfb26cacd 100644 --- a/sys/kern/ksched.c +++ b/sys/kern/ksched.c @@ -186,7 +186,7 @@ ksched_setscheduler(struct ksched *ksched, struct thread *td, int policy, RTP_PRIO_REALTIME; rtp_to_pri(&rtp, td); } else { - e = EPERM; + e = EINVAL; } break; case SCHED_OTHER: