From nobody Wed Oct 19 12:45:48 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Msr7J4j7mz4fsL1; Wed, 19 Oct 2022 12:45:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Msr7J4G7fz3D6D; Wed, 19 Oct 2022 12:45:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666183548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KqiW40tUeamUuemGKEPYVTxnECy8xrnz95UxLM5JEyo=; b=L5iwpwnyvTawNsoC5/61vhHHAqm5cl3sy6Ayggy5pQXMenNTNCbAJX36PTawlMsMUG+CGm KDhKlhh70UM9GIfV9jltKkneK0/zIakMJY0aeIGBxIIwDHaT5Zx68h/dE1fWphMSusZJpd I0EHzVpHxKZMXiezSs6e6J8S6D9Nbp7A6w8mzCXOearqVZruKDAGs3Lxw3v6j3rIU+AmEN bZ00gYpmGWKTKxGX5SQXgV5Sp+rR/um35N6AR4rSR5Pa1gXFHEyMVOSTzrGrNdMAGXNtvk bo/EJmOcDaZWU1FzsoVfCL7DNGMzyOgm0+zXF8maKSwU6968DVGk7ISakqqw6g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Msr7J3KmQzXY2; Wed, 19 Oct 2022 12:45:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29JCjmMO021458; Wed, 19 Oct 2022 12:45:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29JCjmjK021457; Wed, 19 Oct 2022 12:45:48 GMT (envelope-from git) Date: Wed, 19 Oct 2022 12:45:48 GMT Message-Id: <202210191245.29JCjmjK021457@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: =?utf-8?Q?Kornel=20Dul=C4=99ba?= Subject: git: 7a3d9a7d49f1 - stable/13 - qoriq_dw_pci: Fix typo in link status checking code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kd X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 7a3d9a7d49f1652aa617c42fe994335cd59cd2ce Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666183548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KqiW40tUeamUuemGKEPYVTxnECy8xrnz95UxLM5JEyo=; b=fMfuvTvgN7PRP7Kqh0qNsKD22c1INlwhiB89vTckzP13g+cK9U8zZFOpky5DqPBtEdCdWs r8aIm8pIAVaxCRwy8rEvPElBWPgRVr0EmYYTZEY8R4AnrIFFyBsruxJ5AZE7LxUj94KPxW IfcolatzA+kcglnRFPwx63FHLX0WZ4y2aY7sxaXjBA4gYx94wT5U7wL7jLxW+kP6ZeKts9 O04yISrWObwT/y/E0moSYZvtKyi+5VV5KVSPB2N4sbeewIV/6VyZgV+REGDsF6zCc6aVps WYtWJZaqxwWZZle1Rebbb+mlwlC7nfoLCwcnk4AKkdXzbbC86tqAYBFfz0Ep2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666183548; a=rsa-sha256; cv=none; b=bhZbMz8DUBT9xF+1zgZXQ5z00hBX6u5K14dn20mkNx1Zu7onAdkmO3UAXbLGW9RHjvGV2S p+TCqAw3PAjI2th1i8EpRHlhv95WyGktFrxp1kNxlaQdcLxAr/ZgB58lSPWk0/7HFfQUBC HDfJGAVr8M8Nr2PONiSql/hK1lrKDWgp7/9De9Y/FEh5m0w0HOpU+j2+wU5B8HM9YMq1y4 gpuIki+wsBdh43k+KyTsoI3znxn8MtnN6DbU2yy485pJ/eQpN7M+aCmIxkMKijzIq9Y4Eq jxq1dp1Zn1F1hJ8122t677K29MfKud8P9o690efV5YJeQ4hAoEf49WBnyqn51w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by kd: URL: https://cgit.FreeBSD.org/src/commit/?id=7a3d9a7d49f1652aa617c42fe994335cd59cd2ce commit 7a3d9a7d49f1652aa617c42fe994335cd59cd2ce Author: Bartlomiej Grzesik AuthorDate: 2021-08-31 04:22:33 +0000 Commit: Kornel Dulęba CommitDate: 2022-10-19 12:42:35 +0000 qoriq_dw_pci: Fix typo in link status checking code On some DesignWare PCIe controllers accessing config registers of slots whose link is down triggers a SError. Because of that we need to check the link status before any acceses config space. Due to a typo link was always reported up. This fixes a SError that occured during boot on LS1028A-RDB. Obtained from: Semihalf Reviewed by: wma Differential revision: https://reviews.freebsd.org/D31509 (cherry picked from commit df9c0e88e1e30cb5d1c81c4c2f295f7d153ed02b) --- sys/arm64/qoriq/qoriq_dw_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/qoriq/qoriq_dw_pci.c b/sys/arm64/qoriq/qoriq_dw_pci.c index 424a030e094c..d052c9910a47 100644 --- a/sys/arm64/qoriq/qoriq_dw_pci.c +++ b/sys/arm64/qoriq/qoriq_dw_pci.c @@ -150,7 +150,7 @@ qorif_dw_pci_get_link(device_t dev, bool *status) reg = pci_dw_dbi_rd4(sc->dev, sc->soc_cfg->pex_pf0_dgb); reg >>= sc->soc_cfg->ltssm_bit; reg &= 0x3F; - *status = (reg = 0x11) ? true: false; + *status = (reg == 0x11) ? true : false; return (0); }