From nobody Tue Oct 18 14:33:06 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MsGYZ5P2Rz4fwyq; Tue, 18 Oct 2022 14:33:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MsGYZ4tcCz3Kny; Tue, 18 Oct 2022 14:33:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666103586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dFVE516vdcXBUtznrm54XTYFcDasVv3rN/uMVYp1WQc=; b=xMRxJrXt2LLsS3Ih0NwCoRflz0fGUv0552CRa5ubGrUbVtwWIaoaih6lU4JzNnsaR0o6cd Oqusq/vlzYysECSbzgkeuWsmbYWdK/rTTKAq9vOYFykR9zivnAAKEgjR1JthdNHrKU4DOX 5HT2PjVYVzEJYUqATXF6I7PokEvjPLr/SyTEVcoN5gkXk4G2puxMvZwkqMDRsbhljdxE3o EoOxFdpkc85/YnbzaQQsnnXTx7RiobmDFNnRxm6s3JIsDAMZuYEsqh2gX4x6Fql/tkxIEl KEP1rLhWt2I4IFVaCOzorCGvgJtpXjOx9QldEdlO9jd3BuxoQgsu0p7cTt2cHw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MsGYZ3x21z1Bsq; Tue, 18 Oct 2022 14:33:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29IEX6mn029394; Tue, 18 Oct 2022 14:33:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29IEX6tH029393; Tue, 18 Oct 2022 14:33:06 GMT (envelope-from git) Date: Tue, 18 Oct 2022 14:33:06 GMT Message-Id: <202210181433.29IEX6tH029393@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mitchell Horne Subject: git: ed620ade7fbb - stable/13 - Revert "bus.h: rewrite comment describing intr_type" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ed620ade7fbbc18cc93ebaee0368727e4c2f27c5 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666103586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dFVE516vdcXBUtznrm54XTYFcDasVv3rN/uMVYp1WQc=; b=hDu/LS0TOow2f/RsrbVE7ZS0NKM73LtJTr3uttTA/KsgUcEuBlXvO6z/e/dei85dyIQcsG idheQmpigibGgPSVHtOypAo4V9pB+WjKO/AzFLUXfhi093vJLSHiTkn2OTXo7zwK1nnjBN AEkavy7bhpNhFjUoSA/XnvBFqi9o4g2Td1W5X3ANSgU6alsDFSJtJU2hg237CLX64g3B3T x6SR+hAklr/kRSvE6Ya5/f2iqsNoc3r0ezHZ22LStoNz8CXO3mF5DNtk8XyUhynPbYHw02 EexMScjBHPZC9psjbF3mH1cS3d8MDvVnfa2c+sJ8cZDy99NOpOpOqXUwqPXdpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666103586; a=rsa-sha256; cv=none; b=LC1cOfFi6Rg/fxqSOWEaBBS+Q45ggiwoBTSs/QQi1PGDtPotZ8euRbKPB60+ipokcARhB9 dO2g9KAV0gNoNuRIiBiLohBeOKcosfXSv3Vk8StpyEqY3Kck7zeFl6s6Pr2Y5+NFXPgF8P GcKbVSMkuwTdTazV6gq/zbkG8E+ODJ1B07DcbJNAnzZEjEPN1o/hQlkn96lWqLAq0YEgSw ijeAHzuiIkApIjN65BwjD+TOVt0mhf1ZfP8Yx3I/qGfwCBLhdVIyuRp+o+UNi1cQNjjiWz bPnw1Ex06OLXYQx3P5Bi0tFf41J+xQ3VIZ6Lm+ZvzqqS5wyvAXhoVqcK62jiUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=ed620ade7fbbc18cc93ebaee0368727e4c2f27c5 commit ed620ade7fbbc18cc93ebaee0368727e4c2f27c5 Author: Mitchell Horne AuthorDate: 2022-10-18 14:13:24 +0000 Commit: Mitchell Horne CommitDate: 2022-10-18 14:13:24 +0000 Revert "bus.h: rewrite comment describing intr_type" This reverts commit fff5fec16b2ec42b0cb357fdbb675353e3126f21. It needs slight modification for stable/13 which does not have collapsed interrupt thread priorities. --- sys/sys/bus.h | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/sys/sys/bus.h b/sys/sys/bus.h index 115f20505bae..430beaecc6d0 100644 --- a/sys/sys/bus.h +++ b/sys/sys/bus.h @@ -251,19 +251,17 @@ typedef void driver_intr_t(void*); /** * @brief Interrupt type bits. + * + * These flags are used both by newbus interrupt + * registration (nexus.c) and also in struct intrec, which defines + * interrupt properties. * - * These flags may be passed by drivers to bus_setup_intr(9) when - * registering a new interrupt handler. The field is overloaded to - * specify both the interrupt's type and any special properties. + * XXX We should probably revisit this and remove the vestiges of the + * spls implicit in names like INTR_TYPE_TTY. In the meantime, don't + * confuse things by renaming them (Grog, 18 July 2000). * - * The INTR_TYPE* bits will be passed to intr_priority(9) to determine - * the scheduling priority of the handler's ithread. Historically, each - * type was assigned a unique scheduling preference, but now only - * INTR_TYPE_CLK receives a default priority higher than other - * interrupts. See sys/priority.h. - * - * Buses may choose to modify or augment these flags as appropriate, - * e.g. nexus may apply INTR_EXCL. + * Buses which do interrupt remapping will want to change their type + * to reflect what sort of devices are underneath. */ enum intr_type { INTR_TYPE_TTY = 1,