Re: git: 89a9a13c1a91 - main - Remove unneeded FDT checks from phydev and regdev

> On 5 Oct 2022, at 07:45, Emmanuel Vadot <manu@bidouilliste.com> wrote:
> 
> On Tue, 4 Oct 2022 16:39:45 GMT
> Andrew Turner <andrew@FreeBSD.org <mailto:andrew@FreeBSD.org>> wrote:
> 
>> The branch main has been updated by andrew:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=89a9a13c1a917715c047ef9b0d7bd3f6416bb13b
>> 
>> commit 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b
>> Author:     Andrew Turner <andrew@FreeBSD.org>
>> AuthorDate: 2022-10-04 16:27:59 +0000
>> Commit:     Andrew Turner <andrew@FreeBSD.org>
>> CommitDate: 2022-10-04 16:37:37 +0000
>> 
>>    Remove unneeded FDT checks from phydev and regdev
>> 
>>    They are only ever built when FDT is enabled so there is no need to
>>    check for it in the files.
>> 
>>    Sponsored by:   The FreeBSD Foundation
>> ---
>> sys/dev/extres/phy/phydev_if.m       | 5 -----
>> sys/dev/extres/regulator/regdev_if.m | 6 ------
>> 2 files changed, 11 deletions(-)
> 
> Pretty sure that mmel@'s goal was to make this available for every
> platform at one point.
> But if someone will do the work re-adding those isn't hard (and I
> don't see it happening anytime soon anyway ...).

Both of these files only defined one method that takes FDT/OFW specific types. We can re-add them later if needed, however currently any line starting with a # is a comment, other than a special case for #include so they do nothing. I have a local patch to support them so notice when these failed to build due to opt_platform.h not being included.

Andrew