From nobody Mon Oct 03 23:11:35 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhGml24b5z4V1Mp; Mon, 3 Oct 2022 23:11:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhGml1YtFz3QvV; Mon, 3 Oct 2022 23:11:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664838695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8L15SCY6meQiztKLzUXKhHpYH/ydmeyTggsOXHG7wV4=; b=Dyl0XkmA2PRpXt62rLifg6vck/ULDJcR7kDcVVMqDRB6oPUbITycdyAm3xNxxlrL3K3Hgh tORPlVlw8nEN6It4iFi3wp/0t1UHkMxjfFFnJ4JxRnQIQSXuhQwl/6oeWUL0PVsEG2NtDU QV2HK8OYTrWuEQv3zWwtk01ytahnFgaOxdH0EpUkTrURsKbs5a+fIZ3RXrHERkK/yCGjgw EwAdXaPsFwdVNv6RL8VuFEvcfaKYgg6dm1Z90TDhvoTvBLnqh04xD7OjfJaTLh/GH0c0BI UhoEVr0sfLujeuVkuKLamm9ICHxCvUpZ40mOF3q6sMUPQQE07osuX+egt9BgxQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MhGml0gr5zMgX; Mon, 3 Oct 2022 23:11:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 293NBZet065915; Mon, 3 Oct 2022 23:11:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 293NBZxI065914; Mon, 3 Oct 2022 23:11:35 GMT (envelope-from git) Date: Mon, 3 Oct 2022 23:11:35 GMT Message-Id: <202210032311.293NBZxI065914@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 2fb81691b02f - main - bhyve: Don't free an invalid pointer. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2fb81691b02f27fa938f311835a8c6704c5cf80f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664838695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8L15SCY6meQiztKLzUXKhHpYH/ydmeyTggsOXHG7wV4=; b=QRqgk06VwLb68086CHS07otoiptk+xZppCruPBexvTRzD8Rhdy6vj0pRigpu9vokVizJHk g4UimrsSvDCqZMH10DzH/Hm9Ib/RAELciQuAxWqQfZgJT5ShlGGd4i0IrV0R91gF+lrHsF FGKIchhMqWL/ln3I/+OD+X/IDOC4nL3JNL5ES7cez/RwS7WVrgOtcVnReM/48kp3bSH9oi 465nKatbbvPKaSaQUhTzjzc2iA2jnXUdleLhW7EvpLqgY4L1jte3JarT4W9FNIJxdZLPG3 0BR9TPWbT6bif6eI1k//0CNuMzL6ijPLroRIBxC2HChENC7U0isvHaSJvcsEqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664838695; a=rsa-sha256; cv=none; b=Pvv6cO+8l8AuKOwhkgpUi6DL5Nh3sDYYERzILSz8dDBogQ3WYAalZrr6zRa3IuItZTDGn0 G2pOHoWtO/SGytmsEgstIRAm1xfj7noULdgUoj2SblEboaiybsuhIT2VYlDuuVg1K8QCN2 9qeUfZ7/3ZdlZkNqxGtUP9vaqC0xUyOblN1ow1fR0/mjIm5ptcCBINpA2PU4sbORCMKlEJ +173oarA8P9NsyQwl267sxkelfibNxh7KNSjZS7OPQwxxYFhFqJfH/4vFUFFEq2uNckWO5 qdeybNBYrV7xCdsJ+Qxo2SohrpxScwqqn/BoyZs7NH6E2FIAuiIUahW+ULlL5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=2fb81691b02f27fa938f311835a8c6704c5cf80f commit 2fb81691b02f27fa938f311835a8c6704c5cf80f Author: John Baldwin AuthorDate: 2022-10-03 23:10:44 +0000 Commit: John Baldwin CommitDate: 2022-10-03 23:10:44 +0000 bhyve: Don't free an invalid pointer. The netmap-specific data stored at be->opaque is freed by the caller on error as part of freeing be. Reviewed by: markj Reported by: GCC -Wfree-nonheap-object Differential Revision: https://reviews.freebsd.org/D36828 --- usr.sbin/bhyve/net_backends.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/bhyve/net_backends.c b/usr.sbin/bhyve/net_backends.c index 0f1db7c8cfeb..adb3006f415b 100644 --- a/usr.sbin/bhyve/net_backends.c +++ b/usr.sbin/bhyve/net_backends.c @@ -695,7 +695,6 @@ netmap_init(struct net_backend *be, const char *devname, if (priv->nmd == NULL) { WPRINTF(("Unable to nm_open(): interface '%s', errno (%s)", devname, strerror(errno))); - free(priv); return (-1); }