From nobody Mon Oct 03 20:47:03 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhCZ42d8Nz4f8Df; Mon, 3 Oct 2022 20:47:08 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhCZ41TZrz4B6N; Mon, 3 Oct 2022 20:47:08 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from [10.36.2.155] (unknown [178.232.223.95]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id B80AE26052D; Mon, 3 Oct 2022 22:47:06 +0200 (CEST) Message-ID: Date: Mon, 3 Oct 2022 22:47:03 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: git: 8f0a3c9c3551 - main - cuse(3): Use bool type for boolean value instead of int type. Content-Language: en-US To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202210031536.293Favom085163@gitrepo.freebsd.org> From: Hans Petter Selasky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MhCZ41TZrz4B6N X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 10/3/22 19:49, Jessica Clarke wrote: > On 3 Oct 2022, at 16:36, Hans Petter Selasky wrote: >> >> The branch main has been updated by hselasky: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=8f0a3c9c35517e61f4f64ce5b252202b8ddfa313 >> >> commit 8f0a3c9c35517e61f4f64ce5b252202b8ddfa313 >> Author: Hans Petter Selasky >> AuthorDate: 2022-10-03 15:26:43 +0000 >> Commit: Hans Petter Selasky >> CommitDate: 2022-10-03 15:35:14 +0000 >> >> cuse(3): Use bool type for boolean value instead of int type. >> >> No functional change intended. >> >> Reviewed by: imp @ >> Differential Revision: https://reviews.freebsd.org/D36633 >> MFC after: 1 week >> Sponsored by: NVIDIA Networking >> --- >> sys/fs/cuse/cuse.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/sys/fs/cuse/cuse.c b/sys/fs/cuse/cuse.c >> index 62b53d232ee2..a870df1b07dc 100644 >> --- a/sys/fs/cuse/cuse.c >> +++ b/sys/fs/cuse/cuse.c >> @@ -822,7 +822,7 @@ cuse_server_write(struct cdev *dev, struct uio *uio, int ioflag) >> static int >> cuse_server_ioctl_copy_locked(struct cuse_server *pcs, >> struct cuse_client_command *pccmd, >> - struct cuse_data_chunk *pchk, int isread) >> + struct cuse_data_chunk *pchk, bool isread) >> { >> struct proc *p_proc; >> uint32_t offset; >> @@ -850,7 +850,7 @@ cuse_server_ioctl_copy_locked(struct cuse_server *pcs, >> >> cuse_server_unlock(pcs); >> >> - if (isread == 0) { >> + if (isread == false) { > > !isread? (also below) > > Jess > >> error = copyin( >> (void *)pchk->local_ptr, >> pccmd->client->ioctl_buffer + offset, >> @@ -929,7 +929,7 @@ cuse_proc2proc_copy(struct proc *proc_s, vm_offset_t data_s, >> static int >> cuse_server_data_copy_locked(struct cuse_server *pcs, >> struct cuse_client_command *pccmd, >> - struct cuse_data_chunk *pchk, int isread) >> + struct cuse_data_chunk *pchk, bool isread) >> { >> struct proc *p_proc; >> int error; >> @@ -945,7 +945,7 @@ cuse_server_data_copy_locked(struct cuse_server *pcs, >> >> cuse_server_unlock(pcs); >> >> - if (isread == 0) { >> + if (isread == false) { >> error = cuse_proc2proc_copy( >> curthread->td_proc, pchk->local_ptr, >> p_proc, pchk->peer_ptr, > > > Jess > Feel free to fix it if you think it is worth a commit! --HPS