From nobody Mon Oct 03 17:49:24 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mh7d36c6kz4dp2F for ; Mon, 3 Oct 2022 17:49:27 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mh7d30Rjdz3v9f for ; Mon, 3 Oct 2022 17:49:27 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f46.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso9494788wma.1 for ; Mon, 03 Oct 2022 10:49:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=gpNEjuN7+yb91NUVIn7dp0HyLP/149Qx9D9yHCGcqN4=; b=UYTzAORAuFnn/vDM/fq/0Ot1xNcIzcV7tX+khOzsDyhaMZmODJNFUWU2ZGuivXTClc kBbdm/g9vCQ7hc1oXkzuZqn6N74TxGgcK4pNSmDbWpBrq8MaP4LeHSyuB+EhYtk71hC9 omiSWGLAQqRdVIMjtzwzbLQLxEEebDefn3PAH+10zGOsrBRy/qiKNw56LvsPzEBU+Aqv JwwaL/+GsaisTE7ZQa78+Jd/HgeSdGKkBL4sszXjUcSwOHX7rxP28p9uCY1RskPsG2jR ze9Ow/S6O+eoxBV/F+LHSMT6g3hX4wBLmhSGy/R6gegUSF5FoxEszvA5yf7MFzjTGR9n hXmQ== X-Gm-Message-State: ACrzQf0G49vuXKi6LUkbYocxzoP6Nl2JE4EDBUT0j36QbmEOTaj5kpf5 uY5ywj8ynRaMFa5k8GBxTCM2/IxH2KPLNk3k X-Google-Smtp-Source: AMsMyM7b3dA2gGE8Ps3Pzx7lqbNoz6Qz+28fWPASW8u+9lHrn+l3trgAKrPOA6P1NtOvlB19Wa8LYA== X-Received: by 2002:a05:600c:3543:b0:3b4:ba45:9945 with SMTP id i3-20020a05600c354300b003b4ba459945mr7531660wmq.58.1664819365775; Mon, 03 Oct 2022 10:49:25 -0700 (PDT) Received: from smtpclient.apple (global-5-141.n-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id y9-20020a5d4ac9000000b0021badf3cb26sm12767716wrs.63.2022.10.03.10.49.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2022 10:49:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 8f0a3c9c3551 - main - cuse(3): Use bool type for boolean value instead of int type. From: Jessica Clarke In-Reply-To: <202210031536.293Favom085163@gitrepo.freebsd.org> Date: Mon, 3 Oct 2022 18:49:24 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202210031536.293Favom085163@gitrepo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4Mh7d30Rjdz3v9f X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.46:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.46:from] X-ThisMailContainsUnwantedMimeParts: N On 3 Oct 2022, at 16:36, Hans Petter Selasky = wrote: >=20 > The branch main has been updated by hselasky: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8f0a3c9c35517e61f4f64ce5b252202b= 8ddfa313 >=20 > commit 8f0a3c9c35517e61f4f64ce5b252202b8ddfa313 > Author: Hans Petter Selasky > AuthorDate: 2022-10-03 15:26:43 +0000 > Commit: Hans Petter Selasky > CommitDate: 2022-10-03 15:35:14 +0000 >=20 > cuse(3): Use bool type for boolean value instead of int type. >=20 > No functional change intended. >=20 > Reviewed by: imp @ > Differential Revision: https://reviews.freebsd.org/D36633 > MFC after: 1 week > Sponsored by: NVIDIA Networking > --- > sys/fs/cuse/cuse.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/sys/fs/cuse/cuse.c b/sys/fs/cuse/cuse.c > index 62b53d232ee2..a870df1b07dc 100644 > --- a/sys/fs/cuse/cuse.c > +++ b/sys/fs/cuse/cuse.c > @@ -822,7 +822,7 @@ cuse_server_write(struct cdev *dev, struct uio = *uio, int ioflag) > static int > cuse_server_ioctl_copy_locked(struct cuse_server *pcs, > struct cuse_client_command *pccmd, > - struct cuse_data_chunk *pchk, int isread) > + struct cuse_data_chunk *pchk, bool isread) > { > struct proc *p_proc; > uint32_t offset; > @@ -850,7 +850,7 @@ cuse_server_ioctl_copy_locked(struct cuse_server = *pcs, >=20 > cuse_server_unlock(pcs); >=20 > - if (isread =3D=3D 0) { > + if (isread =3D=3D false) { !isread? (also below) Jess > error =3D copyin( > (void *)pchk->local_ptr, > pccmd->client->ioctl_buffer + offset, > @@ -929,7 +929,7 @@ cuse_proc2proc_copy(struct proc *proc_s, = vm_offset_t data_s, > static int > cuse_server_data_copy_locked(struct cuse_server *pcs, > struct cuse_client_command *pccmd, > - struct cuse_data_chunk *pchk, int isread) > + struct cuse_data_chunk *pchk, bool isread) > { > struct proc *p_proc; > int error; > @@ -945,7 +945,7 @@ cuse_server_data_copy_locked(struct cuse_server = *pcs, >=20 > cuse_server_unlock(pcs); >=20 > - if (isread =3D=3D 0) { > + if (isread =3D=3D false) { > error =3D cuse_proc2proc_copy( > curthread->td_proc, pchk->local_ptr, > p_proc, pchk->peer_ptr, Jess