From nobody Mon Oct 03 16:31:07 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mh5tl1T3Fz4ddQ9; Mon, 3 Oct 2022 16:31:11 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mh5tk3p20z3P7H; Mon, 3 Oct 2022 16:31:10 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id fKmMo0kwoS8WrfOLVoJJ42; Mon, 03 Oct 2022 16:31:09 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id fOLTo4olClQu6fOLUo4ez1; Mon, 03 Oct 2022 16:31:09 +0000 X-Authority-Analysis: v=2.4 cv=YfOuWidf c=1 sm=1 tr=0 ts=633b0e4d a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=8nJEP1OIZ-IA:10 a=Qawa6l4ZSaYA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=ky0l3ZjuEhUVCp_otYAA:9 a=wPNLvfGTeEIA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id B2827171; Mon, 3 Oct 2022 09:31:07 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A5459118; Mon, 3 Oct 2022 09:31:07 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: =?utf-8?Q?Dag-Erling=20Sm=C3=B8rgrav?= cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, portmgr@freebsd.org Subject: Re: git: 0aa2700123e2 - main - Put OPIE to rest. In-reply-to: <202210020138.2921cD8f045654@gitrepo.freebsd.org> References: <202210020138.2921cD8f045654@gitrepo.freebsd.org> Comments: In-reply-to =?utf-8?Q?Dag-Erling=20Sm=C3=B8rgrav?= message dated "Sun, 02 Oct 2022 01:38:13 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Mon, 03 Oct 2022 09:31:07 -0700 Message-Id: <20221003163107.A5459118@slippy.cwsent.com> X-CMAE-Envelope: MS4xfPndQEBCxPFHZ3GN2Bk2S0zKkxw6ILV5WQU4NF7ynV7ZJZA8hq4XmaHRO/5zaH8xAIRi0n8VjEfbRIMqZsduoJ7sVFQO6Jxeoq7jx4ocbyysbVo8RLI1 MfqcYt8Z6f2ea8lgT51/rH7bmtMrdcLfe+ACOtL73bN7Fy8kPWHLjHW9r+FHh5qotAx66JhiJvLWYrUVAlv3uoZQyHwbxsJ1R/kssjfQUvsJBXNZNZegDjtE kMeMh14bUC64iRc+Qweu1YTFylyLTDNWX+ZxHBgAGzD+heWwc8ChlxEADcLxRXFkuPbCWQe8cgkicyAiRzLzjOG+Nl0s+Z62MfPSVICm98H1Nuv+6mr7y3g6 biT2JweJ X-Rspamd-Queue-Id: 4Mh5tk3p20z3P7H X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.32) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.80 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.32:from]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N In message <202210020138.2921cD8f045654@gitrepo.freebsd.org>, =?utf-8?Q?Dag-Erl ing=20Sm=C3=B8rgrav?= writes: > The branch main has been updated by des: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0aa2700123e22c2b0a977375e087dc27 > 59b8e980 > > commit 0aa2700123e22c2b0a977375e087dc2759b8e980 > Author: Dag-Erling Smørgrav > AuthorDate: 2022-10-02 01:37:29 +0000 > Commit: Dag-Erling Smørgrav > CommitDate: 2022-10-02 01:37:29 +0000 > > Put OPIE to rest. > > Differential Revision: https://reviews.freebsd.org/D36592 > --- > Makefile.inc1 | 4 +- > ObsoleteFiles.inc | 30 + > contrib/opie/BUG-REPORT | 85 - > contrib/opie/COPYRIGHT.NRL | 68 - > contrib/opie/INSTALL | 178 - > contrib/opie/License.TIN | 45 - > contrib/opie/Makefile.in | 327 -- > contrib/opie/README | 508 -- > contrib/opie/acconfig.h | 226 - > contrib/opie/config.h.in | 450 -- > contrib/opie/config.testeflag | 12 - > contrib/opie/configure | 5247 ------------------ > -- > contrib/opie/configure.in | 562 --- > contrib/opie/configure.munger.in | 16 - > contrib/opie/ftpcmd.y | 1290 ----- > contrib/opie/glob.c | 668 --- > contrib/opie/install-sh | 238 - > contrib/opie/libmissing/Makefile.in | 34 - > contrib/opie/libmissing/bogus.c | 1 - > contrib/opie/libmissing/endutent.c | 19 - > contrib/opie/libmissing/getutline.c | 63 - > contrib/opie/libmissing/pututline.c | 64 - > contrib/opie/libmissing/setutent.c | 18 - > contrib/opie/libopie/Makefile.in | 35 - > contrib/opie/libopie/accessfile.c | 171 - > contrib/opie/libopie/atob8.c | 76 - > contrib/opie/libopie/btoa8.c | 34 - > contrib/opie/libopie/btoe.c | 2267 --------- > contrib/opie/libopie/btoh.c | 36 - > contrib/opie/libopie/challenge.c | 79 - > contrib/opie/libopie/generator.c | 398 -- > contrib/opie/libopie/getsequence.c | 27 - > contrib/opie/libopie/getutmpentry.c | 85 - > contrib/opie/libopie/hash.c | 78 - > contrib/opie/libopie/hashlen.c | 69 - > contrib/opie/libopie/insecure.c | 172 - > contrib/opie/libopie/keycrunch.c | 66 - > contrib/opie/libopie/lock.c | 255 - > contrib/opie/libopie/login.c | 124 - > contrib/opie/libopie/logwtmp.c | 197 - > contrib/opie/libopie/lookup.c | 31 - > contrib/opie/libopie/md4c.c | 267 - > contrib/opie/libopie/md5c.c | 304 -- > contrib/opie/libopie/newseed.c | 96 - > contrib/opie/libopie/open.c | 77 - > contrib/opie/libopie/parsechallenge.c | 82 - > contrib/opie/libopie/passcheck.c | 50 - > contrib/opie/libopie/passwd.c | 76 - > contrib/opie/libopie/randomchallenge.c | 50 - > contrib/opie/libopie/readpass.c | 315 -- > contrib/opie/libopie/readrec.c | 167 - > contrib/opie/libopie/unlock.c | 103 - > contrib/opie/libopie/verify.c | 222 - > contrib/opie/libopie/version.c | 29 - > contrib/opie/libopie/writerec.c | 89 - > contrib/opie/opie.4 | 342 -- > contrib/opie/opie.h | 179 - > contrib/opie/opie_cfg.h | 184 - > contrib/opie/opieaccess.5 | 92 - > contrib/opie/opieauto.c | 386 -- > contrib/opie/opieftpd.8 | 294 -- > contrib/opie/opieftpd.c | 1715 ------- > contrib/opie/opiegen.1 | 90 - > contrib/opie/opiegen.c | 88 - > contrib/opie/opieinfo.1 | 103 - > contrib/opie/opieinfo.c | 105 - > contrib/opie/opiekey.1 | 176 - > contrib/opie/opiekey.c | 347 -- > contrib/opie/opiekeys.5 | 72 - > contrib/opie/opielogin.1 | 131 - > contrib/opie/opielogin.c | 1458 ------ > contrib/opie/opiepasswd.1 | 181 - > contrib/opie/opiepasswd.c | 442 -- > contrib/opie/opieserv.1 | 82 - > contrib/opie/opieserv.c | 83 - > contrib/opie/opiesu.1 | 101 - > contrib/opie/opiesu.c | 512 -- > contrib/opie/opietest.c | 310 -- > contrib/opie/permsfile.c | 167 - > contrib/opie/popen.c | 216 - > contrib/telnet/telnet/telnet.1 | 4 - > etc/mtree/BSD.var.dist | 2 - > lib/Makefile | 4 +- > lib/libopie/Makefile | 40 - > lib/libopie/Makefile.depend | 18 - > lib/libopie/config.h | 381 -- > lib/libopie/opieaccess | 13 - > lib/libopie/opieextra.c | 98 - > lib/libpam/modules/modules.inc | 2 - > lib/libpam/modules/pam_opie/Makefile | 36 - > lib/libpam/modules/pam_opie/Makefile.depend | 19 - > lib/libpam/modules/pam_opie/pam_opie.8 | 127 - > lib/libpam/modules/pam_opie/pam_opie.c | 157 - > lib/libpam/modules/pam_opieaccess/Makefile | 11 - > lib/libpam/modules/pam_opieaccess/Makefile.depend | 18 - > lib/libpam/modules/pam_opieaccess/pam_opieaccess.8 | 146 - > lib/libpam/modules/pam_opieaccess/pam_opieaccess.c | 97 - > lib/libpam/pam.d/ftpd | 2 - > lib/libpam/pam.d/other | 2 - > lib/libpam/pam.d/sshd | 2 - > lib/libpam/pam.d/system | 2 - > lib/libpam/static_libpam/Makefile.depend | 2 - > lib/libsysdecode/Makefile.depend | 1 - > libexec/ftpd/Makefile | 5 +- > libexec/ftpd/Makefile.depend | 1 - > libexec/ftpd/ftpd.8 | 10 - > libexec/ftpd/ftpd.c | 34 +- > share/examples/etc/README.examples | 1 - > share/mk/bsd.libnames.mk | 1 - > share/mk/src.libnames.mk | 4 +- > targets/pseudo/userland/lib/Makefile.depend | 3 - > usr.bin/Makefile | 3 - > usr.bin/opieinfo/Makefile | 21 - > usr.bin/opieinfo/Makefile.depend | 19 - > usr.bin/opiekey/Makefile | 23 - > usr.bin/opiekey/Makefile.depend | 19 - > usr.bin/opiepasswd/Makefile | 21 - > usr.bin/opiepasswd/Makefile.depend | 19 - > usr.sbin/pw/pw_user.c | 35 - > usr.sbin/pw/tests/pw_userdel_test.sh | 2 - > 120 files changed, 39 insertions(+), 25502 deletions(-) > It's a little late now since we've already had a __FreeBSD_version update since this but this change affected at least two installed ports/pkgs here -- fetchmail and cyrus-sasl. Fetchmail needed a patch to specifically disable OPIE in __FreeBSD_version > 1400071 and cyrus-sasl needed a simple rebuilt. I think the ports team should review which ports might be affected, maybe even an exp-run. I'm sure the two I found are not all of them. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0