From nobody Tue Nov 29 23:15:32 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NMJ90330pz4hpvQ; Tue, 29 Nov 2022 23:15:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NMJ902PR4z3wY5; Tue, 29 Nov 2022 23:15:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669763732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ss/HMMllJPp3YqmJ/s40AdoR9/56mHgjmViaRw76350=; b=QC4OHNNTaQPAN+5j/624Ln8sfhrH3DoJpRXlo3ViOD++3SsbXuhWoar6rf+gOnNzkhHn5/ VhPDwRe05V6fhLVaN6qnVNdl57G9Jt6xuWuoqRtDYlBhPTMPuhFnu7mXqO8v/F/Ybia6j0 L+PCa9NTMjs08np3xkcD//QpWo5nznlNNv92MFZx1LprTG8TVuHt89BaIhT0BW8TGrc2xU X4qqMK4a3CyiLzIz1asyVT0w2+Cr8kx1UEDBRPndT3YDXIztXei3zThws7XrselbX/ITkY C9Q8RrcF89lkZgwkna/8ouJxKwM/K1fQnpYdMUkILnbrQ81/1tC9dQV09Md6rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669763732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ss/HMMllJPp3YqmJ/s40AdoR9/56mHgjmViaRw76350=; b=wlVpAtrD8IBfNitkd18Jxj2FDo7OUIsTTKWbWzd9Vc5dhWNtNy+kRrzbyCN3mfxVgLi/Yf K9NlOzTsN+RQ27sYvWMrelM04MSX8EicVh59pAIa+yF1Aggyyhlq5huiNaBmo+HZX+79W3 Sz0VxQQ1JscOQ5MZwtIEZjAaBGe/VnVnRMuN08auNElZyshA2p0P9CSup7F/sLoYpcNB+G zcfVM9YI5nlkIPM45qZb+LvaTkwpx66v3URfrRkSrbPfcoNQS7WLjU0ce/ORfRMRDk8YAM 3TaayJl5BlScIV9WuMUBcXhwzxceV8KzSjYR+hY6eKEIaQz5LMkbQpjA11sT1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669763732; a=rsa-sha256; cv=none; b=lLG0cnrapn54eWA+Q5eHuYFhMTwKBYyMNB+VCnKibej4535v3Oi3A0vDL3BuNpU1Dsv/13 O8d9kdGTFurSTRy4UC1UnRJeKeenmY+M+LfyxS3As+1lemqiQCMOX5rgShgychRBjg7hMi 8BQZ9B61c1bGoomW5rzW/sCNBNkLFSl7JDSfAhIfkP+QhrO7fEGL2umY/1x64lEfsj0x8R qM+8XLuo1UG2zJIEOgvL3X9JagA6pseP+qpiDZJDz+wD4qQDiNeo480b9EEnO+QU+iOkod SzejkNpcP2pSBRRQbST0NptclQH5V/P46ki+QsiSvcOBOHJliZkVmjeZZ9bwOw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NMJ901QRBzZdG; Tue, 29 Nov 2022 23:15:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2ATNFWQb027827; Tue, 29 Nov 2022 23:15:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2ATNFWFE027826; Tue, 29 Nov 2022 23:15:32 GMT (envelope-from git) Date: Tue, 29 Nov 2022 23:15:32 GMT Message-Id: <202211292315.2ATNFWFE027826@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: 10571c04c9dd - releng/13.1 - heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.1 X-Git-Reftype: branch X-Git-Commit: 10571c04c9ddb65aacdd71d7d86c5a993f506e01 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/13.1 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=10571c04c9ddb65aacdd71d7d86c5a993f506e01 commit 10571c04c9ddb65aacdd71d7d86c5a993f506e01 Author: Cy Schubert AuthorDate: 2022-11-17 15:43:29 +0000 Commit: Gordon Tetlow CommitDate: 2022-11-29 23:04:48 +0000 heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 Part of ed549cb0c53f zeroed out a data structure in the resulting code-file when a TUTCTime type was freed. This part of the patch applies to Heimdal 7.1+ and not our Heimdal 1.5.2. PR: 267827 Reported by: Peter Much Tested by: Peter Much Approved by: so Security: FreeBSD-EN-22:28.heimdal Fixes: ed549cb0c53f (cherry picked from commit f556a05c49261af3d373c599d05fa250f3563b59) (cherry picked from commit b23fe6badebad9a9b2022e95b50451a41c7b4f7a) --- crypto/heimdal/lib/asn1/gen_free.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/crypto/heimdal/lib/asn1/gen_free.c b/crypto/heimdal/lib/asn1/gen_free.c index 74449fe6ca82..b9cae7533b17 100644 --- a/crypto/heimdal/lib/asn1/gen_free.c +++ b/crypto/heimdal/lib/asn1/gen_free.c @@ -61,13 +61,6 @@ free_type (const char *name, const Type *t, int preserve) case TNull: case TGeneralizedTime: case TUTCTime: - /* - * This doesn't do much, but it leaves zeros where garbage might - * otherwise have been found. Gets us closer to having the equivalent - * of a memset()-to-zero data structure after calling the free - * functions. - */ - fprintf(codefile, "*%s = 0;\n", name); break; case TBitString: if (ASN1_TAILQ_EMPTY(t->members))