From nobody Fri Nov 11 18:37:03 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N86qz6TSfz4dbcf; Fri, 11 Nov 2022 18:37:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N86qz4WGNz3wcl; Fri, 11 Nov 2022 18:37:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668191823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fW4C9L8vjP24Zd8UENKhmjeGKRa/TvkiDdryxntQu84=; b=KaxiEA3l1gN5UnjS/DywWx0LaXOTZYlO/lA+/Cx4tgoCjhqeDp44urTom4oWXgBDqy/l40 Vp+82Dl1Nd6u++mqqYMaQikzQyKwGf5TO0WZvuOa9t51arTqWBWSHZKGYFxyQecvgk1dOg ITJjJWuaSSlkIDm1VTkSVHgl3ZagMKLA1BmKKnv/gin+onLXUcMU/RJUFb+LCdaSLkJhXz vGD7AagmQwADo4aTOgROFO5gSSClEzkEvFPLpXsI0uZ87dJM2AT4ccsroA/YYdl/kAd6/B ntiqY4yOoUOutqFqxwhfBMlLnxcIZUY4WcK+Y5N7eARf5kl8MbDsqNIUg+raTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668191823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fW4C9L8vjP24Zd8UENKhmjeGKRa/TvkiDdryxntQu84=; b=iUK2l1AgAT0rC9GVliO/0ytYEXw5W6n7UPqgFa+wvRJXzCDJa6xBEf1txvL6FAbrMsQW1F KatlRIlmbKpCzPA0sjJLlp5VUgYA6ZVR3R1HhmNleEh12rCcYKFd8rQVjpkuLzP4yFiIHx 3BRN0SktD9Z4gXkTwpVOLtHp/ertHEeW/ztybt06GZBezXvB35yk3SW78/I1Yp5tTmyFnt SxGXW8RbJJuaVB7sp+Jt0oaZFDtejUwJf/IVsMVjGMkoG5No9GhI/vSoVLZO/S3uwS1PIO 2nDA10P2wU59YlEvUki+20YTVWcgHkcfUmY5bcOnuWEMjUxJL8Bo3LWdFYv9wQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668191823; a=rsa-sha256; cv=none; b=AvQYnzJM71nhq0liiiazdfEXOU7q75q4xaxxmu4SlImkb+EIA2ZiehFi6iX0pRvksK3yBB WjFVveFDh+/viq6LlPR+CrycHB55CjBhW663ldeYO3zEHvhJQ3bsqeT+0fQQ22f2CXsiro trv+G3Sym5VczzuqJRnpTceUoPHEh8KFO7tfYj+/MJzymqxYwIymSkWyfPTiewkYux/1xp M+aiRBQVIpIc8ANsVfXMZOPnhdPA+aWZpyipG2AN3W0iugy1ewncmIMA88WK7nWZiP4b08 FKe3PWP1IeYlJaCDFTlm2vlOHkwiJ+6Rurc62OfD6xu7t+1Wetq7dXaS9N8+Ug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N86qz3WhGzt2v; Fri, 11 Nov 2022 18:37:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2ABIb32L004420; Fri, 11 Nov 2022 18:37:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2ABIb3xB004419; Fri, 11 Nov 2022 18:37:03 GMT (envelope-from git) Date: Fri, 11 Nov 2022 18:37:03 GMT Message-Id: <202211111837.2ABIb3xB004419@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: d77e67e9d5e4 - stable/13 - msk: Don't bother reading spare stats registers. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d77e67e9d5e40910e11a89b7ff7b3570a5e0965f Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=d77e67e9d5e40910e11a89b7ff7b3570a5e0965f commit d77e67e9d5e40910e11a89b7ff7b3570a5e0965f Author: John Baldwin AuthorDate: 2022-10-05 23:45:43 +0000 Commit: John Baldwin CommitDate: 2022-11-11 18:18:54 +0000 msk: Don't bother reading spare stats registers. msk_stats_update reads stats registers named "spare" whose values are discarded. Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D36871 (cherry picked from commit aabbe26939be63615e371a91f87eeea8b177f728) --- sys/dev/msk/if_msk.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/msk/if_msk.c b/sys/dev/msk/if_msk.c index 73c6b4fa5458..729d8383e9c1 100644 --- a/sys/dev/msk/if_msk.c +++ b/sys/dev/msk/if_msk.c @@ -4358,7 +4358,6 @@ msk_stats_update(struct msk_if_softc *sc_if) MSK_READ_MIB32(sc_if->msk_port, GM_RXF_MC_OK); stats->rx_crc_errs += MSK_READ_MIB32(sc_if->msk_port, GM_RXF_FCS_ERR); - MSK_READ_MIB32(sc_if->msk_port, GM_RXF_SPARE1); stats->rx_good_octets += MSK_READ_MIB64(sc_if->msk_port, GM_RXO_OK_LO); stats->rx_bad_octets += @@ -4385,10 +4384,8 @@ msk_stats_update(struct msk_if_softc *sc_if) MSK_READ_MIB32(sc_if->msk_port, GM_RXF_LNG_ERR); stats->rx_pkts_jabbers += MSK_READ_MIB32(sc_if->msk_port, GM_RXF_JAB_PKT); - MSK_READ_MIB32(sc_if->msk_port, GM_RXF_SPARE2); stats->rx_fifo_oflows += MSK_READ_MIB32(sc_if->msk_port, GM_RXE_FIFO_OV); - MSK_READ_MIB32(sc_if->msk_port, GM_RXF_SPARE3); /* Tx stats. */ stats->tx_ucast_frames += @@ -4415,7 +4412,6 @@ msk_stats_update(struct msk_if_softc *sc_if) MSK_READ_MIB32(sc_if->msk_port, GM_TXF_1518B); stats->tx_pkts_1519_max += MSK_READ_MIB32(sc_if->msk_port, GM_TXF_MAX_SZ); - MSK_READ_MIB32(sc_if->msk_port, GM_TXF_SPARE1); stats->tx_colls += MSK_READ_MIB32(sc_if->msk_port, GM_TXF_COL); stats->tx_late_colls +=