From nobody Fri Nov 04 21:51:36 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N3vTj0hQ2z4gr5d; Fri, 4 Nov 2022 21:51:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N3vTh6w0rz3srT; Fri, 4 Nov 2022 21:51:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667598697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7m5ZFt7XXdo1jZeERM1+/sqjRqx8bo2ww0ozk8xJBQ=; b=uUVlucz65YHJPpyfPhZK4Np+8LYYwJhH4MxZBiehN4em2SbpCj1bitgYM4bgLeBZbBmljz WtXNBGKzr7XdodyLISAeyJGaEpxl3gf/RD8Vxv2k33xaACX5+Xh5FtdO6SEz37smm/qonN mch5P2w3zHlh3bw2us/JXd1aBeniIMeBW0Bbdm8g1MLFriby4kVuILF69jiQKz7Y/AhSLJ Jq4eEXMP0cfrw8oI29PTgqgbDQHlfd7JaTHevZRNqeOMO5+Gktz5v9YOHJQaeP8Uq8ZR6i SM+vdj1pTqY5zeZc+HdmHa80SShh14rTeq9wu0JVhD0wIB5bY+GPAqDNeXt62A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N3vTh5zJDzHbb; Fri, 4 Nov 2022 21:51:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2A4LpaBd044791; Fri, 4 Nov 2022 21:51:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2A4Lpa29044790; Fri, 4 Nov 2022 21:51:36 GMT (envelope-from git) Date: Fri, 4 Nov 2022 21:51:36 GMT Message-Id: <202211042151.2A4Lpa29044790@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: f5d1d22f25bd - stable/13 - nxprtc: Fix timing issue with register access. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f5d1d22f25bd8b96aba1b83aea79b598fe6d9bcb Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667598697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7m5ZFt7XXdo1jZeERM1+/sqjRqx8bo2ww0ozk8xJBQ=; b=yulEEbzNESBkEbY/nHI6mgO6fvtLhBLb7fSYBLj6uky+igI6CqL8Y7WeYHRK89JAveO6+e L75GhNXxeLbgy9r0jK22BqOYWS/BOIXtL1fLOLnuuYts42kq5FsvimiE9CX3FccslP52Hb ZqZxUIDQECjN7m0qezxt2VJIS4J/xILNg1Z5+0sUjfOj/80vQPGS6oJ0dtB2ZCWqi4SMBJ 9SJMlC9XGIrqr31u29eHu4YqWxeSnK7gU+LR+v0exmqv9BoE+gO98DZLnFUBud0brNEgvs LQ4vJly/8GcOnCN4B3jL+lIr3JqtRv8lrHsyls078dmS3N88NivP1k429Kx5dQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667598697; a=rsa-sha256; cv=none; b=ow3usTU+rGEcbAr1AY2WxjF6qjIOOtm8T9oNvW5qq5dqLelemJY7za8ENdlc0KoWh6RZf8 8KfvHzczWtZS+Nx2d4RaoA1vUv9BLS15EEIQm6aAyL6H0kDppspnh3a14Wxj4zDjBm28bb jibCZMa53F3qNytIFvUuMapsXKfHnp+h4ouABNgs1rb9n2EEe6S3EV+fbHQL+2KzUHPFYZ uXR7yjRYp8G0+JGNsF/ygljLBeTOqle+bOhA01NyfFn5PB0iYOgQUVqWXek+NZ3JVaNmnR Iv34wqluclkxVGbJqWvjhaZrhNN2Vd3euaeZhLjGo6gZWdYBTrbbcn7fSniAog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=f5d1d22f25bd8b96aba1b83aea79b598fe6d9bcb commit f5d1d22f25bd8b96aba1b83aea79b598fe6d9bcb Author: Tetsuya Uemura AuthorDate: 2022-11-04 21:49:52 +0000 Commit: Warner Losh CommitDate: 2022-11-04 21:50:05 +0000 nxprtc: Fix timing issue with register access. My Adafruit PCF8523 RTC on either RPi2B or RPi3B+ failed to work around 80 ~ 90 % of boot-ups, by printing the following log lines. nxprtc0: at addr 0xd0 on iicbus0 nxprtc0: cannot set up timer Warning: no time-of-day clock registered, system time will not be set accurately This is due to pcf8523_start_timer(sc) returned non-zero in nxprtc_start() due to a register read failure of PCF8523_R_TMR_A_FREQ or PCF8523_R_TMR_CLKOUT or a failure to program a new value. The pause_sbt("nxpbat") sleep was too short and caused the register access failures. PR: 266093 (cherry picked from commit e2386f18eca2f6f75f7c5c2d49d603e3d2674509) --- sys/dev/iicbus/nxprtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/iicbus/nxprtc.c b/sys/dev/iicbus/nxprtc.c index 0e5162fcd395..2827ebc1a29e 100644 --- a/sys/dev/iicbus/nxprtc.c +++ b/sys/dev/iicbus/nxprtc.c @@ -418,7 +418,7 @@ pcf8523_battery_check(struct nxprtc_softc *sc) device_printf(sc->dev, "cannot write CS3 reg\n"); return (err); } - pause_sbt("nxpbat", mstosbt(10), 0, 0); + pause_sbt("nxpbat", mstosbt(100), 0, 0); if ((err = read_reg(sc, PCF8523_R_CS3, &cs3)) != 0) { device_printf(sc->dev, "cannot read CS3 reg\n"); return (err);