git: b65803ba5773 - main - cam iosched: default to no read bias in dynamic ioscheduling
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 01 May 2022 17:27:38 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=b65803ba5773d5fb37fa2403105db199569a5811
commit b65803ba5773d5fb37fa2403105db199569a5811
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-05-01 17:18:23 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-05-01 17:27:34 +0000
cam iosched: default to no read bias in dynamic ioscheduling
When we're doing dynamic I/O scheduling, don't default to a read bias of
100. Default it to 0 so turning on dynamic scheduling only does
scheduling tweaks that are requested. The other limiters are off by
default, and need no further adjustment.
Sponsored by: Netflix
---
sys/cam/cam_iosched.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c
index 7ddfabbe5125..21a948b69c69 100644
--- a/sys/cam/cam_iosched.c
+++ b/sys/cam/cam_iosched.c
@@ -1149,8 +1149,8 @@ cam_iosched_init(struct cam_iosched_softc **iscp, struct cam_periph *periph)
#ifdef CAM_IOSCHED_DYNAMIC
if (do_dynamic_iosched) {
bioq_init(&(*iscp)->write_queue);
- (*iscp)->read_bias = 100;
- (*iscp)->current_read_bias = 100;
+ (*iscp)->read_bias = 0;
+ (*iscp)->current_read_bias = 0;
(*iscp)->quanta = min(hz, 200);
cam_iosched_iop_stats_init(*iscp, &(*iscp)->read_stats);
cam_iosched_iop_stats_init(*iscp, &(*iscp)->write_stats);
@@ -1234,7 +1234,7 @@ void cam_iosched_sysctl_init(struct cam_iosched_softc *isc,
SYSCTL_ADD_INT(ctx, n,
OID_AUTO, "read_bias", CTLFLAG_RW,
- &isc->read_bias, 100,
+ &isc->read_bias, 0,
"How biased towards read should we be independent of limits");
SYSCTL_ADD_PROC(ctx, n,