From nobody Mon Mar 28 11:37:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 30B731A3F9D8; Mon, 28 Mar 2022 11:37:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KRrKd0pdtz3vhn; Mon, 28 Mar 2022 11:37:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648467477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JpVYUXMbQOTrmdp4J6zRidy0GMIuQKnY8T2F//yXgIY=; b=RKtyKsDXYd7wBapILSg60WQneKneoV6XwwcuIDqpWniZQKAh2XBcGKcwCIKbprwOxTwDnT q2PuPG/LeN91AevEQEXEwFQEkEr6qloh/yltt3NC46TIYHEvxqXj9SrQ9LxqQQdP1opPPp cjtsaiscz3hGZN74EPAXyO150XGcG67wZRln61FmfHuvrHxkVklxOK55KPkEShdaZcR+kL GzAYqnYICC66hfElWlk2JvRXJ0t1kh2hZa44kC8wdTohaYr57YPDUAYcRamt4Shmuxewt1 eNdA8qz5Gwqulem/ubx0lN2t2hCGivMWVcUS6uExxT22gGjxcisAbv+ATb70+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EB5E01095; Mon, 28 Mar 2022 11:37:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22SBbumi076792; Mon, 28 Mar 2022 11:37:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22SBbuxJ076791; Mon, 28 Mar 2022 11:37:56 GMT (envelope-from git) Date: Mon, 28 Mar 2022 11:37:56 GMT Message-Id: <202203281137.22SBbuxJ076791@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: bb77a828a477 - stable/12 - pf: remove spurious zeroing from pf_ioctl_addrule List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: bb77a828a4774edd510da4eb39db57eaefade680 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648467477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JpVYUXMbQOTrmdp4J6zRidy0GMIuQKnY8T2F//yXgIY=; b=phmklsNYvPWA9TiTmlYZDYvSGu2YjfqOnBnZZBMI5THPv0w/ZJc6jkmfhfKHp7ppr57VUu eFi/nBC4YQ6T7zFtGJEhmFGJPYLWVz4rST9PMhY6QbdXENH4bWqe9iXIy4fNbwQqqENk9v Wxtc4Y1XsAv60NB1UwQ2tqjrYNkS/c3NBAJvSWBFfj8glOmAdBHxPx87kqmQdPqu2HQe+v nr+pBoKJrV6IfjV8srDWfULfQ9QMKKhvPZPoo68/b/vDySWHyP1AHwpCjWctgEXUSi7p0f 6l6MCEKYGgIGM9esm78RWqq5Bgh2P5S8Y9ZuEim3KAm1liVPxWy1eHczAZ9vtQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648467477; a=rsa-sha256; cv=none; b=uyozSSKweXe6uU/Rd7OZqdMlDYOCDeFrhgfCQzeJ+Ex/6mH0Q75mko34t7bBmUQfOnnI3h qzNgZmGByth9VSErfaEsvu6On3UzpIy8q7IlBfX+hwXRNuaqHoYj7oV/H50YZYF7dvT/4Y FCd7brPKgqz+w2kGaHRk1cadCn0eKJAg39izmWr9HDFsGAVH+BWuAVpWipYprK/Jcv8YJN n/p1SEVwn5LRv/ibN/gld8HwISr2RtUswF74oZB+DHZrc1AOfGiVO3jaCDTpyg9+3ho1Hy 57cgeOe56KzftEhZtO1Imhw4+8rWMHNhU1GZOk6hOX3VsWFHH5hujWUX2krkcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=bb77a828a4774edd510da4eb39db57eaefade680 commit bb77a828a4774edd510da4eb39db57eaefade680 Author: Mateusz Guzik AuthorDate: 2022-02-25 16:18:13 +0000 Commit: Mateusz Guzik CommitDate: 2022-03-28 11:37:31 +0000 pf: remove spurious zeroing from pf_ioctl_addrule Newly allocated counters are guaranteed to be 0. This removes 5 IPIs for each loaded rule. Reviewed by: kp Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 15ada7514954150e6c07fd6a31ceb686ece76943) --- sys/netpfil/pf/pf_ioctl.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index 5636ea93e99d..ac99ac6d80bc 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -2103,11 +2103,6 @@ pf_ioctl_addrule(struct pf_krule *rule, uint32_t ticket, } rule->rpool.cur = TAILQ_FIRST(&rule->rpool.list); - pf_counter_u64_zero(&rule->evaluations); - for (int i = 0; i < 2; i++) { - pf_counter_u64_zero(&rule->packets[i]); - pf_counter_u64_zero(&rule->bytes[i]); - } TAILQ_INSERT_TAIL(ruleset->rules[rs_num].inactive.ptr, rule, entries); ruleset->rules[rs_num].inactive.rcount++;