From nobody Wed Mar 23 16:01:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EFD491A23DC9 for ; Wed, 23 Mar 2022 16:01:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KNtPh6G6Cz53XF for ; Wed, 23 Mar 2022 16:01:12 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f52.google.com with SMTP id u16so2784548wru.4 for ; Wed, 23 Mar 2022 09:01:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=j9EJKfgq3Ti34v2ebiP0hCsYMXMaiDKE7pQ1xOXnUTs=; b=fM7vIRrwsRPC0dQhF9jflBnp5ckuROe0M0FyZRnOsOactWlyaLEyt1lXZz5tHZNVLk HrmD8W5+NsX5D80fKAEkjGqpgqv8OTBs4w3vDHBe6QqS2zW3Fxf1HZjaSzmNkKK7xkUS BHRAHEsNIesE84v7ck1fDGxOsjxm6jXqk5SAuueYsqv1A7kyvpXNGLLZwdGmGRI/WZXG q1NZ/Vp3pyl1tvP/L8vA2S4bjNZVr2Fkm6KWmrlOydtnihewXancQ4tcHR8rvTjNOvF5 XSIlNkxGeiQdB9OiyPKbfERqZ+eNzVfWi8sayKS6g/skfuwKIz71dUASw4HHUVdBBIvG qSpg== X-Gm-Message-State: AOAM531sp0ryeMKLxTKh0bsHiDpkDt6jcM1/UrcSQVwV7EksYvaIVbG1 TaULohX1Mw/StnawgiBhofkkEQ== X-Google-Smtp-Source: ABdhPJw75r+Sy5htPJLJA5DYAEg4DZp3Quh83CUy1d16JpaOW7piIAK/Idf4ysahWCUuR9FAl0qGkA== X-Received: by 2002:a5d:6546:0:b0:203:f121:298c with SMTP id z6-20020a5d6546000000b00203f121298cmr438948wrv.427.1648051265806; Wed, 23 Mar 2022 09:01:05 -0700 (PDT) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id v124-20020a1cac82000000b0037c3d08e0e7sm4286136wme.29.2022.03.23.09.01.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Mar 2022 09:01:05 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 0e5c72c3cc54 - main - bsdinstall time: Replace dialog with bsddialog From: Jessica Clarke In-Reply-To: <202203231557.22NFv7Ro095912@gitrepo.freebsd.org> Date: Wed, 23 Mar 2022 16:01:04 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <535DB523-150D-4663-934E-174AA639FB54@freebsd.org> References: <202203231557.22NFv7Ro095912@gitrepo.freebsd.org> To: "Alfonso S. Siciliano" X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4KNtPh6G6Cz53XF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.45 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.95)[-0.954]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-0.99)[-0.993]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.52:from]; MLMMJ_DEST(0.00)[dev-commits-src-all]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.52:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 23 Mar 2022, at 15:57, Alfonso S. Siciliano = wrote: >=20 > The branch main has been updated by asiciliano: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D0e5c72c3cc5471dfa8cb42b018d623b1= ef15dbe8 >=20 > commit 0e5c72c3cc5471dfa8cb42b018d623b1ef15dbe8 > Author: Alfonso S. Siciliano > AuthorDate: 2022-03-23 15:52:39 +0000 > Commit: Alfonso S. Siciliano > CommitDate: 2022-03-23 15:56:37 +0000 >=20 > bsdinstall time: Replace dialog with bsddialog >=20 > Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog = utility, > 'dialog --calendar' is replaced by 'bsddialog --datebox' with same > features but different User Interface. Different in what way?.. > Approved by: bapt (mentor) > Differential Revision: https://reviews.freebsd.org/D34583 > --- > usr.sbin/bsdinstall/scripts/time | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/usr.sbin/bsdinstall/scripts/time = b/usr.sbin/bsdinstall/scripts/time > index cccd5999a035..5db4b48f7531 100755 > --- a/usr.sbin/bsdinstall/scripts/time > +++ b/usr.sbin/bsdinstall/scripts/time > @@ -36,23 +36,23 @@ export TZ >=20 > # Set date > exec 3>&1 > -DATE=3D$(dialog --backtitle 'FreeBSD Installer' \ > - --title 'Time & Date' \ > +DATE=3D$(bsddialog --backtitle 'FreeBSD Installer' \ > + --title ' Date ' \ Why do these both have spaces around them? Jess > --ok-label 'Set Date' \ > --cancel-label 'Skip' \ > - --defaultno \ > + --default-no \ > --date-format '%Y%m%d%H%M.%S' \ > - --calendar '' 0 40 \ > + --datebox '' 0 40 \ > 2>&1 1>&3) && date $DATE > exec 3>&- >=20 > # Set time > exec 3>&1 > -TIME=3D$(dialog --backtitle 'FreeBSD Installer' \ > - --title 'Time & Date' \ > +TIME=3D$(bsddialog --backtitle 'FreeBSD Installer' \ > + --title ' Time ' \ > --ok-label 'Set Time' \ > --cancel-label 'Skip' \ > - --defaultno \ > + --default-no \ > --time-format '%H%M.%S' \ > --timebox '' 0 40 \ > 2>&1 1>&3) && date $TIME