From nobody Sat Mar 19 15:11:46 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 61A871A280AB; Sat, 19 Mar 2022 15:11:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLPVV2LPJz3hJT; Sat, 19 Mar 2022 15:11:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647702706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ssGmIxgJyqMNSdyeq1rVQKyshgJ2yXGtEYdQmJ5pcuw=; b=LIHcc7itsb6+HpDKZm4IjMkrYJPvY9ChWVMAWRtPoAiNSrl0iCK8rsuFUvYVoA164Rvf/j i4OJYYpNmPdschpaWFbrSOjIzAA+zxDVc1TSlvyFMeUmgoHKkByHWKoFYFsd42lch2hbS4 VB+fZR92zIjvLOW02IHNPFDmh4Ann7Z9KHq/D8vPam/guID8Fpsw81hiPwxCWRtHoChqFO s5WzE25ZUvJhBjhB/FPj0YS8d4GuQhK+URzj8mZtJJSoq7YkV+CwLfOf1HVHCCpfybwdr0 D16CeFdXWX/n5lwVi/xbZSUPbFf3EX9xMdRt9NLcolnFogvaYuENCfaW9/66fQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 314961515B; Sat, 19 Mar 2022 15:11:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22JFBk9f089362; Sat, 19 Mar 2022 15:11:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22JFBk9k089361; Sat, 19 Mar 2022 15:11:46 GMT (envelope-from git) Date: Sat, 19 Mar 2022 15:11:46 GMT Message-Id: <202203191511.22JFBk9k089361@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 6ff3e8a3165e - main - cache: add a comment about a realpath bug List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6ff3e8a3165ea580c184cfad8ebd7cffc17b0271 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647702706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ssGmIxgJyqMNSdyeq1rVQKyshgJ2yXGtEYdQmJ5pcuw=; b=pz64VUvsI4kARIsFw1ybgdATtR2L7NTqNALkPtlDHx/diUuYscvbTYRghOnLprBW49XlUk dALYiQOjAM3Y6pjLyounHzcj85xodz8l2jso5d7sOSV863l2DdHens7u/oIm+DAQxcakrM yx3Eky0NhYuxptGbDYo7FTAmJmL4Ca6ZHbVXxc2GpN/rNzBPKJSnej6rWOx/fxVISH6C9E F2gBc/obnhvIfZft5kjfrQr2T4htzjz1tl7CvRMJF0qluoraOdEhbJuXc51ObVOzwup+NF xsyuMClRqmREaqcwveqhyd73AvA0x7+xDNbav8fwF6ie2g0xTrH6ebrvUIMISQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647702706; a=rsa-sha256; cv=none; b=j7UUUsxT2GmJQjAdLPRoyhJxiU+aFBquMCZ8cpTa189YUFVpbgTBFse+jq8zLeFuKh0iQG jwBFKv3UReQfZll/Gu/TpomijOnUsLGgH1Iq27QLSky9X+sctZHR/0g/TTfbe+VVcRygI8 wM+AAEu7EWOPR26MmvXXz3V+zgCGhiJR5hDD3hg/81nJOBIi/l2XFQqQgL5aW3oejnRnJE lNbDkWS8el+Vh0dUEGRgIA8pbW+ttqQ9qvnI2X0EssyDi3Q60fVuhpRbvpCYFbf46da7U4 lkf+topd14rA1YRtL/xIyTiL6j53swOFtu4h92wvT1aE1IyM9AHy+B5WfcoGig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=6ff3e8a3165ea580c184cfad8ebd7cffc17b0271 commit 6ff3e8a3165ea580c184cfad8ebd7cffc17b0271 Author: Mateusz Guzik AuthorDate: 2022-03-19 15:11:25 +0000 Commit: Mateusz Guzik CommitDate: 2022-03-19 15:11:25 +0000 cache: add a comment about a realpath bug --- sys/kern/vfs_cache.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 13c84791583e..147d3075dfac 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -3119,6 +3119,17 @@ vn_getcwd(char *buf, char **retbuf, size_t *buflen) return (error); } +/* + * Canonicalize a path by walking it forward and back. + * + * BUGS: + * - Nothing guarantees the integrity of the entire chain. Consider the case + * where the path "foo/bar/baz/qux" is passed, but "bar" is moved out of + * "foo" into "quux" during the backwards walk. The result will be + * "quux/bar/baz/qux", which could not have been obtained by an incremental + * walk in userspace. Moreover, the path we return is inaccessible if the + * calling thread lacks permission to traverse "quux". + */ static int kern___realpathat(struct thread *td, int fd, const char *path, char *buf, size_t size, int flags, enum uio_seg pathseg)