From nobody Thu Mar 10 17:21:09 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3086A19F1C3F; Thu, 10 Mar 2022 17:21:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDwny0vPmz4T6N; Thu, 10 Mar 2022 17:21:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646932870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sgbw1y69Z5LxM8lOw6ldXhOPbgG+YK9R/u2oKgkkc7k=; b=lXNOYtNosTHLhfa9yS8KrOVG3azZaSGi+/4znfZRQTHCQO/OobNmXKwF98MwpzaqQ0ONdp 95z1MlJEfrElz+NF7gl//Y79Xsk8m/IGarjYO+Hs2Fe7Dy2/DZjfwOoxxzpOI0IfDu2VCp 7KW4hPf9AFajcgKO2CDAt3HYe4Z4r50ABvY382y6klTbl26wB9/oTD+730lzhHkCJ5wQEZ cxkwiU2wsMTicAPlJ4iaAP+iCYlU9P9SAwrSRkLO6jzzluYz4Xs2RYJDKnBNRO6H2h7TRY vvinPtr7vp1TxPgYv2YODCzeniu/Cgf3WN8y6Nwc7Cl0IEVllONe8xqmEXRQJA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 001E0EC0; Thu, 10 Mar 2022 17:21:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22AHL9kq011413; Thu, 10 Mar 2022 17:21:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22AHL9Qj011412; Thu, 10 Mar 2022 17:21:09 GMT (envelope-from git) Date: Thu, 10 Mar 2022 17:21:09 GMT Message-Id: <202203101721.22AHL9Qj011412@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 15ada7514954 - main - pf: remove spurious zeroing from pf_ioctl_addrule List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 15ada7514954150e6c07fd6a31ceb686ece76943 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646932870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sgbw1y69Z5LxM8lOw6ldXhOPbgG+YK9R/u2oKgkkc7k=; b=pfd4ds9zgEjU4aZlR8HQx94FLhgKddZKKLue6OtJxEoYWwHGMCFDKYunN3G46TNa6afko8 /QyCjFWfxxW4ZOsStYx64/5J7mtwYHADJ5eLMR97M219k/0GIng4IWcY3jrpvC7qROsm9y ZqEghoiNuztVwkGasnPfxQM49LaW5Au5vU9s1QfJBrVbbUUVaN304Fn7aDwAVdJnu48fNH 3oyYcNeIZpMLd/SSuPCpuAz11s9bYbp+J0cQNjQSjLd1fWQz1nd31KJwQXdBM17ZSWeOOE 6bXLkwuigDNIMaQJVJ0dcTDTf3ipqsz21N3A9JzfQXYg0UD+O/LW+TfNR2eU/A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646932870; a=rsa-sha256; cv=none; b=ycGBhSWUBNyfXvQMWRT4jAqgXit7OON6uJTK3LvEGa3z2tuQ8UVG3cyOj+oVA6SuCK0dJ3 s37syzSSL2ENcdrRg/KcZ1qc+h0MGo2KwpsSF014MEu8JdDvCPJm6hmho91bgybztFKJiT 0CkDZ6OFj6wqIZ4JEs4uOsREecC1bM8w+77M4+N10meVVx5jcJU0+bTAPZ/+8vhxAboPmY 25U8N9/JPxinBQOUasFYRsgC+joE6qDIM8SUJk9Y69g7D+WdsA/RimRfIC/zXuyEQRNjXu 801V1RW9/TZ7E8XLEvlgqVu3o/j1z5NJpDmfnrEP8gLURigvPf37juoqzdLntg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=15ada7514954150e6c07fd6a31ceb686ece76943 commit 15ada7514954150e6c07fd6a31ceb686ece76943 Author: Mateusz Guzik AuthorDate: 2022-02-25 16:18:13 +0000 Commit: Mateusz Guzik CommitDate: 2022-03-10 17:20:41 +0000 pf: remove spurious zeroing from pf_ioctl_addrule Newly allocated counters are guaranteed to be 0. This removes 5 IPIs for each loaded rule. Reviewed by: kp Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_ioctl.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index 908e22184172..ef7092c0ed1b 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -2184,11 +2184,6 @@ pf_ioctl_addrule(struct pf_krule *rule, uint32_t ticket, } rule->rpool.cur = TAILQ_FIRST(&rule->rpool.list); - pf_counter_u64_zero(&rule->evaluations); - for (int i = 0; i < 2; i++) { - pf_counter_u64_zero(&rule->packets[i]); - pf_counter_u64_zero(&rule->bytes[i]); - } TAILQ_INSERT_TAIL(ruleset->rules[rs_num].inactive.ptr, rule, entries); ruleset->rules[rs_num].inactive.rcount++;