From nobody Thu Mar 10 11:29:35 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 62B0A19FB22A; Thu, 10 Mar 2022 11:29:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDn0H2Hs3z4thb; Thu, 10 Mar 2022 11:29:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646911775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iy6NMJCuh6mV82LTxzQWeJCDehk7wbyodusfBa4ULRQ=; b=vwLU8wvM1rjn2wroqXxZ6X2mGz4kPFFganyGH4EvO+sUwxC/Yr2G+CEoFIjlpjOlHWOIQt HnM0oak5jVKvHsQAyaS5RSTp/wByfGB7lvHNmtZBFim+uBIi9NaYBCjCWH5kwTEu9Cw5sO Thqnl690nX32TdKvDdvfy7b4yF7mZsxuDlbi6UfkmuVQTQ31bFUYCAtLh/NMFVoO/NE7oM 3/WPcGFO8sFPeDRhLicCepF5+Ep7cH/0TqA9q/lCnhoi8liUwMMhkm4DeiVXicLIDQ8Gy8 HCtcEMRS3q3qc+GMo/H9b7AItI+SWljfyvDXJwmNlzqhwx6J0aX3cW85I9CD/A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2E7D624214; Thu, 10 Mar 2022 11:29:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22ABTZ4g031926; Thu, 10 Mar 2022 11:29:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22ABTZEx031925; Thu, 10 Mar 2022 11:29:35 GMT (envelope-from git) Date: Thu, 10 Mar 2022 11:29:35 GMT Message-Id: <202203101129.22ABTZEx031925@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Marcin Wojtas Subject: git: 206dc82bc3fc - main - bus_if: Add a default implementation of get_property List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mw X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 206dc82bc3fc5e1d90200e189ce5f2240dfec874 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646911775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iy6NMJCuh6mV82LTxzQWeJCDehk7wbyodusfBa4ULRQ=; b=Xw898APkno8gi9RlJlAxjc0ToMSkPCEn8+5E92hGz51yFKL1qzHT5J/C62pCCObdFPstju ARYAJujab6xpjAm3xzDvFxOL/Q3sF1XhzvaoGgKq6S1bZHNjgtFgR1gp9dDeS+UEG0seT3 ttgvspcoJYoa0oKIH4HeBSB1s/FLVIg7XgaT9RsEd8eFYLC2xtnSI3aw8iRM5/K1I/DI72 X23xsBQEnVUQSa+hmNPVK1RfPp6/SLHVh5GITJmTHKmtujDxLJh/aHoRg+/3tfYJDnq+mw oiRMZ9IqmtoxAK7jOZkQkWxXeS3DuzMCJdFeriNGcpolTXRmd1theBO6YqP1YQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646911775; a=rsa-sha256; cv=none; b=vcPjh+m0Tg7UE7NfPkmgBuTqA1yxkfvMeOXav+b4xBBUmIhwgfsLs8rnFgMqTtcVn7MEy4 0yzxJR881uROmYudFzBVmWskt7r/3Ist+Qb4suiBhj9l/fbieMN6QcGoZ1BXQ5tixtzrUq 9+WugSwkx6rn/5zIRdIIzktQhOPhCtYLWf6zqaU4m0mkkR/zVinFlaX3PG5Ts0OW07v5SW eVb42VqqxhiIRwYJm7OqC0Oq0CzvsfowsoDd4qTpg2F8Nlb2Ss/b1IpoLrvmyFPrkEcgXl o5mHiWAzNky3uSS6lKCRWH/E4gyVsEnh9BOiylKKm556ACS3Vk/Iy2JIDtQTSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mw: URL: https://cgit.FreeBSD.org/src/commit/?id=206dc82bc3fc5e1d90200e189ce5f2240dfec874 commit 206dc82bc3fc5e1d90200e189ce5f2240dfec874 Author: Kornel Duleba AuthorDate: 2022-01-25 10:10:55 +0000 Commit: Marcin Wojtas CommitDate: 2022-03-10 11:11:32 +0000 bus_if: Add a default implementation of get_property There are multiple buses that pretend to be ofw compatible, e.g ofw_pci, mii_fdt. We now need to provide an implementation of BUS_GET_PROPERTY for every one of them. Instead of modifying them one by one it's better to just provide a default implementation that simply traverses up the device tree. Remove the now unneeded BUS_GET_PROPERTY implementation in mii_fdt. Reviewed by: andrew, bz Obtained from: Semihalf MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D34031 --- sys/dev/mii/mii_fdt.c | 15 --------------- sys/kern/bus_if.m | 8 +------- sys/kern/subr_bus.c | 17 +++++++++++++++++ sys/sys/bus.h | 3 +++ 4 files changed, 21 insertions(+), 22 deletions(-) diff --git a/sys/dev/mii/mii_fdt.c b/sys/dev/mii/mii_fdt.c index 387b02f69504..9cf3fd2fab37 100644 --- a/sys/dev/mii/mii_fdt.c +++ b/sys/dev/mii/mii_fdt.c @@ -326,20 +326,6 @@ miibus_fdt_get_devinfo(device_t bus, device_t child) return (&ma->obd); } -static ssize_t -miibus_fdt_get_property(device_t bus, device_t child, const char *propname, - void *buf, size_t size) -{ - struct mii_attach_args *ma; - - ma = device_get_ivars(child); - - if (ma->obd.obd_node == 0) - return (-1); - - return (OF_getencprop(ma->obd.obd_node, propname, buf, size)); -} - static device_method_t miibus_fdt_methods[] = { DEVMETHOD(device_probe, miibus_fdt_probe), DEVMETHOD(device_attach, miibus_fdt_attach), @@ -362,7 +348,6 @@ static device_method_t miibus_fdt_methods[] = { DEVMETHOD(bus_get_resource, bus_generic_rl_get_resource), DEVMETHOD(bus_set_resource, bus_generic_rl_set_resource), DEVMETHOD(bus_get_resource_list, miibus_fdt_get_resource_list), - DEVMETHOD(bus_get_property, miibus_fdt_get_property), DEVMETHOD_END }; diff --git a/sys/kern/bus_if.m b/sys/kern/bus_if.m index ef0f5e9eb65a..cf6470c220ef 100644 --- a/sys/kern/bus_if.m +++ b/sys/kern/bus_if.m @@ -77,12 +77,6 @@ CODE { return (0); } - static ssize_t - null_get_property(device_t dev, device_t child, const char *propname, - void *propvalue, size_t size) - { - return (-1); - } }; /** @@ -944,7 +938,7 @@ METHOD ssize_t get_property { const char *_propname; void *_propvalue; size_t _size; -} DEFAULT null_get_property; +} DEFAULT bus_generic_get_property; /** * @brief Gets a child's full path to the device diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c index 5e6cfa162f4c..8a05c28c96b1 100644 --- a/sys/kern/subr_bus.c +++ b/sys/kern/subr_bus.c @@ -4125,6 +4125,23 @@ bus_generic_write_ivar(device_t dev, device_t child, int index, return (ENOENT); } +/** + * @brief Helper function for implementing BUS_GET_PROPERTY(). + * + * This simply calls the BUS_GET_PROPERTY of the parent of dev, + * until a non-default implementation is found. + */ +ssize_t +bus_generic_get_property(device_t dev, device_t child, const char *propname, + void *propvalue, size_t size) +{ + if (device_get_parent(dev) != NULL) + return (BUS_GET_PROPERTY(device_get_parent(dev), child, + propname, propvalue, size)); + + return (-1); +} + /** * @brief Stub function for implementing BUS_GET_RESOURCE_LIST(). * diff --git a/sys/sys/bus.h b/sys/sys/bus.h index d31eb31a362a..0b4f85a7fd0d 100644 --- a/sys/sys/bus.h +++ b/sys/sys/bus.h @@ -444,6 +444,9 @@ bus_dma_tag_t bus_space_tag_t bus_generic_get_bus_tag(device_t dev, device_t child); int bus_generic_get_domain(device_t dev, device_t child, int *domain); +ssize_t bus_generic_get_property(device_t dev, device_t child, + const char *propname, void *propvalue, + size_t size); struct resource_list * bus_generic_get_resource_list(device_t, device_t); int bus_generic_map_resource(device_t dev, device_t child, int type,