From nobody Fri Mar 04 18:15:29 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5197419FBD24 for ; Fri, 4 Mar 2022 18:15:32 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K9GHR3Y2Jz4dDY for ; Fri, 4 Mar 2022 18:15:31 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf2b.google.com with SMTP id p8so4240920qvg.12 for ; Fri, 04 Mar 2022 10:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1gSPuEq9tWP4ifpfTOEWwz3P39TeGe6rZMm6E3I80CI=; b=h5XMce+nebUtB4gfQ/s8TEzbkiLDqvfrqmV1y2hrgXZ6EgaaXEhp+ih+Vk+fsRs/Y2 yBGftyAM0yk1Gsr61ao1AjKiAwgkS2lbnZNfARj5E0FS3Iz/dIrdJZ5NYTzZxmpq3K34 96R7We1DH2vupJgK3paaOQero3/UzLHH+6OzgPRMcu+tS3M470ppcOctSpf3PlMDVCjT dxFtvBqnvC4KiHj/nFgTcbryd/Gg59ARCE49jEcpZda56PoBZyVR8uJdjH60sQ6X+wkv 7lvgJ2Ts2Ycn/vCDVXufNHP9Dp6oluT4c1ik8dsk8itlbTWxuyTyEUajTAzPIv8r5f0y 0QIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1gSPuEq9tWP4ifpfTOEWwz3P39TeGe6rZMm6E3I80CI=; b=IVnRDkqtUY9lzWjEzO5/DLq4KOWzjh2+tnZTldwDvOh4T5t3F1E8XKxO6X0OSmuIh6 Gz+nL8cFqI+czqf0AkJnmm9TR1qKo/kH4PrcgSbpuituthVNqSve9q2BiKAcLh75EXkJ YJIO+5yS3Lx4qta/MjQ4F/8zFAwCobW/4DtCMP3V6XpbVUIXVkjRT7ErYfr8YPmFuCBy +9prnlxZA5bDaqmf4QyLjiHNaokyNEHfeZMB9JNNUcB/Mz6wZC1bvjQhFfE2yO9Gop47 LlmGvY4aQEZhu/vr1HN6VpRWz8AqPadzwAxxNBOjgxsT9nAMjUy3HiUFuxZz/95/oKWf ynbg== X-Gm-Message-State: AOAM5330del+l3ex2n9y+YVb5/VxKEG+XvBDiZMzr3V2CtG+hPOGWTcI PsTFhJVviRphLwyPoomS9LBgmA== X-Google-Smtp-Source: ABdhPJxoUVp86Abk96wCauQFq+36+ErbWrbPZ6uOWHZtbviWjQ7xnBc6QYiuAdknHzwbi46YqWDoYw== X-Received: by 2002:a05:6214:da3:b0:433:3217:6483 with SMTP id h3-20020a0562140da300b0043332176483mr16896831qvh.130.1646417730936; Fri, 04 Mar 2022 10:15:30 -0800 (PST) Received: from mutt-hbsd (pool-100-16-224-136.bltmmd.fios.verizon.net. [100.16.224.136]) by smtp.gmail.com with ESMTPSA id o1-20020a37be01000000b00648eadafd9bsm2718342qkf.24.2022.03.04.10.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 10:15:30 -0800 (PST) Date: Fri, 4 Mar 2022 13:15:29 -0500 From: Shawn Webb To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 84369dd52369 - main - x86: Probe the TSC frequency earlier Message-ID: <20220304181529.isvkyyx3qwcbt6v7@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202203011439.221EdtpY038505@gitrepo.freebsd.org> <20220304142447.bmo7r6syd6gsunnt@mutt-hbsd> <20220304175226.avi2r57dvjfeyr7w@mutt-hbsd> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r3y2smx2fgxhxjo5" Content-Disposition: inline In-Reply-To: <20220304175226.avi2r57dvjfeyr7w@mutt-hbsd> X-Rspamd-Queue-Id: 4K9GHR3Y2Jz4dDY X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=h5XMce+n; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::f2b as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2b:from]; MLMMJ_DEST(0.00)[dev-commits-src-all]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[100.16.224.136:received] X-ThisMailContainsUnwantedMimeParts: N --r3y2smx2fgxhxjo5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 04, 2022 at 12:52:26PM -0500, Shawn Webb wrote: > On Fri, Mar 04, 2022 at 10:13:54AM -0500, Mark Johnston wrote: > > On Fri, Mar 04, 2022 at 09:24:47AM -0500, Shawn Webb wrote: > > > On Tue, Mar 01, 2022 at 02:39:55PM +0000, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > >=20 > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D84369dd52369cbae2897= 0dca20a53d3de1719907 > > > >=20 > > > > commit 84369dd52369cbae28970dca20a53d3de1719907 > > > > Author: Mark Johnston > > > > AuthorDate: 2022-03-01 14:39:35 +0000 > > > > Commit: Mark Johnston > > > > CommitDate: 2022-03-01 14:39:35 +0000 > > > >=20 > > > > x86: Probe the TSC frequency earlier > > > > =20 > > > > This lets us use the TSC to implement early DELAY, limiting the= use of > > > > the sometimes-unreliable 8254 PIT. > > > > =20 > > > > PR: 262155 > > > > Reviewed by: emaste > > > > Tested by: emaste, mike tancsa , Stefan H= egnauer > > > > MFC after: 1 month > > > > Sponsored by: The FreeBSD Foundation > > > > Differential Revision: https://reviews.freebsd.org/D34367 > > > > --- > > > > sys/amd64/amd64/machdep.c | 14 +++++- > > > > sys/i386/i386/machdep.c | 11 ++++- > > > > sys/x86/include/clock.h | 3 +- > > > > sys/x86/isa/clock.c | 4 +- > > > > sys/x86/x86/tsc.c | 123 +++++++++++++++++++++++++---------= ------------ > > > > 5 files changed, 94 insertions(+), 61 deletions(-) > > >=20 > > > Hey Mark, > > >=20 > > > Something about this commit breaks booting in Hyper-V. Reverting this > > > particular commit makes Hyper-V happy again. > >=20 > > The patch below might be sufficient. I'll test it in Azure but it'll > > take me some time. > >=20 > > diff --git a/sys/x86/x86/delay.c b/sys/x86/x86/delay.c > > index c767250954da..95b994b15f81 100644 > > --- a/sys/x86/x86/delay.c > > +++ b/sys/x86/x86/delay.c > > @@ -89,7 +89,7 @@ delay_tc(int n) > > return (1); > > } > > tc =3D timecounter; > > - if (tc->tc_quality <=3D 0) > > + if (tc =3D=3D NULL || tc->tc_quality <=3D 0) > > return (0); > > func =3D tc->tc_get_timecount; > > mask =3D tc->tc_counter_mask; >=20 > Great! I'll give this patch a try and report back. The proposed patch did not result in successful boot. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --r3y2smx2fgxhxjo5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmIiVz8ACgkQ/y5nonf4 4foLohAAiBo3ClnnnF3v20LZ5sOtjGsSDELLTIhbScaj2kTfBXpZ+lFyK91WZUkl hTkcFH+J608AKblZMsk8pS1e0hN7rvyq/tRHKI445WEzf9gH11uKS+oyzPUE/qCL arsx4/T69sjNef7Dz/bs4cwOTKhctqnDPZ98RREzdsCFN89IFu2s5T2wSHvqyAGE Z3Mw7k9lKFI1OzOAMHFLCd8NTEpjdfLlSHzKr1SR+BLB1tddLsJ3tPhceFsYTPsv +FZOJQQGQh4IWJOD3J06FONk5WWlFryzAtU6HouO4uQVJCvL3lbMMyYY66AbOAgL xTUIKSeoWP4jMnerWNTIzYbNB8wkN8xAa5vtqi1BIXQS4YtmlVQPX8xPH4ysGT/3 PIeRzS+BWxNCGX1kcvXb/vlxMERelDgVdAb+jnly/a580RtwIlhmC9J2z2UC6Yhh 0nC0VyHfZEykTNJgCuhIWVyuO7386UcHTI8mjsFbxquKC7ImBHCUFXYM170GJt5d TvdCUKI+mrdXHBrlMkjlwXVNkrst0wCYF1WVjJxuXSSzn+SdET1v8kFftUA5sLr9 qKG6Re6Vff0ZDut8bnzifudch9AxBMqcA9J4UC20oo+VGnFmPMjNG+GhY46Q1ujk B9BII44wgHn8RS5uCF7A7x5LOnRqCyktXOgFpw2Q7gRB1Yppa40= =q52t -----END PGP SIGNATURE----- --r3y2smx2fgxhxjo5--