From nobody Fri Jun 24 01:23:09 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7E48D872D83; Fri, 24 Jun 2022 01:23:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LTfWg2wNDz3kVB; Fri, 24 Jun 2022 01:23:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656033791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dPzsr4FpEOI3bJHVFvuL2oql7EPlad7DvyH3Vz+BCU8=; b=e69yhKFuL37y7zBiTO3bEGdy2fmPGmib4vs6r2VkWcWO+WTqcno48PRLMJVqi4vYSHVnuN 2tlLTkINBekPLY1hEv5pzCCj0PU9IOt5SdesCj+GtCZJSQM+D3tTejMEizKEvnPUI7K44p eZ7mgxJJnb4cVHFoGF7hsyziV8ccm/yRfvDeIVFCndkxgkS3hzFh70cfz9v6URxPxz1oOV jDaLdh4rNxTjY57kSeIqiG/3QvyY70LzukyJ7OMij4OUHXAI0IBVdxOmo8LKxAIty44XXX SAqJYhBlbXi+Eq4zZXVPSTK29OHkWt5vDP0vdV6HndP5mixpZV+JoDYemVcsbQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id C602F5309; Fri, 24 Jun 2022 01:23:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <79422862-b886-09c0-8af9-d5136a7e6f7f@FreeBSD.org> Date: Thu, 23 Jun 2022 18:23:09 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: git: 2f3a961487c9 - main - Add RELRO build knob, default to enabled Content-Language: en-US To: Ed Maste , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206221620.25MGKCHU098065@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202206221620.25MGKCHU098065@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656033791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dPzsr4FpEOI3bJHVFvuL2oql7EPlad7DvyH3Vz+BCU8=; b=VsofelrZobr0oorY1aDya5ITtlEr+xCcRE517vn1f/ndxLUJq2HMsead8qftZKy/EjQViK mVg/Jnr+YRKQebqMuV94wTcI+wDbjm4oBPgS2b6vB6hBfPOqO0ziccXdYAbOqVhIgGeLsb sZ0Fc7diUdiBdDSFnOzi5WCeq2Nb6KEYvoixL4Pss1eEVkJImnEgnRg90T0lD33O7mKQSX CIwNVkNGHPLGdUwx0VlPHnU9tPkrqme2IX2Kzx0wKVZlTTW/f+CKfxQvzWslxEbwT2fctm 50LafpBxJpGC8UtBfpuX2Y3UyNBDFVyaKDBIYkZ4yOZuKDPMvm/vDkDNiMnCyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656033791; a=rsa-sha256; cv=none; b=UeoqbD+HzGBHbAotokNoR6VVyZA6IV3PAbgzAe7+MzPGaV0fZqBBN4VGjrikyI9sNyxUZ8 CM5Cy6Xww9xxGu3bcwMu6wd/DK9z2RpMTp1f2hdoTsa1k1eiTKPNw57e36agQK0/RWbq37 4gjI2uLhH6y0y3enb/fip0BLNrWuW+lwG3u5pIeAU/fnSU5rU7zEInQKRb7HwYHUAw8UDN Nl+y7mW4DtIhpSoNrtkZBNlGRJpXTempGvPnvLjX6fofSE/QgR5yh66IjTibGqd104oxhF M3Un1oIRy4u0K2KwrO57fav5AOP1b1aEgthWToJZznGWLoh/vIfGLbUs+2O0BA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 6/22/22 9:20 AM, Ed Maste wrote: > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2f3a961487c97dc879f07bb97bc62d7bd70b3f8d > > commit 2f3a961487c97dc879f07bb97bc62d7bd70b3f8d > Author: Ed Maste > AuthorDate: 2022-06-22 12:58:04 +0000 > Commit: Ed Maste > CommitDate: 2022-06-22 16:18:41 +0000 > > Add RELRO build knob, default to enabled > > Note that lld enables relro by default, so that we already had either > partial or full RELRO, depending on the state of the BIND_NOW knob. > > Add a RELRO knob so that the option can be disabled if desired, and so > that builds using the GNU toolchain are equivalent to those using the > standard Clang/LLVM toolchain. > > Reviewed by: markj > MFC after: 3 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D35545 This broke the cross-build on macOS (the GitHub jobs are failing on main now). Looks like macOS's linker doesn't like '-z relro'. 996 -------------------------------------------------------------- 997 >>> stage 1.2: bootstrap tools 998 -------------------------------------------------------------- 999 ===> lib/clang/libllvmminimal (obj,all,install) 1000 ===> usr.bin/fortune/strfile (obj,all,install) 1001 ===> usr.bin/dtc (obj,all,install) 1002 warning: unknown warning option '-Werror=unused-but-set-variable'; did you mean '-Werror=unused-const-variable'? [-Wunknown-warning-option] 1003 warning: unknown warning option '-Werror=unused-but-set-variable'; did you mean '-Werror=unused-const-variable'? [-Wunknown-warning-option] 1004 warning: unknown warning option '-Werror=unused-but-set-variable'; did you mean '-Werror=unused-const-variable'? [-Wunknown-warning-option] 1005 1 warning generated. 1006 ld: unknown option: -zrelro 1007 clang: error: linker command failed with exit code 1 (use -v to see invocation) 1008 --- strfile --- 1009 *** [strfile] Error code 1 -- John Baldwin