From nobody Wed Jun 15 21:54:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 212E6839E6F; Wed, 15 Jun 2022 21:54:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LNfH30Pv5z4fw1; Wed, 15 Jun 2022 21:54:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655330095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bp5Fj4Z5cDYTrTcnE6GcBBK/jxHQ4NmSAROSNN59V68=; b=XjKzsWAtfoCmsAWvXiJvy8aUtq9swD7y9or1g3kc++qyYIu3N4wRC6B5jilIIDJy5r6mgz Galk4BK98x2PfjfF5rW7nfrEmCpkHyVghX8tt3tmtiF2lFWQ12PCspXK5Szc32bF+rJb6M b2ZmA3DbxAwXXBGlJFHc7eAiZWaUlFrzoFWu/1TjB8l2hZhz30l0zXspwUukkiAo4tYkzT ssxLQroOS1z0nf46BmPc9v+T/aHYpRuXWfEZJgPHyoIXqXkUzE8n4rF2CfICAwFAcCLMKW nnFpNqzlkqfa5LQOXR6Oe4c947NmSuZVwr6aJ8vGbKV7Zs6XHyHLi6FLu5AVEQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 5BA6A2AE25; Wed, 15 Jun 2022 21:54:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <81e113f5-b390-b0d9-d8c5-c4be120e64a6@FreeBSD.org> Date: Wed, 15 Jun 2022 14:54:53 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part Content-Language: en-US To: "Bjoern A. Zeeb" Cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> <0e2172f8-21c1-afb1-9d2b-03ef14a4edf5@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655330095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bp5Fj4Z5cDYTrTcnE6GcBBK/jxHQ4NmSAROSNN59V68=; b=nkum/6LOY0D7r1EbYlPFsKp75Igc4gJryG3FEwGPQtN558d+xFSCKN6aE6RY/CenDWWBxh 5/DUFmFqaYnwNA2JrDKRPn+lYrshlfd0z4iQ93wNQe+/fb4g8C3XxZNS+IoL71nvYM83EC gEi3mv/aHv9ykrmv4woz8z5dWbk9vwdJun1i8+jkv63dL5Le95R0Imf3DYVitPvSB2uaRF leuXT23dVezKYVkvWbTWhalEm6zoskT2av4k+r2rqEpaQFbpV6q7zm8v3EcmvTaK+CxlY2 yuwa/Cum5swNz/02EqBgZJ3UAQKGhDmPYeF/yOAogygDU/1b7uI3tYPYjr5uHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655330095; a=rsa-sha256; cv=none; b=InJUcWVduSGIySABY+CFM/NdBOyX5jvMJ/LPq+k68LW7vzM82AB6CRoid1uRF2jCbzCkNP M3cPQYaJd3Wfj728mkqZo0EA9CqUOMjFryidnM/Yo7rxvjAUKOt6KiPNmH24WtkC2pEFSa dP9mYT7aeRZb/XfTc8yVFdayJ1jQ0SBroKFldpji1v1TdLlNfrqDPFSam9dkztY+cX4TYH CNSPw5Q7sjszMTlP85swXVX3kOIp2P8wt3v2EI0r96+O37QRxu83r0dAkUwWxZ4hWeu2ea j7ROsLajF3I3Tw9MJCSsaLA7ij9HLfY96ntg7lcEwJtVeTMC0KJNLeHKCccfag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 6/14/22 9:50 AM, Bjoern A. Zeeb wrote: > On Tue, 14 Jun 2022, John Baldwin wrote: > >>> Why do I need to load 1M file for PCI on a machine w/o PCI? >> >> Even many SoC boards have PCI, and anything approaching desktop class >> will have PCI, so lack of PCI is quite specious. That said, historically >> per-bus attachment code was indeed much smaller. OTOH, you can also >> selectively include files in the .ko at build-time, e.g. based on >> whether or not the base kernel included 'device pci' by checking for >> DEV_PCI in KERN_OPTS, something like: >> >> .if ${KERN_OPTS:MDEV_PCI} >> SRCS+= if_rtw88_pci.c >> .endif >> >> This more closely matches what happens in the kernel where you would have >> the sys/conf/files line be 'if_rtw88_pci.c optional rtw88 pci' > > I like this idea and it indeed more closely matches the intentions and > seems to be a better idea. I'll revert the change and adjust it to this > if that's acceptable? I would be fine with this, but Warner might have his own vote for this. I do think that this particular use case is a bit different due to the relatively large size of the PCI bus attachment for this driver. -- John Baldwin