From nobody Mon Jun 13 14:28:59 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7848883E323; Mon, 13 Jun 2022 14:29:12 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMDTg1vp9z3vlL; Mon, 13 Jun 2022 14:29:10 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [178.232.223.95]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 1509526035E; Mon, 13 Jun 2022 16:29:03 +0200 (CEST) Message-ID: Date: Mon, 13 Jun 2022 16:28:59 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: git: 9fd0d9b16e93 - main - ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP kernel configurations. Content-Language: en-US To: John Baldwin , "Bjoern A. Zeeb" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206111932.25BJW6w6040018@gitrepo.freebsd.org> <5a3bd99e-bd7a-7b89-7d11-a821b3d19fac@FreeBSD.org> From: Hans Petter Selasky In-Reply-To: <5a3bd99e-bd7a-7b89-7d11-a821b3d19fac@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4LMDTg1vp9z3vlL X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-3.27 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-0.997]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.98)[-0.980]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[178.232.223.95:received] X-ThisMailContainsUnwantedMimeParts: N On 6/13/22 16:22, John Baldwin wrote: > On 6/12/22 4:43 AM, Hans Petter Selasky wrote: >> On 6/11/22 22:04, Bjoern A. Zeeb wrote: >>> On Sat, 11 Jun 2022, Hans Petter Selasky wrote: >>> >>>> The branch main has been updated by hselasky: >>>> >>>> URL: >>>> https://cgit.FreeBSD.org/src/commit/?id=9fd0d9b16e93ff2a3bd375a98763dca0150dcee0 >>>> >>>> >>>> >>>> commit 9fd0d9b16e93ff2a3bd375a98763dca0150dcee0 >>>> Author:     Hans Petter Selasky >>>> AuthorDate: 2022-06-11 19:29:42 +0000 >>>> Commit:     Hans Petter Selasky >>>> CommitDate: 2022-06-11 19:31:28 +0000 >>>> >>>>     ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP >>>> kernel configurations. >>>> >>>>     Kernel TLS depends on INET or INET6 being enabled. >>> >>> That is only a short-term solution hiding the actual problem and will >>> now propably never be fixed again like these device drivers which were >>> on that list ofr ages... >> >> +1 >> >> There is a plan to replace config at some point. I believe this is a >> limitation of sys/conf/files, that it doesn't provide a good way to >> handle conflicts. There are many ifdef KERN_TLS, so just skipping one >> file for building won't help. >> >> https://hackmd.io/w1Tf8mmVQVuZok7-LNEhgw > > What we often do though is just add in #ifdef's to make a given file a > kind of stub.  In theory KTLS could work over UNIX domain sockets if > someone wanted to do the work, and that would just entail adding the > right #ifdef INET, etc. in this file. > Is this something you plan to work on, or something you want done? Feel free to revert my bandaid once a better solution is in place. --HPS