From nobody Fri Jun 10 22:14:01 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A16EE83A5B2; Fri, 10 Jun 2022 22:14:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LKZxP46dvz3kH0; Fri, 10 Jun 2022 22:14:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654899241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+z3/wgOrfiZeOqOoSU+1Ssis82OsKFWSEtq//o5fIz0=; b=bB4apNyq6iQppzMB1AaLo7toPEPODCUxMc8woLmiAclUP4dl7XTTN8RpoW+NnjkjLYZe2r kKMRA5iu04xjHgu6EBeC0Fru97liR/pkp6N1yH9dn8w2uRQG3vaze+CWL6CKaNqkQK0Ni7 juqXlFe+uQdr0SAVlSpf9iZ+MuwoWwjxXzYNCyPAQ0pcvHrw/E/4B1YMdWdRhE9wtZM13C p27QvrQEzCZWC/Co7Z0qvTUg690J1IbXB3F7p10/j5xNmrep/s3OUeHzBwAkg6rBSnNfPi 4zbEY/wniwbeRkCkRcKwg5gKs98wmP1keOGhIPmeZ7FfAFDvmf2VEepRO4CTzA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6D05F20D2D; Fri, 10 Jun 2022 22:14:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25AME1NF013475; Fri, 10 Jun 2022 22:14:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25AME1IC013474; Fri, 10 Jun 2022 22:14:01 GMT (envelope-from git) Date: Fri, 10 Jun 2022 22:14:01 GMT Message-Id: <202206102214.25AME1IC013474@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 70efcaffa180 - stable/13 - nfscl: Add a diagnostic printf() for a "should never happen" case List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 70efcaffa180d5b00c7b8eaca7a271693933a38c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654899241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+z3/wgOrfiZeOqOoSU+1Ssis82OsKFWSEtq//o5fIz0=; b=jATXQxmYWgWKtbJl/4RIhOlmhSfujwcKO/sgeLF/9bpIT5qPZYKdKMZ60tyij0lVMBJKyK omZBfOPQVBUGIMycdg17VX8pKnyTzgMvoTCnC1tn3+3bf8zhGDqYltD9SjJHGdZMWY0nfT xwdfHPz0GlWAgIajiCBaZopmIF61G3/1JrTHZ1v4xCn9UeHlDwjlN1AUOwg48+ODWOh3rz 8mRB5lS3gkZkVISthpPj4gqg+azcq/4x7oBtjmtpD/gWXWQbhZwn0YIp6RjHXb0Za0tLPS BDhD25lDFezvQ4eccSXa8so99BCMu9sO+3YxPqC28DKBepFSn4jyZqyPK2H8wA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654899241; a=rsa-sha256; cv=none; b=yObMMG501gE3GXDCQ+U4MhwbSe0D9deJNTAR7NOXoL6hWzRjMS6KMNPXg0hg/iCfYzfRsQ 7Bq4FghKUf0JQyoxeDwtGSxVbOzfwXX6wp7UCnh6wpk5hbXG6SGB9GlUfzjSyRFOjhDIwQ l7PHN7f/MezhJgx/u/FUcfBEGlZcH8/wz8gukF6uP3yinprmzkzvud85vDfYCaZGzUg5es zsVZPKiuQaYjfreMbNSj68rkwn0EhfRSVh1+2thhf1VsNFAhCXaAeGdY1mcgVvNybAXAJE m6wUb+l+p0WoAVxBAjXx697sz3Ex1HQs6LxR9Pfyp2pDlS+E93LW87KukrLcMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=70efcaffa180d5b00c7b8eaca7a271693933a38c commit 70efcaffa180d5b00c7b8eaca7a271693933a38c Author: Rick Macklem AuthorDate: 2022-05-27 21:32:46 +0000 Commit: Rick Macklem CommitDate: 2022-06-10 22:12:50 +0000 nfscl: Add a diagnostic printf() for a "should never happen" case When a NFSv4.1/4.2 session to the NFS server (not a pNFS DS) is replaced, the old session should always be marked defunct by nfsess_defunct being set non-zero. However, the hang reported by the PR suggests that this might be the case. This patch adds a printf() to indicate this has somehow happened. PR: 260011 (cherry picked from commit a7bb120f8b8735bc4c417b3c8fc2308c3d2964aa) --- sys/fs/nfsclient/nfs_clrpcops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/fs/nfsclient/nfs_clrpcops.c b/sys/fs/nfsclient/nfs_clrpcops.c index dc0b92db97bc..eac6c777324a 100644 --- a/sys/fs/nfsclient/nfs_clrpcops.c +++ b/sys/fs/nfsclient/nfs_clrpcops.c @@ -1060,8 +1060,12 @@ nfsrpc_setclient(struct nfsmount *nmp, struct nfsclclient *clp, int reclaim, * in-progress RPCs. */ tsep = NULL; - if (TAILQ_FIRST(&nmp->nm_sess) != NULL) + if (TAILQ_FIRST(&nmp->nm_sess) != NULL) { tsep = NFSMNT_MDSSESSION(nmp); + if (tsep->nfsess_defunct == 0) + printf("nfsrpc_setclient: " + "nfsess_defunct not set\n"); + } TAILQ_INSERT_HEAD(&nmp->nm_sess, dsp, nfsclds_list); /*