From nobody Thu Jun 09 21:02:01 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4A9198508E8; Thu, 9 Jun 2022 21:02:20 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LJxP73T8nz3pK5; Thu, 9 Jun 2022 21:02:19 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: by mail-ua1-x931.google.com with SMTP id q1so8413308uao.1; Thu, 09 Jun 2022 14:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vbHYI+dBbXhCP+GjhP9IHek7HjnlD+7VL1S6f5zEcnw=; b=iFDbBwAZmHj1eoZaXhm6eC0SqacgR5zI/OsZ18NFnhaeMKZyQzx58tU0PjEvgpUE6a JJM6kby+tcY+t+IwcSZVr16HhESU7pVL1zAVDPi8dz1UUwOlYPqnz4Y4i51uJQymcZP+ UymPSIXYty3596YIGQcjaTg/M+vEhaS4YDFBHix4fw9xBKPTpGCl5R+FuNmhviYxvm8a ctdlgNTe3Cg8kuTevYNybHZ4zRSAFlYPDNFBKBhJoWjORyGmmUKNRYgMpiJOQ1WxjY6L GX+B4YdEF3kYy9/amufi/IXCwZuhqCHe5e3uPh/hrwJ09xVNF9YMU9PmJmIHXDaQJuXB LcnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vbHYI+dBbXhCP+GjhP9IHek7HjnlD+7VL1S6f5zEcnw=; b=7JT4YnIH2ueV+dmaHp53rnGaSzOBlcoF2+ZbhugBIkwNJsqmXVK721iEW5pV1D9sRr P6CkDvU+3O9rOiHmpLeuGaBJTmzmUR2W9oU7Q1pIH3b8xkLtbp8uFosDoQGn9j7zB65B XCUrmQtTwnutYkzs2aX1jyYJuA3/Dh3wiVVWuA0rB0GLmUTs2+n41g20BE7Ovfc188k9 COgve59B8wWzhvhro8mUZwUgnCYLWsQTFY998jqJU9I/WLxv89VVixDJJMGHUdLTp8sj 2YnPT26R0+GTKBY+wo3eLNsCCVHXei0OHOcujPWX1okv074uPwIgzRhCY8e7RRYkWnKo 3dHA== X-Gm-Message-State: AOAM533rN7kyhv0LXRu+OkX2t4RgM45dMh6nm1yypgQoCxn8k1HvZ4ZI NwoK7p2nQhIK0BZIuKuWMjfTUvBtw0YOejoCtIn7oeIe8u6p2w== X-Google-Smtp-Source: ABdhPJxRQIvqKb9dqnRGIIVAEYo/mQXmR0JFXS9UIbVCDnfFQcr9EPmboR5twV//Dq3/1/XXKQmQ72oGkFx9rQHoVwE= X-Received: by 2002:ab0:7290:0:b0:34b:71ac:96c2 with SMTP id w16-20020ab07290000000b0034b71ac96c2mr40012364uao.102.1654808532780; Thu, 09 Jun 2022 14:02:12 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <201706072121.v57LLEH2001634@repo.freebsd.org> In-Reply-To: <201706072121.v57LLEH2001634@repo.freebsd.org> From: Sergey Kandaurov Date: Fri, 10 Jun 2022 01:02:01 +0400 Message-ID: Subject: Re: svn commit: r319663 - head/lib/libc/sys To: Jilles Tjoelker Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c48a5505e10a2227" X-Rspamd-Queue-Id: 4LJxP73T8nz3pK5 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=iFDbBwAZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of pluknet@gmail.com designates 2607:f8b0:4864:20::931 as permitted sender) smtp.mailfrom=pluknet@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FREEFALL_USER(0.00)[pluknet]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::931:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-ThisMailContainsUnwantedMimeParts: N --000000000000c48a5505e10a2227 Content-Type: text/plain; charset="UTF-8" On Thu, 8 Jun 2017 at 01:21, Jilles Tjoelker wrote: > Author: jilles > Date: Wed Jun 7 21:21:14 2017 > New Revision: 319663 > URL: https://svnweb.freebsd.org/changeset/base/319663 > > Log: > libc: Remove futimens() and utimensat() compat stubs. > > The futimens() and utimensat() compat stubs allowed using these > functions on > kernels that did not have the system calls yet (10.2, old 11-current). > > Also remove the documentation of the [ENOTSUP] error that could occur > with > an old kernel. > > A -DNO_CLEAN build may fail because the depend files refer to the deleted > files. > > Deleted: > head/lib/libc/sys/futimens.c > head/lib/libc/sys/utimensat.c > Modified: > head/lib/libc/sys/Makefile.inc > head/lib/libc/sys/utimensat.2 > > Modified: head/lib/libc/sys/Makefile.inc > > ============================================================================== > --- head/lib/libc/sys/Makefile.inc Wed Jun 7 21:18:28 2017 > (r319662) > +++ head/lib/libc/sys/Makefile.inc Wed Jun 7 21:21:14 2017 > (r319663) > @@ -37,10 +37,6 @@ SRCS+= \ > > SRCS+= getdents.c lstat.c mknod.c stat.c > > -SRCS+= futimens.c utimensat.c > -NOASM+= futimens.o utimensat.o > -PSEUDO+= _futimens.o _utimensat.o > - > SRCS+= pipe.c > > INTERPOSED = \ > > Modified: head/lib/libc/sys/utimensat.2 > > ============================================================================== > --- head/lib/libc/sys/utimensat.2 Wed Jun 7 21:18:28 2017 > (r319662) > +++ head/lib/libc/sys/utimensat.2 Wed Jun 7 21:21:14 2017 > (r319663) > @@ -31,7 +31,7 @@ > .\" @(#)utimes.2 8.1 (Berkeley) 6/4/93 > .\" $FreeBSD$ > .\" > -.Dd January 17, 2016 > +.Dd June 7, 2017 > .Dt UTIMENSAT 2 > .Os > .Sh NAME > @@ -267,10 +267,6 @@ argument is not an absolute path and > is neither > .Dv AT_FDCWD > nor a file descriptor associated with a directory. > -.It Bq Er ENOTSUP > -The running kernel does not support this system call and > -.Dv AT_SYMLINK_NOFOLLOW > -is used with a path relative to a file descriptor. > .El > .Sh SEE ALSO > .Xr chflags 2 , > I believe the compatibility part can be removed too: diff --git a/lib/libc/sys/utimensat.2 b/lib/libc/sys/utimensat.2 index 2af452898c9..53602d68ba8 100644 --- a/lib/libc/sys/utimensat.2 +++ b/lib/libc/sys/utimensat.2 @@ -169,18 +169,6 @@ operate on the current working directory. .El .Sh RETURN VALUES .Rv -std -.Sh COMPATIBILITY -If the running kernel does not support this system call, -a wrapper emulates it using -.Xr fstatat 2 , -.Xr futimesat 2 -and -.Xr lutimes 2 . -As a result, timestamps will be rounded down to the nearest microsecond, -.Dv UTIME_OMIT -is not atomic and -.Dv AT_SYMLINK_NOFOLLOW -is not available with a path relative to a file descriptor. .Sh ERRORS These system calls will fail if: .Bl -tag -width Er --000000000000c48a5505e10a2227 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, 8 Jun 2017 at 01:21, Jilles Tjo= elker <jilles@fr= eebsd.org> wrote:
Author: jilles
Date: Wed Jun=C2=A0 7 21:21:14 2017
New Revision: 319663
URL: https://svnweb.freebsd.org/changeset/base/31966= 3

Log:
=C2=A0 libc: Remove futimens() and utimensat() compat stubs.

=C2=A0 The futimens() and utimensat() compat stubs allowed using these func= tions on
=C2=A0 kernels that did not have the system calls yet (10.2, old 11-current= ).

=C2=A0 Also remove the documentation of the [ENOTSUP] error that could occu= r with
=C2=A0 an old kernel.

=C2=A0 A -DNO_CLEAN build may fail because the depend files refer to the de= leted
=C2=A0 files.

Deleted:
=C2=A0 head/lib/libc/sys/futimens.c
=C2=A0 head/lib/libc/sys/utimensat.c
Modified:
=C2=A0 head/lib/libc/sys/Makefile.inc
=C2=A0 head/lib/libc/sys/utimensat.2

Modified: head/lib/libc/sys/Makefile.inc
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
--- head/lib/libc/sys/Makefile.inc=C2=A0 =C2=A0 =C2=A0 Wed Jun=C2=A0 7 21:1= 8:28 2017=C2=A0 =C2=A0 =C2=A0 =C2=A0 (r319662)
+++ head/lib/libc/sys/Makefile.inc=C2=A0 =C2=A0 =C2=A0 Wed Jun=C2=A0 7 21:2= 1:14 2017=C2=A0 =C2=A0 =C2=A0 =C2=A0 (r319663)
@@ -37,10 +37,6 @@ SRCS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0\

=C2=A0SRCS+=3D getdents.c lstat.c mknod.c stat.c

-SRCS+=3D futimens.c utimensat.c
-NOASM+=3D futimens.o utimensat.o
-PSEUDO+=3D _futimens.o _utimensat.o
-
=C2=A0SRCS+=3D pipe.c

=C2=A0INTERPOSED =3D \

Modified: head/lib/libc/sys/utimensat.2
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
--- head/lib/libc/sys/utimensat.2=C2=A0 =C2=A0 =C2=A0 =C2=A0Wed Jun=C2=A0 7= 21:18:28 2017=C2=A0 =C2=A0 =C2=A0 =C2=A0 (r319662)
+++ head/lib/libc/sys/utimensat.2=C2=A0 =C2=A0 =C2=A0 =C2=A0Wed Jun=C2=A0 7= 21:21:14 2017=C2=A0 =C2=A0 =C2=A0 =C2=A0 (r319663)
@@ -31,7 +31,7 @@
=C2=A0.\"=C2=A0 =C2=A0 =C2=A0@(#)utimes.2=C2=A0 =C2=A08.1 (Berkeley) 6= /4/93
=C2=A0.\" $FreeBSD$
=C2=A0.\"
-.Dd January 17, 2016
+.Dd June 7, 2017
=C2=A0.Dt UTIMENSAT 2
=C2=A0.Os
=C2=A0.Sh NAME
@@ -267,10 +267,6 @@ argument is not an absolute path and
=C2=A0is neither
=C2=A0.Dv AT_FDCWD
=C2=A0nor a file descriptor associated with a directory.
-.It Bq Er ENOTSUP
-The running kernel does not support this system call and
-.Dv AT_SYMLINK_NOFOLLOW
-is used with a path relative to a file descriptor.
=C2=A0.El
=C2=A0.Sh SEE ALSO
=C2=A0.Xr chflags 2 ,

I believe the compati= bility part can be removed too:

diff --git a/lib/libc/sys/utimensat.= 2 b/lib/libc/sys/utimensat.2
index 2af452898c9..53602d68ba8 100644
--= - a/lib/libc/sys/utimensat.2
+++ b/lib/libc/sys/utimensat.2
@@ -169,1= 8 +169,6 @@ operate on the current working directory.
=C2=A0.El
=C2= =A0.Sh RETURN VALUES
=C2=A0.Rv -std
-.Sh COMPATIBILITY
-If the run= ning kernel does not support this system call,
-a wrapper emulates it us= ing
-.Xr fstatat 2 ,
-.Xr futimesat 2
-and
-.Xr lutimes 2 .
= -As a result, timestamps will be rounded down to the nearest microsecond,-.Dv UTIME_OMIT
-is not atomic and
-.Dv AT_SYMLINK_NOFOLLOW
-is = not available with a path relative to a file descriptor.
=C2=A0.Sh ERROR= S
=C2=A0These system calls will fail if:
=C2=A0.Bl -tag -width Er
=
--000000000000c48a5505e10a2227--