git: 3d5fed51ed46 - stable/13 - ena: Fix invalid KASSERT test in netmap code
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 26 Jul 2022 19:31:00 UTC
The branch stable/13 has been updated by mw:
URL: https://cgit.FreeBSD.org/src/commit/?id=3d5fed51ed46fc718b32b48de8e98dd507c2b637
commit 3d5fed51ed46fc718b32b48de8e98dd507c2b637
Author: Michal Krawczyk <mk@semihalf.com>
AuthorDate: 2022-06-10 09:18:13 +0000
Commit: Marcin Wojtas <mw@FreeBSD.org>
CommitDate: 2022-07-26 19:30:16 +0000
ena: Fix invalid KASSERT test in netmap code
The KASSERT was originally added to ensure that the netmap Rx ring is
not NULL, however, it was checking for the opposite.
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
(cherry picked from commit 79770fdad6c18d968cc122c4294820931cc542e0)
---
sys/dev/ena/ena_netmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/dev/ena/ena_netmap.c b/sys/dev/ena/ena_netmap.c
index 6a780440efc9..228db0cb31ab 100644
--- a/sys/dev/ena/ena_netmap.c
+++ b/sys/dev/ena/ena_netmap.c
@@ -206,7 +206,7 @@ ena_netmap_free_rx_slot(struct ena_adapter *adapter, struct ena_ring *rx_ring,
BUS_DMASYNC_POSTREAD);
netmap_unload_map(na, adapter->rx_buf_tag, rx_info->map);
- KASSERT(kring->ring == NULL, ("Netmap Rx ring is NULL\n"));
+ KASSERT(kring->ring != NULL, ("Netmap Rx ring is NULL\n"));
slot = &kring->ring->slot[nm_i];