git: 5d747111151d - stable/13 - ena: Use device_set_desc in probe
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 26 Jul 2022 19:30:56 UTC
The branch stable/13 has been updated by mw:
URL: https://cgit.FreeBSD.org/src/commit/?id=5d747111151d88e7b1275616390bb84005277dc3
commit 5d747111151d88e7b1275616390bb84005277dc3
Author: Dawid Gorecki <dgr@semihalf.com>
AuthorDate: 2022-06-10 09:18:10 +0000
Commit: Marcin Wojtas <mw@FreeBSD.org>
CommitDate: 2022-07-26 19:30:15 +0000
ena: Use device_set_desc in probe
During probe the driver created a temporary buffer to which the value of
DEVICE_DESC constant was printed. This buffer was then copied to the
device structure using device_set_desc_copy. Since the value of this
string is exactly the same for every device using the ENA driver, using
sprintf is unnecessary, and device_set_desc can be used instead.
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
(cherry picked from commit 755e60ca046390bdcfc097b6a8f1a032d47a7b65)
---
sys/dev/ena/ena.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c
index 6a3956ddd181..dc8acb80c5e6 100644
--- a/sys/dev/ena/ena.c
+++ b/sys/dev/ena/ena.c
@@ -296,7 +296,6 @@ static int
ena_probe(device_t dev)
{
ena_vendor_info_t *ent;
- char adapter_name[60];
uint16_t pci_vendor_id = 0;
uint16_t pci_device_id = 0;
@@ -310,8 +309,7 @@ ena_probe(device_t dev)
ena_log_raw(DBG, "vendor=%x device=%x\n",
pci_vendor_id, pci_device_id);
- sprintf(adapter_name, DEVICE_DESC);
- device_set_desc_copy(dev, adapter_name);
+ device_set_desc(dev, DEVICE_DESC);
return (BUS_PROBE_DEFAULT);
}