git: 274af2948a31 - stable/13 - ena: Extend debug prints for invalid req_id resets
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 26 Jul 2022 19:30:50 UTC
The branch stable/13 has been updated by mw:
URL: https://cgit.FreeBSD.org/src/commit/?id=274af2948a31cc7564447b13a26f1f41ce6f7e06
commit 274af2948a31cc7564447b13a26f1f41ce6f7e06
Author: Dawid Gorecki <dgr@semihalf.com>
AuthorDate: 2022-06-10 09:18:07 +0000
Commit: Marcin Wojtas <mw@FreeBSD.org>
CommitDate: 2022-07-26 19:30:14 +0000
ena: Extend debug prints for invalid req_id resets
Print information about qid if req_id is invalid. Add information about
qid and req_id if mbuf is invalid.
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
(cherry picked from commit a9c39b031fe89a6414174e3db82da6548d7fff0f)
---
sys/dev/ena/ena_datapath.c | 7 +++++--
sys/dev/ena/ena_netmap.c | 3 ++-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/sys/dev/ena/ena_datapath.c b/sys/dev/ena/ena_datapath.c
index 8d4621947e03..6c18a4f5c1f9 100644
--- a/sys/dev/ena/ena_datapath.c
+++ b/sys/dev/ena/ena_datapath.c
@@ -212,7 +212,8 @@ ena_get_tx_req_id(struct ena_ring *tx_ring, struct ena_com_io_cq *io_cq,
return (EAGAIN);
if (unlikely(rc != 0)) {
- ena_log(adapter->pdev, ERR, "Invalid req_id: %hu\n", *req_id);
+ ena_log(adapter->pdev, ERR, "Invalid req_id %hu in qid %hu\n",
+ *req_id, tx_ring->qid);
counter_u64_add(tx_ring->tx_stats.bad_req_id, 1);
goto err;
}
@@ -220,7 +221,9 @@ ena_get_tx_req_id(struct ena_ring *tx_ring, struct ena_com_io_cq *io_cq,
if (tx_ring->tx_buffer_info[*req_id].mbuf != NULL)
return (0);
- ena_log(adapter->pdev, ERR, "tx_info doesn't have valid mbuf\n");
+ ena_log(adapter->pdev, ERR,
+ "tx_info doesn't have valid mbuf. qid %hu req_id %hu\n",
+ tx_ring->qid, *req_id);
err:
ena_trigger_reset(adapter, ENA_REGS_RESET_INV_TX_REQ_ID);
diff --git a/sys/dev/ena/ena_netmap.c b/sys/dev/ena/ena_netmap.c
index e9511b033fd3..476926da373d 100644
--- a/sys/dev/ena/ena_netmap.c
+++ b/sys/dev/ena/ena_netmap.c
@@ -884,7 +884,8 @@ validate_tx_req_id(struct ena_ring *tx_ring, uint16_t req_id)
if (likely(req_id < tx_ring->ring_size))
return (0);
- ena_log_nm(adapter->pdev, WARN, "Invalid req_id: %hu\n", req_id);
+ ena_log_nm(adapter->pdev, WARN, "Invalid req_id %hu in qid %hu\n",
+ req_id, tx_ring->qid);
counter_u64_add(tx_ring->tx_stats.bad_req_id, 1);
ena_trigger_reset(adapter, ENA_REGS_RESET_INV_TX_REQ_ID);