git: 9806e82a2392 - main - Adjust function definitions in kern_cons.c to avoid clang 15 warnings
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 26 Jul 2022 18:00:35 UTC
The branch main has been updated by dim:
URL: https://cgit.FreeBSD.org/src/commit/?id=9806e82a23924f32dc5976bc8687fbbe293a140b
commit 9806e82a23924f32dc5976bc8687fbbe293a140b
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-26 14:03:35 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-26 17:59:56 +0000
Adjust function definitions in kern_cons.c to avoid clang 15 warnings
With clang 15, the following -Werror warnings are produced:
sys/kern/kern_cons.c:201:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
cninit_finish()
^
void
sys/kern/kern_cons.c:376:7: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
cngrab()
^
void
sys/kern/kern_cons.c:389:9: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
cnungrab()
^
void
sys/kern/kern_cons.c:402:9: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
cnresume()
^
void
This is because cninit_finish(), cngrab(), cnungrab(), and cnresume()
are declared with (void) argument lists, but defined with empty argument
lists. Make the definitions match the declarations.
MFC after: 3 days
---
sys/kern/kern_cons.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sys/kern/kern_cons.c b/sys/kern/kern_cons.c
index 06adbcc69348..7c63b8e4ed9c 100644
--- a/sys/kern/kern_cons.c
+++ b/sys/kern/kern_cons.c
@@ -198,7 +198,7 @@ cninit(void)
}
void
-cninit_finish()
+cninit_finish(void)
{
console_pausing = false;
}
@@ -373,7 +373,7 @@ SYSCTL_PROC(_kern, OID_AUTO, console,
"Console device control");
void
-cngrab()
+cngrab(void)
{
struct cn_device *cnd;
struct consdev *cn;
@@ -386,7 +386,7 @@ cngrab()
}
void
-cnungrab()
+cnungrab(void)
{
struct cn_device *cnd;
struct consdev *cn;
@@ -399,7 +399,7 @@ cnungrab()
}
void
-cnresume()
+cnresume(void)
{
struct cn_device *cnd;
struct consdev *cn;