git: 766f3c8032a9 - main - Adjust function definitions in if_pfsync.c to avoid clang 15 warnings
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 25 Jul 2022 19:51:09 UTC
The branch main has been updated by dim:
URL: https://cgit.FreeBSD.org/src/commit/?id=766f3c8032a95f344823bea70bb7f794f9939d33
commit 766f3c8032a95f344823bea70bb7f794f9939d33
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-25 18:53:32 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-25 18:53:53 +0000
Adjust function definitions in if_pfsync.c to avoid clang 15 warnings
With clang 15, the following -Werror warnings are produced:
sys/netpfil/pf/if_pfsync.c:2439:21: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
pfsync_pointers_init()
^
void
sys/netpfil/pf/if_pfsync.c:2453:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
pfsync_pointers_uninit()
^
void
sys/netpfil/pf/if_pfsync.c:2503:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
pfsync_init()
^
void
sys/netpfil/pf/if_pfsync.c:2524:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
pfsync_uninit()
^
void
This is because pfsync_pointers_init(), pfsync_pointers_uninit(),
pfsync_init(), and pfsync_uninit() are declared with (void) argument
lists, but defined with empty argument lists. Make the definitions match
the declarations.
MFC after: 3 days
---
sys/netpfil/pf/if_pfsync.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c
index 5f082576a3f9..180bf4440455 100644
--- a/sys/netpfil/pf/if_pfsync.c
+++ b/sys/netpfil/pf/if_pfsync.c
@@ -2436,7 +2436,7 @@ static struct protosw in_pfsync_protosw = {
#endif
static void
-pfsync_pointers_init()
+pfsync_pointers_init(void)
{
PF_RULES_WLOCK();
@@ -2450,7 +2450,7 @@ pfsync_pointers_init()
}
static void
-pfsync_pointers_uninit()
+pfsync_pointers_uninit(void)
{
PF_RULES_WLOCK();
@@ -2500,7 +2500,7 @@ VNET_SYSUNINIT(vnet_pfsync_uninit, SI_SUB_PROTO_FIREWALL, SI_ORDER_FOURTH,
vnet_pfsync_uninit, NULL);
static int
-pfsync_init()
+pfsync_init(void)
{
#ifdef INET
int error;
@@ -2521,7 +2521,7 @@ pfsync_init()
}
static void
-pfsync_uninit()
+pfsync_uninit(void)
{
pfsync_detach_ifnet_ptr = NULL;