git: 563971cd7a41 - stable/12 - Fix unused variable warning in if_alc.c
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 23 Jul 2022 08:59:08 UTC
The branch stable/12 has been updated by dim:
URL: https://cgit.FreeBSD.org/src/commit/?id=563971cd7a41098cfffdc700896ce849f79101ea
commit 563971cd7a41098cfffdc700896ce849f79101ea
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-16 15:06:31 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-23 08:57:44 +0000
Fix unused variable warning in if_alc.c
With clang 15, the following -Werror warning is produced:
sys/dev/alc/if_alc.c:3441:6: error: variable 'prog' set but not used [-Werror,-Wunused-but-set-variable]
int prog;
^
The 'prog' variable seems to be a left-over from some debugging code
that no longer exists, and can be removed without any functional change.
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D35831
(cherry picked from commit 64741244fc4588eefd954948b77ddf2706448ecd)
---
sys/dev/alc/if_alc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/sys/dev/alc/if_alc.c b/sys/dev/alc/if_alc.c
index 8a01f551fd6c..e063e906bf3d 100644
--- a/sys/dev/alc/if_alc.c
+++ b/sys/dev/alc/if_alc.c
@@ -3439,7 +3439,6 @@ alc_txeof(struct alc_softc *sc)
struct ifnet *ifp;
struct alc_txdesc *txd;
uint32_t cons, prod;
- int prog;
ALC_LOCK_ASSERT(sc);
@@ -3468,11 +3467,9 @@ alc_txeof(struct alc_softc *sc)
* Go through our Tx list and free mbufs for those
* frames which have been transmitted.
*/
- for (prog = 0; cons != prod; prog++,
- ALC_DESC_INC(cons, ALC_TX_RING_CNT)) {
+ for (; cons != prod; ALC_DESC_INC(cons, ALC_TX_RING_CNT)) {
if (sc->alc_cdata.alc_tx_cnt <= 0)
break;
- prog++;
ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
sc->alc_cdata.alc_tx_cnt--;
txd = &sc->alc_cdata.alc_txdesc[cons];