From nobody Sat Jul 23 08:58:16 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LqgFN2Vzjz4X74d; Sat, 23 Jul 2022 08:58:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LqgFN20XTz3d02; Sat, 23 Jul 2022 08:58:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658566696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=13BEUX4GG4aaaPFRo6BFwlJG7N7D49roeSKF9pyOVts=; b=M/0jqHG4SN27k+tnD2a6ECoiFU5TjUl2IKkWRYLtAQBr87SzFTsY2ETufKdN6RnWJlQxim mxcNDymkZbnQxIFmNU3V8tUfj09xpmJR5Yq4Qhkj8W7YlE0leEd6tjR98cp9qACcreL9A8 a/QXkDjRjuYVobn1W9tLRjnx1eZ55thKiNdln0uGIJlsATcYdCI+16Pj5036m+GFIMTG+X 25mPasPX5nlnmA0gSfWS5LVXp5qK8QDQKcxvUAdQ2yiK5a4Wj/Q5aRDa2Ad9eDvx4/fvf1 wzdBAlZt7bN269ZZDLcARFcUaiWFJ6dmGcQ8Vq0Y0+66Agf+JwysGcEuWaIupQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LqgFN0zZ8zYhs; Sat, 23 Jul 2022 08:58:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26N8wG5R012583; Sat, 23 Jul 2022 08:58:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26N8wG7W012582; Sat, 23 Jul 2022 08:58:16 GMT (envelope-from git) Date: Sat, 23 Jul 2022 08:58:16 GMT Message-Id: <202207230858.26N8wG7W012582@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 8432a5a4fa3c - stable/13 - Remove unnecessary const and volatile qualifiers from __fp_type_select() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 8432a5a4fa3c4f34acf6136a9077b9ab7bbd723e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658566696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=13BEUX4GG4aaaPFRo6BFwlJG7N7D49roeSKF9pyOVts=; b=JPoDuPKNZzYnpotbiF69Q6bIGuP1ACDo/Q5OivjfNAFWNJUez8BxYrusTCAdqVEJzK/1rI kWk56hsEPk0hcXdkMThIOrfqnsf5wxcN8q3rIZ47s1hF8yZrQ+MwaSrsLEssU6O/uYr7Nd 9jUUPfGZORDV9JypiOhWlplwshxd1ncPiuOITRvy2dG8aHdWxh3Z7VvN4lGcdplRnHHctU 8/9E1LvJRV1Cw+cSWojOgw1/TVeKEkH/VjLrGcyUuwcE6kuxDwE+jImXlJcDoiAG07xBGZ gPSNCSIhLjDMyZatFBjBidswy8Q7COLJXkPN770yGUfYI3DWqMkFfy9xFK1U/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658566696; a=rsa-sha256; cv=none; b=fESXNgIfpz0QyCw0L9tQxBYpd8xg3hlbpHeFdI+2GBtZ0rISpT7YPfe4kJbNsj8yehe+zL 3kkb9zoragAE8u7J1s1Bz/1BsFukEe6l6fkJBLe0zFFuGRfjBnV3+ekaYEfKd8NmNzIelo FGy0IWfBZckWT1z5+zWgE2Ia1bJTT9dooG+2ZqxfD/OxMlz+9Ea8jpu3C3/e6VzakOadYJ F8Lub1TKLZHHGZXeWlgnagyQRFnS4BxBOKNBiev7OeD1H095Ag7JD0khWwH0lDr9v2Zm08 XmaOFtd4/p4v+Vyu2ZevCYsL/vbd059aeCq+at/WoN8M0+qbIkb9yB/rHBaVnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=8432a5a4fa3c4f34acf6136a9077b9ab7bbd723e commit 8432a5a4fa3c4f34acf6136a9077b9ab7bbd723e Author: Dimitry Andric AuthorDate: 2022-07-14 11:20:52 +0000 Commit: Dimitry Andric CommitDate: 2022-07-23 08:56:44 +0000 Remove unnecessary const and volatile qualifiers from __fp_type_select() Since https://github.com/llvm/llvm-project/commit/ca75ac5f04f2, clang 15 has a new warning about _Generic selection expressions, such as used in math.h: lib/libc/gdtoa/_ldtoa.c:82:10: error: due to lvalue conversion of the controlling expression, association of type 'volatile float' will never be selected because it is qualified [-Werror,-Wunreachable-code-generic-assoc] switch (fpclassify(u.e)) { ^ lib/msun/src/math.h:109:2: note: expanded from macro 'fpclassify' __fp_type_select(x, __fpclassifyf, __fpclassifyd, __fpclassifyl) ^ lib/msun/src/math.h:85:14: note: expanded from macro '__fp_type_select' volatile float: f(x), \ ^ This is because the controlling expression always undergoes lvalue conversion first, dropping any cv-qualifiers. The 'const', 'volatile', and 'volatile const' associations will therefore never be used. MFC after: 1 week Reviewed by: theraven Differential Revision: https://reviews.freebsd.org/D35815 (cherry picked from commit e50027e38d4f93887691f87b024e0abf37e98c78) --- lib/msun/src/math.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/msun/src/math.h b/lib/msun/src/math.h index 98601f825bbe..a0edea04dde2 100644 --- a/lib/msun/src/math.h +++ b/lib/msun/src/math.h @@ -81,16 +81,7 @@ extern const union __nan_un { #define __fp_type_select(x, f, d, ld) __extension__ _Generic((x), \ float: f(x), \ double: d(x), \ - long double: ld(x), \ - volatile float: f(x), \ - volatile double: d(x), \ - volatile long double: ld(x), \ - volatile const float: f(x), \ - volatile const double: d(x), \ - volatile const long double: ld(x), \ - const float: f(x), \ - const double: d(x), \ - const long double: ld(x)) + long double: ld(x)) #elif __GNUC_PREREQ__(3, 1) && !defined(__cplusplus) #define __fp_type_select(x, f, d, ld) __builtin_choose_expr( \ __builtin_types_compatible_p(__typeof(x), long double), ld(x), \