From nobody Tue Jul 19 00:23:41 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ln01T3YWsz4TPtt; Tue, 19 Jul 2022 00:23:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ln01T2xgGz483h; Tue, 19 Jul 2022 00:23:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658190221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WLQ69QagkPXUnAMnB5VpoIk4xD17RL2n4a6+aofpuCo=; b=dJuGVHixqj9rNmuRtpF+tBAvjYmXqqOivwzcD7etfUBaQGaSrskeXnJ2JhlpXgiITrC1SV b+Nvibxc+VEvk8F+Uo9ghd+NhptQA2ij4R8LtbGlAJ3cyunH5LCVjUp4taTtN+jHJIVuDU qxLKuKgbUnOs6jRYk0qpO+K7U+z/90wbAdZ7izE/z9kOLOGrWvVPH8eQ7mB8rBZIhxRZBl DeMkrRvYnfMS5A9drem/IMIj5h8qwSFhgLoiH4cvfWAmy1n4mWZAO796wSzzNlBOQzkVnR jYIIEI2hWglUj5INZZ+lIo246Jmwek7nY1edoM5JbSb1DP2C1pYw1j8w00kIqA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ln01T1ksJzySf; Tue, 19 Jul 2022 00:23:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26J0Nfgp036543; Tue, 19 Jul 2022 00:23:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26J0Nfs9036542; Tue, 19 Jul 2022 00:23:41 GMT (envelope-from git) Date: Tue, 19 Jul 2022 00:23:41 GMT Message-Id: <202207190023.26J0Nfs9036542@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 05350f093663 - main - x86: Remove 1 second DELAY from cpu_reset List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 05350f09366363d3b5f0349bea6801593ecbddff Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658190221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WLQ69QagkPXUnAMnB5VpoIk4xD17RL2n4a6+aofpuCo=; b=VvikFVxG9aX08RrKmid9qt1N3x9Yz/QsZpBLMm/QFFW76ThlKTF3dVT0PDEVT/SzY/5Awu MJmcc7VvAKJnhsQOF4pnyapOVwwGP/H3vTR4WBOj8IEtL/fLy1ev2+z/E14jIRSAtfDYRV 0YWGz7BJ0Xm6sq563kv/9hHr2fPxPlVf/5uRHXp0XHV57W+7xyB6yNYl68x4eO28trETfa 1hYb+4voNdHB9NSGTZFFYYf5nnGQfFXsDCgXF7Cli5IIjFjhMcXgzfcFS097U4lZXNFqhL je6I86fY+oM+ZsnyPhHsOzGdK0v0Q+iw0v+9rhZDzlU017qKCuT3Ybfhk2vhmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658190221; a=rsa-sha256; cv=none; b=hogsQ+yaZAENrNiR1+WhyS4+7/8MYHuhczYUmgHKmDC1KN+CwGhA4kVO7LiPSUDLxq8G6V ai8swX/uzzz6778XQoFvoAc9qoWPKlKqnGojkD2vDZdESSXHak47k1S2d9Jv2+fTs414k4 pc2a7J7ovItxjBd4e6Ts+kKFh0wZYICh792SO3H3l6s9Azo0YoPlhjjj6bNFKuWRa6HrOq USir2SDCi7T2tlOB/HZw5mLUh7AwH66L3P6I833+QjSBRwIth3FDrMhuI2S9mNqe5uWKAV XRrzjApbmp5C1qbfD/OpoBGIZHGRqBcSQA/Y2vfN856xreIdUPyx7CdSKFApZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=05350f09366363d3b5f0349bea6801593ecbddff commit 05350f09366363d3b5f0349bea6801593ecbddff Author: Colin Percival AuthorDate: 2022-07-13 00:43:07 +0000 Commit: Colin Percival CommitDate: 2022-07-19 00:23:25 +0000 x86: Remove 1 second DELAY from cpu_reset On SMP systems, cpu_reset broadcasts a message telling the APs to stop themselves, and then the BSP waits 1 second before actually resetting itself; this behaviour dates back to 1998-05-17. I assume that this delay was added in order to allow the APs to stop themselves before the BSP resets; but we wait until the APs have all acknowledged entering the "stopped" state, so it no longer seems to serve any purpose. Reviewed by: jhb, kib Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D35797 --- sys/x86/x86/cpu_machdep.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/x86/x86/cpu_machdep.c b/sys/x86/x86/cpu_machdep.c index 040438043c73..b96e50d785fa 100644 --- a/sys/x86/x86/cpu_machdep.c +++ b/sys/x86/x86/cpu_machdep.c @@ -508,8 +508,6 @@ cpu_reset(void) /* NOTREACHED */ } } - - DELAY(1000000); } #endif cpu_reset_real();