git: 59219dde9a7b - main - if_ovpn: fix mbuf leak
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 12 Jul 2022 12:48:28 UTC
The branch main has been updated by kp:
URL: https://cgit.FreeBSD.org/src/commit/?id=59219dde9a7b5e33cb95e55d4621bd50b3dca37b
commit 59219dde9a7b5e33cb95e55d4621bd50b3dca37b
Author: Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-07-12 12:19:25 +0000
Commit: Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-07-12 12:19:25 +0000
if_ovpn: fix mbuf leak
If the link is down or we can't find a peer we do not transmit the
packet, but also don't fee it.
Remember to m_freem() mbufs we can't transmit.
Sponsored by: Rubicon Communications, LLC ("Netgate")
---
sys/net/if_ovpn.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sys/net/if_ovpn.c b/sys/net/if_ovpn.c
index 779d51075e3d..0f700a9b43d0 100644
--- a/sys/net/if_ovpn.c
+++ b/sys/net/if_ovpn.c
@@ -1988,6 +1988,7 @@ ovpn_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst,
if (__predict_false(ifp->if_link_state != LINK_STATE_UP)) {
OVPN_COUNTER_ADD(sc, lost_data_pkts_out, 1);
OVPN_RUNLOCK(sc);
+ m_freem(m);
return (ENETDOWN);
}
@@ -2005,6 +2006,7 @@ ovpn_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst,
/* No destination. */
OVPN_COUNTER_ADD(sc, lost_data_pkts_out, 1);
OVPN_RUNLOCK(sc);
+ m_freem(m);
return (ENETDOWN);
}