From nobody Sat Jan 29 23:15:43 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CBAA6197AD75; Sat, 29 Jan 2022 23:15:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JmVYW6Vckz3sXR; Sat, 29 Jan 2022 23:15:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643498144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yPQlShO9XnsjczubRHv2Vv2ueX07luRC54E4Ep73fZ4=; b=XFBVKP6BVqMXjCDiiZl9uJDCEAoQzLESVJ/PuZDU8h7PGr7ANcOEnQ9hi71VlvenS08y9P ny0/93ke0wcugB6k+GKR0mSK/jVgUdV2DbU3kCAtpyTIqjYD0XWMMOA6XOva6D9tplQcHE L3kvHeXgUhUVGJD/hHE8KsKMPh5rkChXIt3oKho5xxWGWWnsBT9eo2GfSEXPobEOKlypsD jHSYx6H6p/DKVtW3rk00vLHoBxWuA5vYjOpLACLv+4/W6eXoReMK9GzrfXm5J+J93RW6+J nrzNVTQBQsZUUE+BT9fFni/gHXmDCNqwFL/mwvm3R4tP7JkOQYTnL1w9mVmSbg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 30EE81E47C; Sat, 29 Jan 2022 23:15:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20TNFhxo008257; Sat, 29 Jan 2022 23:15:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20TNFh55008256; Sat, 29 Jan 2022 23:15:43 GMT (envelope-from git) Date: Sat, 29 Jan 2022 23:15:43 GMT Message-Id: <202201292315.20TNFh55008256@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Chuck Tuffli Subject: git: 1381a118297c - main - bhyve nvme: Fix Set Features List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: chuck X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1381a118297c5f304178707219983c4f70cfd2c5 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643498144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yPQlShO9XnsjczubRHv2Vv2ueX07luRC54E4Ep73fZ4=; b=NUa4a3c0cIIcedt9KJQPoyg6YfO7qT/6iPWyVuxspVtOhhHwiY6BKDwjO0KmEc2xUSRDgL NRZVgz8BTRqbqSZ8awHJwJoN8zsYly0Aok+gf3v2RFdz1cd/lVBeRxP740pVFKgFMPaOeF K7Pdbs4+cemoQ9PKE7zHE40jiw5og6WmVkTt3ynvewzBqeVLPANmkcJS4MONdhasxnyUmN m9ft5O0K1Yn9MPkakhaPORI68Ev+l/q6LVAnkpHMFYpn3Rc0Qgghwo60EK0W1omf2rjFV6 mchvjH4i8No+RbL2c/fswJFBHisnft7hkGEiYhjA135S8hsEA0p8dOn7W1nyqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643498144; a=rsa-sha256; cv=none; b=bOCwzG55vSoemf5nwlprVUtzA+XL94t04i7ZWxPa4C0b9npqAPUufleWVUyHBhMi14nNJF pKWLuG7vGETLXyVKJM03p/0gRZzg6fdhd0HyHun/P8vnJV6KSXsX05/5+aoIwbBSIrHM+8 4dGsHQstQRKgcDlOu+HV9dbIYJpiM+CeJOQ3KCjxAjBET82xcnFRP82i8uD0sv43os1Y7D rAKSg9Xkc7RwYt4uqzkpXQxdvHx9SfHMal78BxBT3Wwu6sPrvicQF9qcVfg/BBOAvAmrYZ 8R8X0pRKkDWGE+sXINh0joFlm32tdaVF5FMJI+R/24e/Wz+98FblaY7aAKa6/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by chuck: URL: https://cgit.FreeBSD.org/src/commit/?id=1381a118297c5f304178707219983c4f70cfd2c5 commit 1381a118297c5f304178707219983c4f70cfd2c5 Author: Chuck Tuffli AuthorDate: 2022-01-30 07:07:44 +0000 Commit: Chuck Tuffli CommitDate: 2022-01-30 07:07:44 +0000 bhyve nvme: Fix Set Features Be more conservative and only support the Features mandatory for an I/O Controller. Avoids a "hang" in UNH test 1.2.10 associated with Predictable Latency Mode Configuration and Host Behavior Support features. Tested by: jason@tubnor.net MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D33571 --- usr.sbin/bhyve/pci_nvme.c | 52 ++++++++++++++++++++++++++++++++--------------- 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 64a6e27aa90b..9fe951a4796f 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -666,21 +666,38 @@ pci_nvme_init_logpages(struct pci_nvme_softc *sc) static void pci_nvme_init_features(struct pci_nvme_softc *sc) { - - sc->feat[0].set = nvme_feature_invalid_cb; - sc->feat[0].get = nvme_feature_invalid_cb; - - sc->feat[NVME_FEAT_LBA_RANGE_TYPE].namespace_specific = true; - sc->feat[NVME_FEAT_ERROR_RECOVERY].namespace_specific = true; - sc->feat[NVME_FEAT_NUMBER_OF_QUEUES].set = nvme_feature_num_queues; - sc->feat[NVME_FEAT_INTERRUPT_VECTOR_CONFIGURATION].set = - nvme_feature_iv_config; - /* Enable all AENs by default */ - sc->feat[NVME_FEAT_ASYNC_EVENT_CONFIGURATION].cdw11 = 0x31f; - sc->feat[NVME_FEAT_PREDICTABLE_LATENCY_MODE_CONFIG].get = - nvme_feature_invalid_cb; - sc->feat[NVME_FEAT_PREDICTABLE_LATENCY_MODE_WINDOW].get = - nvme_feature_invalid_cb; + enum nvme_feature fid; + + for (fid = 0; fid < NVME_FID_MAX; fid++) { + switch (fid) { + case NVME_FEAT_ARBITRATION: + case NVME_FEAT_POWER_MANAGEMENT: + case NVME_FEAT_TEMPERATURE_THRESHOLD: + case NVME_FEAT_INTERRUPT_COALESCING: //XXX + case NVME_FEAT_WRITE_ATOMICITY: + /* Mandatory but no special handling required */ + //XXX hang - case NVME_FEAT_PREDICTABLE_LATENCY_MODE_CONFIG: + //XXX hang - case NVME_FEAT_HOST_BEHAVIOR_SUPPORT: + // this returns a data buffer + break; + case NVME_FEAT_ERROR_RECOVERY: + sc->feat[fid].namespace_specific = true; + break; + case NVME_FEAT_NUMBER_OF_QUEUES: + sc->feat[fid].set = nvme_feature_num_queues; + break; + case NVME_FEAT_INTERRUPT_VECTOR_CONFIGURATION: + sc->feat[fid].set = nvme_feature_iv_config; + break; + case NVME_FEAT_ASYNC_EVENT_CONFIGURATION: + /* Enable all AENs by default */ + sc->feat[fid].cdw11 = 0x31f; + break; + default: + sc->feat[fid].set = nvme_feature_invalid_cb; + sc->feat[fid].get = nvme_feature_invalid_cb; + } + } } static void @@ -1937,11 +1954,14 @@ pci_nvme_handle_admin_cmd(struct pci_nvme_softc* sc, uint64_t value) case NVME_OPC_SECURITY_RECEIVE: case NVME_OPC_SANITIZE: case NVME_OPC_GET_LBA_STATUS: + DPRINTF("%s command OPC=%#x (unsupported)", __func__, + cmd->opc); /* Valid but unsupported opcodes */ pci_nvme_status_genc(&compl.status, NVME_SC_INVALID_FIELD); break; default: - DPRINTF("0x%x command is not implemented", + DPRINTF("%s command OPC=%#X (not implemented)", + __func__, cmd->opc); pci_nvme_status_genc(&compl.status, NVME_SC_INVALID_OPCODE); }