From nobody Sat Jan 29 23:15:40 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 88596197ABDB; Sat, 29 Jan 2022 23:15:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JmVYV2K61z3scb; Sat, 29 Jan 2022 23:15:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643498142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TxHIibTnrMs0E+mxTU0BlmR4ZiZQsHQhqxG/44f2Lwk=; b=H8pb7gnFSGA2SmnSPXNw5x5qO4h62yseLa7BIxhV3tiCl/uJE2AOe3phzP8th+Qe0aTnJq Tn4qatGZYhVZOQNfx2VrR0FRjYhyJ8WKr166Sxs8Po5g/GdMh5fVhPiNrX9seL+7E4TWdH oLWaZp9j/p1MoEPzuQyP4s1Q2ALj2+yV/zMHiU4qfKUm0UKobXpsNK5/HMC5IKjeOgbz5M f1juhX0EoQi9Be6fVazRztRRgGz1MSsDaMSbmX+bDGTCEQqip2VQZRgr4EfWDUnmrftoIy io0b8Phan5YoC5wrCPwAo8BxuqG6cm7iLT+JjgrWcAV6asz/+1yxEomIDwUgCg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EDE171E4A0; Sat, 29 Jan 2022 23:15:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20TNFeFh008207; Sat, 29 Jan 2022 23:15:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20TNFeuH008206; Sat, 29 Jan 2022 23:15:40 GMT (envelope-from git) Date: Sat, 29 Jan 2022 23:15:40 GMT Message-Id: <202201292315.20TNFeuH008206@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Chuck Tuffli Subject: git: 785b5da318bf - main - bhyve nvme: Add missing Admin opcodes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: chuck X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 785b5da318bf0e523fa00b3c9c6fde94b1156542 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643498142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TxHIibTnrMs0E+mxTU0BlmR4ZiZQsHQhqxG/44f2Lwk=; b=aDsHHfLwKSw0B5xTA4Flsm//AAb4QUBER+bgVhQw9G896qUed4qKhxlIXwxkjJa040eNYC nHgYuLMUbhAgLGSK2xOBw9JJycrdCTsCqk0t77/pkDusdQX8KHpIBiUGXymUTCzWf6g6Uc 8e2PPmIYz54gOlqDSvNx7OuNXz7obAZx1PhWXLRRBQ/ieB1koY+NRIMTAglSUQzeFVrB1X SvXR95E4QMbSfZd8bPvq/Dww6Ok58qMOcBSnqmw9gMGJPO8CzxvIfWC5u37exUN9UW0kRH JA/iHJmQ60YQ8vDW/QIii5k5FmF3jqygRjQCUhpkLxjQai2070DdGmQDiPFdsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643498142; a=rsa-sha256; cv=none; b=bLTPta5KSz8FLcmKraHRvqtPpX1v84uqs64QRQJbwYV+yKXO+q0C8aDzoZXdddNw/7eGwU yWGPGPmBO1l9Vu5xbiOZuxTrPQtoquEL6e1RGYahtqwSQMuc6Nz8w8R7V52vfZpXJAJZiQ eR8ZHJFga9iikKhmM7CHyY24TYgzbcpzYQzY3wywxUbi6QhCfGF9Hq54/MQo5Bd1+AsF3u GoLEtSiql/k08GMrYEhgdU/4nW0w3JLHQh9a2GM/H4dGRchcESV6ak1iEtWCCP+N1NKC5y llvreA8rQmgQOBeYNr0vKjhAllRVWyYr8X/HWa0JE2wcb1vzPfCjbLVZohb5Gw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by chuck: URL: https://cgit.FreeBSD.org/src/commit/?id=785b5da318bf0e523fa00b3c9c6fde94b1156542 commit 785b5da318bf0e523fa00b3c9c6fde94b1156542 Author: Chuck Tuffli AuthorDate: 2022-01-30 07:07:04 +0000 Commit: Chuck Tuffli CommitDate: 2022-01-30 07:07:04 +0000 bhyve nvme: Add missing Admin opcodes Don't treat unsupported Admin commands as Invalid Opcode. Instead return the proper Invalid Field in Command. Fixes UNH IOL test 1.17.2 Reviewed by: imp, allanjude Tested by: jason@tubnor.net MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D33569 --- usr.sbin/bhyve/pci_nvme.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 43426f5f1f59..c9aaf86ed7be 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -1936,6 +1936,13 @@ pci_nvme_handle_admin_cmd(struct pci_nvme_softc* sc, uint64_t value) } nvme_opc_format_nvm(sc, cmd, &compl); break; + case NVME_OPC_SECURITY_SEND: + case NVME_OPC_SECURITY_RECEIVE: + case NVME_OPC_SANITIZE: + case NVME_OPC_GET_LBA_STATUS: + /* Valid but unsupported opcodes */ + pci_nvme_status_genc(&compl.status, NVME_SC_INVALID_FIELD); + break; default: DPRINTF("0x%x command is not implemented", cmd->opc);