From nobody Thu Jan 27 17:02:58 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9B54D198F6D4; Thu, 27 Jan 2022 17:02:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jl6NL41TMz4X5T; Thu, 27 Jan 2022 17:02:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643302978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AuOIEV1cVn9zkw49rECG2FiptfDRdMh2EDiXVMxHRjs=; b=TgEfvVkfeEr28gZSuVuGmzhOnyZCV+Ky75mEeHhWNzsNwsVZdP+Ea3JGfss+9nYEYo44tW ZFZ1FJWO9DAgab0CuMDSAiv5ON5k+xg3QE9DHneemP91q8OmumqaqabeRGztvJVduHTyzW FJvGKvQ5FweZmPSvT4kwlxqUduyRk8awm98pzqtdc0BQIarqTeaBItgjdu7guFAtmnUaeb V7ZZ4hXFdY7IAUjBAhdQ11/isyAIc5orP5J5g6uOhiPwXSO0uNiM7oVzUsy8n2CQvMWcHs JK7Sa6/ZafwFd8x8W/zofYQEn70zSPw1cXiutBuCw3LYwwB65DP9QuJMHYKPjQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5FCC71A8D7; Thu, 27 Jan 2022 17:02:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20RH2wjo053358; Thu, 27 Jan 2022 17:02:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20RH2wBh053357; Thu, 27 Jan 2022 17:02:58 GMT (envelope-from git) Date: Thu, 27 Jan 2022 17:02:58 GMT Message-Id: <202201271702.20RH2wBh053357@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: 6fd84a627fa0 - main - mmc_da: create disk(9) for pre-2.0 SD cards List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6fd84a627fa066a98777c7ab1e65bdd885407516 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643302978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AuOIEV1cVn9zkw49rECG2FiptfDRdMh2EDiXVMxHRjs=; b=yznvIJAd7P1g7Ne96+HsKvxWB/+p389GHcH4jpdCz4X0G47q74++LRaRftKQXwCGnn8kIC zeMdrdQwELdVfNL6foJCckbZ+oqzJfBpuw95lD2om5JX5HaINdPNKFYIxSZ9Hq3uTNv7UX KqIh5mWyET7GqN6Pmc8R7aHHFJR+8uBoHWT3qeIMLfxvgeZtJS7NjREEGxSdWiEKKPhwCk 9bE/px8rH4XNBnyNRfRmiRCLJu88GhVPfOET4F9qhhTCUN/bf5smEuExM34TzWBGsNW6Vn ovw68Zczt/SRkRxIF4p9LmEte4eIyNazqopusMcVQ7NhJmdRYzF32Kev1/8WIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643302978; a=rsa-sha256; cv=none; b=eUv6MBtbIwqtohixYHPYz0KGIDPY87Vz+M3rkC06+K7sH7sF1ULRtQQUrmu7s2nZljIef9 ZyHoOYyzzrEGFiRPXSnyQQn1mei/FDivWpWTGNoA+SBMn/HZYUpEWvxliMeylRFGFAxEEo KCuGJgaLLxZCVJeiynjWeacH7/CtJ25/otmNK4rk4CAVyTA1DB8J6YTLquUiF5FJgX62vi z9+xlfTPnlTBX11Blxa1lYv7yTl8QzUfQ1iPtcjfrRFcuTRGWzJRdvug0qrvGicB50RVEb WQ40QSzOyZQ+LRdG+bvyG0xTvrFf4He3hjW9BRGN2qR5znKWGev6kx93QujBTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=6fd84a627fa066a98777c7ab1e65bdd885407516 commit 6fd84a627fa066a98777c7ab1e65bdd885407516 Author: Andriy Gapon AuthorDate: 2022-01-27 16:49:27 +0000 Commit: Andriy Gapon CommitDate: 2022-01-27 16:59:54 +0000 mmc_da: create disk(9) for pre-2.0 SD cards It does not look like there is anything in mmc_da code that actually requires protocol 2.0 or later. dev/mmc code also does not have such a restriction. Tested with a very old 2GB mini-SD card. Prior to this change mmc_da would claim the card but would not expose it to GEOM. Without MMCCAM: mmc0: on sdhci_pci0 mmc0: Probing bus mmc0: SD probe: OK (OCR: 0x00ff8000) mmc0: Current OCR: 0x00ff8000 mmc0: CMD8 failed, RESULT: 1 mmc0: Probing cards mmc0: New card detected (CID 1c53565344432020100002982e007600) mmc0: New card detected (CSD 005e00325f5a83d02db7ffbf96800000) mmc0: Card at relative address 0xb368 added: mmc0: card: SD SDC 1.0 SN 0002982E MFG 06/2007 by 28 SV mmc0: quirks: 0 mmc0: bus: 4bit, 50MHz (high speed timing) mmc0: memory: 3998720 blocks, erase sector 256 blocks mmc0: setting transfer rate to 50.000MHz (high speed timing) GEOM: new disk mmcsd0 mmcsd0: 2GB at mmc0 50.0MHz/4bit/65535-block mmc0: setting bus width to 4 bits high speed timing With MMCCAM and this change: sdda0 at sdhci_slot0 bus 0 scbus2 target 0 lun 0 sdda0: Relative addr: 0000b368 Card features: sdda0: Serial Number 0002982E sdda0: SD SDC 1.0 SN 0002982E MFG 06/2007 by 28 SV GEOM: new disk sdda0 Reviewed by: manu MFC after: 3 weeks --- sys/cam/mmc/mmc_da.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c index f669bfb34501..3f6aee72f1d1 100644 --- a/sys/cam/mmc/mmc_da.c +++ b/sys/cam/mmc/mmc_da.c @@ -1481,7 +1481,7 @@ finish_hs_tests: /* MMC partitions support */ if (mmcp->card_features & CARD_FEATURE_MMC && mmc_get_spec_vers(periph) >= 4) { sdda_process_mmc_partitions(periph, start_ccb); - } else if (mmcp->card_features & CARD_FEATURE_SD20) { + } else if (mmcp->card_features & CARD_FEATURE_MEMORY) { /* For SD[HC] cards, just add one partition that is the whole card */ if (sdda_add_part(periph, 0, "sdda", periph->unit_number,