From nobody Wed Jan 26 19:41:35 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6DA0619761EE; Wed, 26 Jan 2022 19:41:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JkYxr0ZfGz4hGY; Wed, 26 Jan 2022 19:41:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643226096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BOPdh/qDUBu0Af4Hm8Pc3dQ8XRJRheSkEobNbvMn+0k=; b=Nwf3x+AeMnax3iAVDWGCke7G3W8A8IoQwRmjXnGrWEimZpsxSFbtPxvZKZ/8BW/d7/XZ9Z I/kO+0PtaOKh8by+H5nGZgbRIlGfqvQPIXkVioYdEe18xLIjCiNwjqCKB+gJM0S/l9q7ze Tq2f/af57PTq/KT9sxzUZBbFq7K5QOUWOOpQVY5+rQ92Cp521iliuTjCsbUrvvLbrOYgHo q7PW4H+vYr/Tsyr6C4WpZkp3ZFDbG4ImQmljn4h8Upquu7J+UrvsT0LsdmO6fzz8kxmUb7 uMCRd309IxpkpdvaLjGJ9FrOP1tq/DvUWe6LUrxLc4IhUYI7Y9J0BFQCFWtAfg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DCC7763B; Wed, 26 Jan 2022 19:41:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20QJfZtr038450; Wed, 26 Jan 2022 19:41:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20QJfZpF038449; Wed, 26 Jan 2022 19:41:35 GMT (envelope-from git) Date: Wed, 26 Jan 2022 19:41:35 GMT Message-Id: <202201261941.20QJfZpF038449@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: e5b431fc0c20 - main - tests: add a basic test for argc == 0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e5b431fc0c20771a2a18cb5169d75cf337d0f1dd Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643226096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BOPdh/qDUBu0Af4Hm8Pc3dQ8XRJRheSkEobNbvMn+0k=; b=xuOggIqGjGCmbhitKrXZRr1jurgbe4kVsqRJLYoOIXZygj6vSmph/Y9zQ8susYPUrNCBpP aPsdiA0gte3LnmXRBLWAseWAUZU/qUkcu93rPCQVaPbAMKBifLO7VGmVlWlN6+vXBmVNKx kGKgdXk2LMojh+nWDGw0Tx+uB/SvBYiaP73RZdvWxo2KUpBs5Ld1pzP8Jwa/Tgoq96wg5d CdcFDmCCKa0OVD9/GtaniEeZZvNRya2BeuK15NFFeZHo9QMXRqXSgfzhEfdp0/Z08tmQMh w3sPU5I8aI8BQFUfcPVZY2T8XPCzF33YbY5r9TsAm77qKIzL4uQtGqhqTIrsWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643226096; a=rsa-sha256; cv=none; b=APlQNpgIfq/15xdLtELD5q3u19wd7GoR7NIjsu7rmCUptle2A63lQOuoPeX6ny3Z++HxpJ la8sN0bxqDEXimkoRgbirNMPrRhItbn5hrvn8guh+Pl7YPrJ2o578k27kvnV559HbWyfQP IfpcP2PDvy/iVwY2KA3A9GHzwZd6yt1H/AJch4yFXSwbVpjZX+67wurI7J48FTwNfyReQG dd0akjuirvhvU6blvTeXDPTVy/3GL9fnECDSfotBZPnO2fCBUY5+6oc/19J7r/mIpHXEp9 s8KZ2XjZaLYavHUaOrhDGgVoXs812vO4Jghpu0b6geDqrinm9MqmO5JH9sHWSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=e5b431fc0c20771a2a18cb5169d75cf337d0f1dd commit e5b431fc0c20771a2a18cb5169d75cf337d0f1dd Author: Kyle Evans AuthorDate: 2022-01-26 01:22:03 +0000 Commit: Kyle Evans CommitDate: 2022-01-26 19:40:27 +0000 tests: add a basic test for argc == 0 The kernel should reject such exec()s now, early on. Instead of adding the needed boilerplate to write a test in C, just add an -n argument for "(n)ull argv" to the execve helper and exec this other helper that just exits silently with argv count. Reviewed by: emaste, kib, markj (all previous version) Differential Revision: https://reviews.freebsd.org/D34045 --- tests/sys/kern/execve/Makefile | 1 + tests/sys/kern/execve/execve_argc_helper.c | 15 +++++++++++++++ tests/sys/kern/execve/execve_helper.c | 13 ++++++++++--- tests/sys/kern/execve/execve_test.sh | 18 ++++++++++++++++++ 4 files changed, 44 insertions(+), 3 deletions(-) diff --git a/tests/sys/kern/execve/Makefile b/tests/sys/kern/execve/Makefile index 82c5d4b85b10..d1dcae623df4 100644 --- a/tests/sys/kern/execve/Makefile +++ b/tests/sys/kern/execve/Makefile @@ -10,6 +10,7 @@ ATF_TESTS_SH+= execve_test PROGS+= good_aout PROGS+= execve_helper +PROGS+= execve_argc_helper LDFLAGS.goodaout+= -static diff --git a/tests/sys/kern/execve/execve_argc_helper.c b/tests/sys/kern/execve/execve_argc_helper.c new file mode 100644 index 000000000000..519c96902fdf --- /dev/null +++ b/tests/sys/kern/execve/execve_argc_helper.c @@ -0,0 +1,15 @@ +/* + * This file is in the public domain. + */ + +#include + +#include + +int +main(int argc, char **argv __unused) +{ + + printf("%d\n", argc); + return (0); +} diff --git a/tests/sys/kern/execve/execve_helper.c b/tests/sys/kern/execve/execve_helper.c index 989b3e4b9761..c14ca2d29554 100644 --- a/tests/sys/kern/execve/execve_helper.c +++ b/tests/sys/kern/execve/execve_helper.c @@ -38,17 +38,24 @@ #include #include #include +#include #include +/* Passing -n == null_argv */ +static char * const null_argv[] = { NULL }; + int main(int argc, char **argv) { - if (argc != 2) { - fprintf(stderr, "usage: %s \n", argv[0]); + if (argc == 2) { + execve(argv[1], &argv[1], NULL); + } else if (argc == 3 && strcmp(argv[1], "-n") == 0) { + execve(argv[2], null_argv, NULL); + } else { + fprintf(stderr, "usage: %s [-n] \n", argv[0]); exit(2); } - execve(argv[1], &argv[1], NULL); err(1, "execve failed"); } diff --git a/tests/sys/kern/execve/execve_test.sh b/tests/sys/kern/execve/execve_test.sh index ef803a18d442..d3650f3472cc 100644 --- a/tests/sys/kern/execve/execve_test.sh +++ b/tests/sys/kern/execve/execve_test.sh @@ -99,6 +99,23 @@ trunc_aout_body() -x "cd $(atf_get_srcdir) && ./execve_helper trunc_aout" } +empty_args_head() +{ + atf_set "descr" "Empty argv behavior" +} +empty_args_body() +{ + atf_check -o inline:"1\n" \ + -x "cd $(atf_get_srcdir) && ./execve_helper execve_argc_helper" + + # Historically we allowed argc == 0, while execve(2) claimed we didn't. + # execve() should kick back an EINVAL now. We verified the helper was + # there/working in the check just above. + atf_check -s exit:1 \ + -e match:".+Invalid argument$" \ + -x "cd $(atf_get_srcdir) && ./execve_helper -n execve_argc_helper" +} + atf_init_test_cases() { atf_add_test_case bad_interp_len @@ -111,5 +128,6 @@ atf_init_test_cases() atf_add_test_case script_arg_nospace atf_add_test_case sparse_aout atf_add_test_case trunc_aout + atf_add_test_case empty_args }