Re: git: 1b90dfa5d2b0 - main - tcp_bbr(4): Fix a few typos in sysctl descriptions

On Wed, Jan 05, 2022 at 08:14:51AM +0100, Michael Tuexen wrote:
> > On 2. Jan 2022, at 18:04, Gordon Bergling <gbe@FreeBSD.org> wrote:
> > 
> > The branch main has been updated by gbe (doc committer):
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=1b90dfa5d2b01549b51d9829206acac39a432bbb
> > 
> > commit 1b90dfa5d2b01549b51d9829206acac39a432bbb
> > Author:     Gordon Bergling <gbe@FreeBSD.org>
> > AuthorDate: 2022-01-02 17:03:10 +0000
> > Commit:     Gordon Bergling <gbe@FreeBSD.org>
> > CommitDate: 2022-01-02 17:03:10 +0000
> > 
> >    tcp_bbr(4): Fix a few typos in sysctl descriptions
> > 
> >    - s/measurment/measurement/
> > 
> >    MFC after:      3 days
> > ---
> > sys/netinet/tcp_stacks/bbr.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c
> > index 4bb0015e3cf5..56e6ebaef2e7 100644
> > --- a/sys/netinet/tcp_stacks/bbr.c
> > +++ b/sys/netinet/tcp_stacks/bbr.c
> > @@ -191,7 +191,7 @@ static int32_t bbr_hptsi_max_div = 2;	/* time, 0 means turned off. We need this
> > static int32_t bbr_policer_call_from_rack_to = 0;
> > static int32_t bbr_policer_detection_enabled = 1;
> > static int32_t bbr_min_measurements_req = 1;	/* We need at least 2
> > -						 * measurments before we are
> > +						 * measurement before we are
> Shouldn't it be measurements instead of measurement?
> 
> Best regards
> Michael

Sorry for the late reply. You right about the grammar typo. I correct this tomorrow, was AFK
for a few days.

--Gordon

> > 						 * "good" note that 2 == 1.
> > 						 * This is because we use a >
> > 						 * comparison. This means if
> > @@ -1402,7 +1402,7 @@ bbr_init_sysctls(void)
> > 	    SYSCTL_CHILDREN(bbr_measure),
> > 	    OID_AUTO, "min_measure_good_bw", CTLFLAG_RW,
> > 	    &bbr_min_measurements_req, 1,
> > -	    "What is the minimum measurment count we need before we switch to our b/w estimate");
> > +	    "What is the minimum measurement count we need before we switch to our b/w estimate");
> > 	SYSCTL_ADD_S32(&bbr_sysctl_ctx,
> > 	    SYSCTL_CHILDREN(bbr_measure),
> > 	    OID_AUTO, "min_measure_before_pace", CTLFLAG_RW,
> > @@ -1558,7 +1558,7 @@ bbr_init_sysctls(void)
> > 	    SYSCTL_CHILDREN(bbr_cwnd),
> > 	    OID_AUTO, "tar_rtt", CTLFLAG_RW,
> > 	    &bbr_cwndtarget_rtt_touse, 0,
> > -	    "Target cwnd rtt measurment to use (0=rtt_prop, 1=rtt_rack, 2=pkt_rtt, 3=srtt)?");
> > +	    "Target cwnd rtt measurement to use (0=rtt_prop, 1=rtt_rack, 2=pkt_rtt, 3=srtt)?");
> > 	SYSCTL_ADD_S32(&bbr_sysctl_ctx,
> > 	    SYSCTL_CHILDREN(bbr_cwnd),
> > 	    OID_AUTO, "may_shrink", CTLFLAG_RW,
> > @@ -2971,7 +2971,7 @@ use_initial_window:
> > 		rtt = (uint64_t)get_filter_value_small(&bbr->r_ctl.rc_rttprop);
> > 		if (rtt && (rtt < 0xffffffff)) {
> > 			/*
> > -			 * We have an RTT measurment. Use that in
> > +			 * We have an RTT measurement. Use that in
> > 			 * combination with our initial window to calculate
> > 			 * a b/w.
> > 			 */
> 

--