From nobody Fri Jan 21 21:42:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 201BE197083F; Fri, 21 Jan 2022 21:42:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JgXt8525Gz3Qjx; Fri, 21 Jan 2022 21:42:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642801376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFlc7i6qhOxnnAC3LuJvVuOLu1Gj4d07snExPOynK4I=; b=SR550GDCNtG8zf9UcZOYRDpnwhh/PFZJ9S4r+vWeOf5A8awtj0H+A7LhbR+7sLgE3f9MPl o0Z1DMKB19qdjBwG0oWjAXtG3cQqevVbGEh+t/k1Gl99925EFKQdAva/6/RlO1+Ro1TeW7 2gxF7NbooAtUbw2aTL5G/lwDyDGmU2b7zNe1c3YQU0E8AXjfBZdx9pdJju3KUaY0cdsDBj wVQGvQoGnE3Y2fr/XC3XJBaTftpujaIP1T84esvqT5UD+gl/G+faJM4VZdb0pp5s9rWTZ9 4nswd3ZYR9irRYe0uH8dHMYRkZvQ7ZgfC1zlczs8fGm+A11oNBurvjxPdEKQ8A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6D58F23249; Fri, 21 Jan 2022 21:42:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20LLguWO050471; Fri, 21 Jan 2022 21:42:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20LLgu4x050470; Fri, 21 Jan 2022 21:42:56 GMT (envelope-from git) Date: Fri, 21 Jan 2022 21:42:56 GMT Message-Id: <202201212142.20LLgu4x050470@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ka Ho Ng Subject: git: fa669505340d - main - iscsi: Fix missing is_lock unlock after cam_simq_alloc() failed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: khng X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fa669505340d54e401917aa6a3d7defb9fc203da Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642801376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFlc7i6qhOxnnAC3LuJvVuOLu1Gj4d07snExPOynK4I=; b=hskfVx9WO1pMJxO9BF9Rq8zPTTJeg7V4zwnbQUqpMtgRxRrsNIJ2GZRS4KVAGNNawL0VI5 cpLIX6Hss6ypEr8LhuwR0xoLkq4VLR1voBDUOvI61dgdK9gFJM2JwbZMJBnDt6wfFIsNrI HT03L3nJ6LvF7IwL0k6dJlBrRCNR4/vb362kv1dNCKrLlOWx15w4ZBrVBjTv7bM71eC568 tf0lFTX1m0i13a3Y2REX8bj242TTZbDxrf9moLuyjU0siq3VkhEMdjGg+xbIUml+xx/ANm DBz/Zcvn9Zmds1H7rpUQpNy/wrC5qjqtFCZNdqCxEP2cmCh5ZMKIvJulmr4ZHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642801376; a=rsa-sha256; cv=none; b=Tkq3OLVONGAUYpeeoGhjVPAikBbVk8NeOIO0rTuO0AT5Bf5rZT4NlhzHnbpHf7eQUWAGk5 9zzQwnywBAu8GWmxMRfW3L/hukd1Feuk4R8aVdbCK7n5UYzqOpgjUq33q9IguXec/dfcjV H3dtcRnQYuX6Ic1fih9NnTQSc56DjN9oLBUgm5J2ELQka1LP+okrpHT1E1dpvIynpNAjNU C5lptxQwMBKWIXYFnZEwI0gTaYh9awbhZpQyWbyMv7HrUZj6cHIkWMeaaGW/njQuX8zECu MK6AzTPNTTpWBwqzV3yE1+zCzPPnoe6fU0P6MpCfJ60JXu0gw0SfZvm7Ziv9Iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by khng: URL: https://cgit.FreeBSD.org/src/commit/?id=fa669505340d54e401917aa6a3d7defb9fc203da commit fa669505340d54e401917aa6a3d7defb9fc203da Author: Ka Ho Ng AuthorDate: 2022-01-21 21:34:15 +0000 Commit: Ka Ho Ng CommitDate: 2022-01-21 21:34:18 +0000 iscsi: Fix missing is_lock unlock after cam_simq_alloc() failed Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/dev/iscsi/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/iscsi/iscsi.c b/sys/dev/iscsi/iscsi.c index 9f49db2ad935..aefae6920ae1 100644 --- a/sys/dev/iscsi/iscsi.c +++ b/sys/dev/iscsi/iscsi.c @@ -1540,6 +1540,7 @@ iscsi_ioctl_daemon_handoff(struct iscsi_softc *sc, ISCSI_SESSION_LOCK(is); is->is_devq = cam_simq_alloc(ic->ic_maxtags); if (is->is_devq == NULL) { + ISCSI_SESSION_UNLOCK(is); ISCSI_SESSION_WARN(is, "failed to allocate simq"); iscsi_session_terminate(is); return (ENOMEM);