From nobody Tue Jan 18 15:19:15 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C8AD1195B67C; Tue, 18 Jan 2022 15:19:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JdXVs5JlZz3HQn; Tue, 18 Jan 2022 15:19:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642519157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUSmzOQLorcKRut1IbqocHF5w96/u9MORzm/bGtOoo0=; b=wRMrI5RzwdIN62ryD9CIIb/8u/Z5YieE08zHk2R2XfPYm800UdyzZItaDdbbkqKj0FGkdq DDiwxV/2SiVFA1Ss7/tPPSqiWf2E0qLo5p7VdT041QrS7ZqHiCtVUt4M4xD9/8opqpfed8 5yCLfT8oiok7+9Q/n6jztbFK8xZSShLBJ3AD9nLm5G4G8xEnHBQVvCdh6nyewysmQkQ3lQ FtDAzXxC0TvRPZFRrNhywnGHK5DEgiMY4J8nD6DHpYE2yaai+1cZNdTA8iQbCM2BMfiPHv hOsS5eBzPEBr1xvecLIER8ByWSMIIcYPDEgX5CbxZBn7h50QTg8W4zvIwQJ48w== Received: from [IPV6:2601:648:8601:8b20:a805:a11d:8c0d:2824] (unknown [IPv6:2601:648:8601:8b20:a805:a11d:8c0d:2824]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 24B5027EC8; Tue, 18 Jan 2022 15:19:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <18d89f85-7d6d-80b4-7e5a-ae3cc30f5249@FreeBSD.org> Date: Tue, 18 Jan 2022 07:19:15 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: Emmanuel Vadot , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202201141142.20EBgBdI076921@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: 6171e026be11 - main - bhyve: add support for MTRR In-Reply-To: <202201141142.20EBgBdI076921@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642519157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUSmzOQLorcKRut1IbqocHF5w96/u9MORzm/bGtOoo0=; b=Wj3EkJdO5tgyUXCO801K9oPB30fjWZEeYoNm8ubOiHYNRDTWg9ZGZhjqcg0cukGEIA36LE iWGMB5TnWsl9s6+98jtSO8MZA5Uk3BuDFlbaWmVm0eC5qGOYujTJD24QL0cv2nfXmqpu9K nHI80h2PlpuwoOTd2zfQRR8FrN0dvs+hxKFr86f5UxaGCzJPFf5cFW7NKQ37ZdRn2Ggyaa yK9MVZspHvcsvn5aK6JkHu/JNsoHw43mKGxiFJRCKK+QalorVPYojLOGFH5rU6+FeR5bVo /wc7KvHgeXdV7c/jcPbqpih+7FGIESPo4jthtE5GDSYiiOQjiHKvQ3r2NdpCtw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642519157; a=rsa-sha256; cv=none; b=mnjZVkFPxHesKt4m7mvyVIhQcfEKFTVXwqOWmkSjCGh8aoTX4sPSjTeFcjM+Zim7bVzbS0 jLFYmgiPSVdTraELD0G1mmWI3CEl8eygHCIXGVcsN5JKsx1/r4g1LmeS7PsKeTurxaBbIf DFc+2/bA5xL9Fl7bFcLFOwMlvJmbOiVFCqWP8DE7mrcIAvVGMSG3RyEFwmR7XwtVdxfvag sFxPlxtKW+i3AzHWb2qXYFKD+D04H10ZJzOsFBmVOLSzQ4l7G5aNZrnzy/mhJhwrn8U+Mf 6TsCDg/ha0YkVJK8SmSrIyHCDz+XVABpSSsHj/Ir77Z8hPv0lzxabkEG/zisrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 1/14/22 3:42 AM, Emmanuel Vadot wrote: > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6171e026be11824495cebe8baf559af673a8e533 > > commit 6171e026be11824495cebe8baf559af673a8e533 > Author: Corvin Köhne > AuthorDate: 2022-01-14 09:58:48 +0000 > Commit: Emmanuel Vadot > CommitDate: 2022-01-14 11:41:44 +0000 > > bhyve: add support for MTRR > > Some guests or driver might depend on MTRR to work properly. E.g. the > nvidia gpu driver won't work without MTRR. > > Reviewed by: markj > MFC after: 2 weeks > Sponsored by: Beckhoff Automation GmbH & Co. KG > Differential Revision: https://reviews.freebsd.org/D33333 So this doesn't look like actual emulation, but more like a dummy version? That is, the values aren't initialized to the "normal" state (WB for guest RAM, UC- for everything else), and the state isn't enforced in any way (I think the only sane way to actually implement these would be to use MTRR to set PAT values in EPT entries if EPT even supports PAT). Perhaps this mostly doesn't matter since we don't directly map BARs in EPT anyway? (Though perhaps for passthrough we might in which case you'd want to honor these settings in those?) -- John Baldwin