From nobody Tue Jan 18 08:11:31 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 84DE8196748E; Tue, 18 Jan 2022 08:11:34 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JdM1L2kjbz3h2Y; Tue, 18 Jan 2022 08:11:34 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642493494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3K4E6zm57SHpUINopXMcDjK+Tnn4FOrdyQK6cVFb9A=; b=QuDxzWw6YN3/UET7fNbHKggF9MjGPzH8XyJsQW0vyoJrwYwaPbopB1WK3THC1N8ozu6l1z h7a7pSp71QWBM7MF2AWxBD78rzB1K8uPiOhbvdQUQbZxuQmj/OQPlwwBwUmAGldCPp6opz ql9e6siYOkXDCj1yAhoFVH5urMav1XTIon14Qzvohg0aGdk3WPAjjRlLDNovuEmkgSw027 Pl3R5BG39NbNsKu18CD1FZP6NhB+qLdgQo47+nBLI4a8/RyUTxJYbeYC6/1Y4qctcxJI+K kiZMXMx1NgwdQGh2bNQxuxz68endkqDPTQfCtiTdkI7WwElgRnIqsdJeRRDYdA== Received: from [172.24.42.13] (host-79-18-132-211.retail.telecomitalia.it [79.18.132.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7EBDB24EEF; Tue, 18 Jan 2022 08:11:33 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Tue, 18 Jan 2022 09:11:31 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: git: cfb7b942bed7 - main - cryptosoft: Use multi-block encrypt/decrypt for non-AEAD ciphers. Content-Language: en-US To: Mark Johnston Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202201112238.20BMcBgx075881@gitrepo.freebsd.org> From: Guido Falsi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642493494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3K4E6zm57SHpUINopXMcDjK+Tnn4FOrdyQK6cVFb9A=; b=bk2DAH++UIV4tTXLYDBuk38+I7WRS2qz9REaNvwBWpQ9usEy1UbEzAGDemVcaEuUL0Y6l9 3cZNdB6N2QI69wQXoK8r0qVrb0M20QXrFat7IKtp84WmfVbUiAeiPxteEt8aoE0/nXzwwp WKjAwm34icDewTiUfHkO97fC9GL9KR1TMaX/tynXkxLOaBQUkxpuuN1qC7T9gbIWlNapMB B1grPlNcaumsKbwooGempnpWtREGa3fCKtAS9sVxILAvSf4lArCSJ7lrAKudDq8vhyKdMr E68IXHIaMymRBBTr5sOne/pO4fiKPFlqka6mEZk7uU6e4gXPLXr0KsXuoUlKjw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642493494; a=rsa-sha256; cv=none; b=o2MkG1l7AiY3V/NM21Ei1+0MnzOa8ofb0+9UFaaWc1tgeS/aLiI0xsYbeqFGaqbNNiRZcx K9UzUVmvNIqe9YaDOtwttkdmA15hTjU24MLs83vAslRrb/oOxrkPY4rKTgryqYwPWSxa6C qR7SRp4FtdA3hmP45SmokuAj1wAQtMMPz1not8Rg6AofKBIz4XmGkK+GBu04JH8Q7XmwVM 74wt7LH4IExtw9Yvn1G60qYdxf9lxIT37G1yFKT5agh1IuWBYsT+gN4vvcZwEKk84EQtxT /cqN/2+3L0sjUKsVcm5rvEIqTPF3cm+zRZVQEMK+CcQbEDHsUWtNcaFfxHn+/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 18/01/22 01:06, Mark Johnston wrote: > On Mon, Jan 17, 2022 at 10:30:05PM +0100, Guido Falsi wrote: >> On 15/01/22 01:26, Mark Johnston wrote: >>> On Fri, Jan 14, 2022 at 10:27:12PM +0100, Guido Falsi wrote: >>>> On 11/01/22 23:38, John Baldwin wrote: >>>>> The branch main has been updated by jhb: >>>>> >>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=cfb7b942bed72cb798b869d2e36e0097dbd243b2 >>>>> >>>>> commit cfb7b942bed72cb798b869d2e36e0097dbd243b2 >>>>> Author: John Baldwin >>>>> AuthorDate: 2022-01-11 22:18:57 +0000 >>>>> Commit: John Baldwin >>>>> CommitDate: 2022-01-11 22:18:57 +0000 >>>>> >>>>> cryptosoft: Use multi-block encrypt/decrypt for non-AEAD ciphers. >>>>> >>>>> Reviewed by: markj >>>>> Sponsored by: The FreeBSD Foundation >>>>> Differential Revision: https://reviews.freebsd.org/D33531 >>>> >>>> Hi, >>>> >>>> I've just updated to recent head. I have a laptop using ZFS on geli >>>> setup and now it's unable to boot. >>>> >>>> I've seen the failure starting with git revision >>>> 3284f4925f697ad7cc2aa4761ff5cf6ce98fd623 (LRO: Don't merge ACK and >>>> non-ACK packets together - 01/13/22, 17:18) >>>> >>>> it's still there with revision fe453891d7ccc8e173d9293b67f5b4608c5378dd >>>> (01/14/22 11:00:08) >>>> >>>> While a kernel from the binary snapshot downloaded from mirrors compiled >>>> from revision ac413189f53524e489c900b3cfaa80a1552875ca (vfslist.c: >>>> initialize skipvfs variable 01/05/2022) is able to boot correctly. >>>> >>>> The machine panics as soon as it tries to work with geli, this is why I >>>> am replying to this commit message. I'm not completely sure this is the >>>> commit to blame, but it sure is related. >>>> >>>> I have not been able to save the backtrace to file, but the last two >>>> calls are to: >>>> >>>> crypto_cursor_segment() >>>> swcr_encdec() >>>> >>>> so it points to the last part of this patch. >>> >>> I think the problem is that crypto_cursor_segment() doesn't expect to be >>> called once the cursor is at the end of a buffer. It may or may not >>> perform an invalid memory access in that case, depending on the >>> underlying buffer type. >>> >>> Fixing it would complicate the cursor code, maybe it's better to just >>> change cryptosoft to avoid this scenario: >> >> Is this being followed up? Ads I said this patch works for me and I'm >> using it locally. While I'm unable to review it, as a user and >> contributor I'm interested in the issue being fixed for good in the >> official tree. >> >> If discussion is already ongoing in a publicly accessible can you point >> me to it? Thanks! > > I committed it just now, after some private discussion with John. > Thanks for the report and for testing. > Thanks a lot to both of you! -- Guido Falsi