From nobody Fri Jan 14 22:41:22 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EF36019422DE; Fri, 14 Jan 2022 22:41:32 +0000 (UTC) (envelope-from SRS0=a5Dn=R6=klop.ws=ronald-lists@realworks.nl) Received: from smtp-relay-int.realworks.nl (smtp-relay-int.realworks.nl [194.109.157.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JbGW004Tnz4nJJ; Fri, 14 Jan 2022 22:41:31 +0000 (UTC) (envelope-from SRS0=a5Dn=R6=klop.ws=ronald-lists@realworks.nl) Date: Fri, 14 Jan 2022 23:41:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1642200083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=IPNu0GCNXHCsARa6u0GDza6Z2hW3ceIIg4f4J1E9x1g=; b=zWOEAEps5E9Ibx1QwP1z8zQseN7wCXq6iTYIBOATBJR8rhANntRckdFIMfp1JQu4CsfWwq LmEIZrcws4vrgFhnl2w2XT/pxULJq873q6FPKrTKdyq3yi4LTZF8JsL7UcChKqZRgRTgl9 SLv3FAmN5E2TNLE6N7dyAkySqZOYB2j/AJdh0M9YAauTDfk0Tv6S9GfVSFNzEXDHs8jEEO w6DB4XcJZCWSTklSN9uZoJpM96JxS//lP6Qzvo6rjXbTvL0e7WjMzQmA4cvAkXUB3nKexT YfsYnIioEZBho3y1J66+0MsSBiye6WSTXfSEXFHlDz+lTjs8zf10aHTgAH04nQ== From: Ronald Klop To: dev-commits-src-all@FreeBSD.org, Daniel Ebdrup Jensen , dev-commits-src-main@FreeBSD.org, src-committers@FreeBSD.org Message-ID: <493738071.2419.1642200082113@localhost> In-Reply-To: <202201142044.20EKirZj000512@gitrepo.freebsd.org> Subject: Re: git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_2418_1796675345.1642200082110" X-Mailer: Realworks (590.253.ec54157) Importance: Normal X-Priority: 3 (Normal) X-Rspamd-Queue-Id: 4JbGW004Tnz4nJJ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=klop.ws header.s=rw2 header.b=zWOEAEps; dmarc=pass (policy=quarantine) header.from=klop.ws; spf=pass (mx1.freebsd.org: domain of "SRS0=a5Dn=R6=klop.ws=ronald-lists@realworks.nl" designates 194.109.157.24 as permitted sender) smtp.mailfrom="SRS0=a5Dn=R6=klop.ws=ronald-lists@realworks.nl" X-Spamd-Result: default: False [-3.20 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[klop.ws:s=rw2]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:194.109.157.0/24]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[klop.ws:+]; DMARC_POLICY_ALLOW(-0.50)[klop.ws,quarantine]; HAS_X_PRIO_THREE(0.00)[3]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FORGED_SENDER(0.30)[ronald-lists@klop.ws,SRS0=a5Dn=R6=klop.ws=ronald-lists@realworks.nl]; RCVD_COUNT_ZERO(0.00)[0]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:3265, ipnet:194.109.0.0/16, country:NL]; FROM_NEQ_ENVFROM(0.00)[ronald-lists@klop.ws,SRS0=a5Dn=R6=klop.ws=ronald-lists@realworks.nl] X-ThisMailContainsUnwantedMimeParts: N ------=_Part_2418_1796675345.1642200082110 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Van: Daniel Ebdrup Jensen Datum: 14 januari 2022 21:45 Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commi= ts-src-main@FreeBSD.org Onderwerp: git: 9f0b56872c1f - main - carp(4): Make regex additionally matc= h on VLAN interfaces >=20 >=20 > The branch main has been updated by debdrup (doc committer): >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D9f0b56872c1fb790f67ee45a56= ceeeed5d17ddea >=20 > commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea > Author: Daniel Ebdrup Jensen > AuthorDate: 2022-01-14 20:32:06 +0000 > Commit: Daniel Ebdrup Jensen > CommitDate: 2022-01-14 20:44:13 +0000 >=20 > carp(4): Make regex additionally match on VLAN interfaces > =20 > This tiny change to the example makes devd capable of reacting to car= p > status change events on VLAN interfaces. > =20 > Reported by: Thomas Steen Rasmussen (tykling) > --- > share/man/man4/carp.4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4 > index 8d54d56afa03..2785b97e76ac 100644 > --- a/share/man/man4/carp.4 > +++ b/share/man/man4/carp.4 > @@ -290,7 +290,7 @@ status change events can be set up by using the follo= wing devd.conf rule: > .Bd -literal -offset indent > notify 0 { > match "system" "CARP"; > - match "subsystem" "[0-9]+@[0-9a-z]+"; > + match "subsystem" "[0-9]+@[0-9a-z.]+"; > match "type" "(MASTER|BACKUP)"; > action "/root/carpcontrol.sh $subsystem $type"; > }; >=20 >=20 >=20 >=20 >=20 Hi, I don=E2=80=99t think you need to escape a dot inside a character class. But maybe this regex engine does need it.=20 Nice change about the vlan though.=20 Regards, Ronald ------=_Part_2418_1796675345.1642200082110 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Van: Daniel Ebdru= p Jensen <debdrup@FreeBSD.org>
Datum: 14 januar= i 2022 21:45
Aan: src-committers@FreeBSD.org, dev-com= mits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Ond= erwerp: git: 9f0b56872c1f - main - carp(4): Make regex additionall= y match on VLAN interfaces

The branch main has been updated by debdrup (doc commi= tter):

URL: https://cgit.FreeBSD.org/src/commit/?id=3D9f0b5687= 2c1fb790f67ee45a56ceeeed5d17ddea

commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea
Author:     Daniel Ebdrup Jensen <debdrup@FreeBSD.or= g>
AuthorDate: 2022-01-14 20:32:06 +0000
Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.or= g>
CommitDate: 2022-01-14 20:44:13 +0000

    carp(4): Make regex additionally match on VLAN inte= rfaces
    
    This tiny change to the example makes devd capable = of reacting to carp
    status change events on VLAN interfaces.
    
    Reported by:    Thomas Steen Rasmuss= en (tykling) <thomas at gibfest.dk>
---
 share/man/man4/carp.4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4
index 8d54d56afa03..2785b97e76ac 100644
--- a/share/man/man4/carp.4
+++ b/share/man/man4/carp.4
@@ -290,7 +290,7 @@ status change events can be set up by using the followi= ng devd.conf rule:
 .Bd -literal -offset indent
 notify 0 {
    match "system"     &n= bsp;    "CARP";
-   match "subsystem"      &nb= sp;"[0-9]+@[0-9a-z]+";
+   match "subsystem"      &nb= sp;"[0-9]+@[0-9a-z.]+";
    match "type"     &nbs= p;      "(MASTER|BACKUP)";
    action "/root/carpcontrol.sh $subsystem $type&= quot;;
 };



Hi,

I don=E2=80=99t think you need to es= cape a dot inside a character class.
But maybe this regex engine does n= eed it. 

Nice change about the vlan though.=  

Regards,
Ronald

------=_Part_2418_1796675345.1642200082110--