From nobody Fri Jan 14 21:27:12 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ABDC3195727C; Fri, 14 Jan 2022 21:27:15 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JbDsH4Y3vz3pM9; Fri, 14 Jan 2022 21:27:15 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642195635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+tfm+8LsaKTD/aqoM7ZLaEhvikfjyla4HVJ8fAhcpg=; b=RGSNQNlfDae8cyF03ehCbMp6aeaf+ngFo+930nLrCSl2VSOqb3OoNhk8Tc5qsx+OCyAtnV 1VQampbklqyIHsvo0mYhJfkOYw8V7fSh5T7rgFj9XROCXx4DQMNe7qHJH/iwo/+ilWsRxn 36mcNZTgBnkXuuttKybhnJe+fbmgqtAxS/PKmrA04JCPfqITORV779kcd2TgEcrV/f7MCr CUJh4FKIBel7MSX6oom9/U2MJSfqGQaZRo2sQJUUVQSc+f9Q5mB9Td8YB8XujrjYFPvlst dLR5ejrFDXdB6X4jNeA/+EWa53w+Ws2EIGLYAimxws9jJou11S0Zxo7orU866w== Received: from [172.24.42.13] (host-79-18-132-211.retail.telecomitalia.it [79.18.132.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id EE957C1D8; Fri, 14 Jan 2022 21:27:14 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Fri, 14 Jan 2022 22:27:12 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: git: cfb7b942bed7 - main - cryptosoft: Use multi-block encrypt/decrypt for non-AEAD ciphers. Content-Language: en-US To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202201112238.20BMcBgx075881@gitrepo.freebsd.org> From: Guido Falsi In-Reply-To: <202201112238.20BMcBgx075881@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642195635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+tfm+8LsaKTD/aqoM7ZLaEhvikfjyla4HVJ8fAhcpg=; b=HHvydJ6bDLVCo3772c3gqJUtMsBn4S/TsHIymmIXsrlcLwx58SgMAjdkWXced48Ei8B+fu HiL30Kz3c86WdPmJOMcYeuYlY85EF9Yhe3DslfMwrygw5jyEkOVqaKff/wDfsKgSnZWENU NMG2cFgx6whRIJBOlEYynd7fC7v/CFJxKVjcMUlJw3xp0/YDgvq6kXrc0QscpHOk9KSmZW qzCTHQ5XYq13h2+v6GX953d5LsZnWHrb4g9jNHIk161q4P3OrS1cKoTAoRBL1PgHk9VUic eXGaUndvCpivPGJHnhkCiF/2XG0Jb+gJls7U+nH0oz6HjIn/LncVDjY/lUEf0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642195635; a=rsa-sha256; cv=none; b=vwAgbMzcW4+iB4Y2eSVKXdADfSfCPHH+wRoAzacaz5dIv7qR85ZhRbULxuWQKRXChmjnQF 495BfEyWEjZyFBxKU7W50cpeJDdYKsQ7jdbFtOvzFpq3nkBJz25FJzMn4fktcQx9/wC8d+ jrrWtB2M5W384H2gVYwq06UOcSxcGrOO1pe/wY+Y2vt3VCc2u/mpzl6qqN42LPwwcGIOFQ tV/cVbvAu90WEHrBrydkTqJjPJIsjEEOXmORpToNORNxa5yaDU9/BEHpQsqQG16dCDOKCI 2JV9blh0QqtqO5XagCkAq9f4P3+moLBnfao4GC3jBP4vpsv8YAKMA3PvDklXKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 11/01/22 23:38, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=cfb7b942bed72cb798b869d2e36e0097dbd243b2 > > commit cfb7b942bed72cb798b869d2e36e0097dbd243b2 > Author: John Baldwin > AuthorDate: 2022-01-11 22:18:57 +0000 > Commit: John Baldwin > CommitDate: 2022-01-11 22:18:57 +0000 > > cryptosoft: Use multi-block encrypt/decrypt for non-AEAD ciphers. > > Reviewed by: markj > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D33531 Hi, I've just updated to recent head. I have a laptop using ZFS on geli setup and now it's unable to boot. I've seen the failure starting with git revision 3284f4925f697ad7cc2aa4761ff5cf6ce98fd623 (LRO: Don't merge ACK and non-ACK packets together - 01/13/22, 17:18) it's still there with revision fe453891d7ccc8e173d9293b67f5b4608c5378dd (01/14/22 11:00:08) While a kernel from the binary snapshot downloaded from mirrors compiled from revision ac413189f53524e489c900b3cfaa80a1552875ca (vfslist.c: initialize skipvfs variable 01/05/2022) is able to boot correctly. The machine panics as soon as it tries to work with geli, this is why I am replying to this commit message. I'm not completely sure this is the commit to blame, but it sure is related. I have not been able to save the backtrace to file, but the last two calls are to: crypto_cursor_segment() swcr_encdec() so it points to the last part of this patch. I have taken a picture of the backtrace on screen, you can find here: https://www.madpilot.net/cloud/s/6KtAXx6Q7R9dJ7c BTW this is happening on an older laptop without any crypto hardware, I use this machine to test head before upgrading other ones. Maybe this is exposing a bug not showing up on newer hardware? Do you have any clue? Looks like something broke with this bunch of commits to the geli/crypto stuff. I can try bisecting tomorrow, but it can take a little time. Thanks in advance. -- Guido Falsi