From nobody Fri Jan 14 08:45:19 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 145701953FD5; Fri, 14 Jan 2022 08:45:24 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JZvyC71JMz4qwq; Fri, 14 Jan 2022 08:45:23 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642149924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6piRWrdTIl/vN8xovLA4fQchuUMOP9ix1OgIDKPGQig=; b=JuU6z6WYDIZVqFoXpN0eElkzLLdTmql+dbwmSx5GJk0SlqTcj+VDv/KuRMzkjoXPhVyRot 9RILKIoJqiNPGnrzm+Zfhv3+pw2bTxr/RFYLgMBL8DOk4iFpM5+zmYTNwOwrirsxd8xhk1 BYwSAUSXekaj5fKA+ad1QLVu90ZYnL13zk06CU8NVOR2Modmrw/bIFK2btJG0PBG9oRVV+ b3iqVFJFwnvYtvGQbazjJPz3LFyRuFFyQWVbG2Fq0OkqOeqG5ThFBasPdbQTxux4NOqWaU esblU+R7CRZQ+weA1SBIT12tXyEowvqsKVAWeulQwF1v3IKrvCxzfkob/eSs+g== Received: from [IPV6:2003:cd:5f13:2400:6b:2428:7065:f0c2] (p200300cd5f132400006b24287065f0c2.dip0.t-ipconnect.de [IPv6:2003:cd:5f13:2400:6b:2428:7065:f0c2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 3A55E61EE; Fri, 14 Jan 2022 08:45:23 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: Date: Fri, 14 Jan 2022 09:45:19 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: git: 82bfeeff10da - main - tools/portconflicts/port_conflicts_check.lua: detect port conflicts Content-Language: en-US To: Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202201132138.20DLccSU044307@gitrepo.freebsd.org> From: Stefan Esser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------IxwaWpZ4htWGZrWt7WxiwOkG" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642149924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6piRWrdTIl/vN8xovLA4fQchuUMOP9ix1OgIDKPGQig=; b=gCD0w4kkGm2HxRke14y4qZ+l9yYOelnN+HlKzFcEskOr1TTZY8vZksyfxQDewdjEYW06Hq MQsSOj5baktr2eNmVDspJG+bAjnrxBSjJqmYfof1kUSwGBZAKR822cWDCVqVFa90982Yhs 6WKgLZqxwiQYcEubv1JiKuUek8376PkL1r//Igw7WK+ozyOoqF53+4jKQ2WMPwyHTgFszh Q7t7INsPjjgf2iFqA1gEFAt8dywjjYyx6al/3iKMwwKw/F4i6VjbdHo+uT+lLaZ3x9RglG bz7nAJAm8mvnexuspOS9CkBeG/XERSTr1jH43eM6mv7KeSlMsQB4yfNKpDrmvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642149924; a=rsa-sha256; cv=none; b=N5LrR1SrSFUuiFw5pYN1pOdtJy6EhRrP42ldpFz7ZmZ74T7iEsAyQ8eFNY41FhxC1mJn5a mxx2V9hU/iNIKcuMzxs7CLVopIe2fMJjTHsjFwBbxJxyT/XEp29gnXGJgKEQp7xazl9Dr1 Npta1WfpQujchwrhuvcI88SYy81CbypfDaXWDeA3xG/cjSKJ+qSLCYebFIEc8cV3AJ+OMy heSUf7+8jgThIrtcDtF0UNbFOGYsM4wqsaAFbrwiIFtMCK8qbhmoguZ3mpoBwm/dODp7JW Zvvcbkhvpgo9UIRTkYKrXpO+2Rw1IlElyR3eSVf0N3BqmNKDINoPt3y7z4phpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IxwaWpZ4htWGZrWt7WxiwOkG Content-Type: multipart/mixed; boundary="------------zWz9szYrO2z0Wr0dALiYggbm"; protected-headers="v1" From: Stefan Esser To: Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: Subject: Re: git: 82bfeeff10da - main - tools/portconflicts/port_conflicts_check.lua: detect port conflicts References: <202201132138.20DLccSU044307@gitrepo.freebsd.org> In-Reply-To: --------------zWz9szYrO2z0Wr0dALiYggbm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 14.01.22 um 00:13 schrieb Kyle Evans: > and runOn Thu, Jan 13, 2022 at 3:38 PM Stefan E=C3=9Fer wrote: >> >> The branch main has been updated by se: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D82bfeeff10da860b1ed9f03= a01f3282b42b991be >> >> commit 82bfeeff10da860b1ed9f03a01f3282b42b991be >> Author: Stefan E=C3=9Fer >> AuthorDate: 2022-01-13 21:36:09 +0000 >> Commit: Stefan E=C3=9Fer >> CommitDate: 2022-01-13 21:36:09 +0000 >> >> tools/portconflicts/port_conflicts_check.lua: detect port conflict= s >> >> This tool can be used to detect install conflicts (ports/packages = that >> conflict with each other because of identically named files). >> >> MFC after: 3 days >> >=20 > Hi, >=20 > Good to see more use of flua coming into the tree. :-) I recommend > grabbing devel/lua-luacheck and running that over the file -- it's > mostly pointing out complaints about things that should be declared > `local`, but also notes some style-type issues and a write-only > variable. I know about and use luacheck for other projects, did not consider it relevant for such a trivial script, but you are right, I should fix the warnings, especially without global variables (which do not cause any issues, but obviously are style violations). Regards, STefan --------------zWz9szYrO2z0Wr0dALiYggbm-- --------------IxwaWpZ4htWGZrWt7WxiwOkG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmHhOB8FAwAAAAAACgkQR+u171r99UTQ mAf/ZkIstoCucM0QMZTytxUnYveOjjj+ecedhT/xr4zbCM3yAg45vELOglDMWXtf8L6LpipQciUn 7Ygspxo3fpMT8xGSa7T2VMcl2HgwPzg6ayqtJR244ShSuqCKDQAw6wqZv0FyuDGBfsXCbFjtsxW/ Cq07JLcI+/f+qob3StdznWCs6K5ybtv4EQdHiWGna2q6usGyJ7vv5iQL0G57a9Piaz5h8sVAgTLa gcE/JhK8MblcJizK56xaXRfkTJR7TN2IDSf7MLgz5g4Tb5elCrlXzPExXtzs3sIr6vab2B5ep+Qa XJIpOC5UOZGWLCHhPaeFIYnQmmLZBWMzRikjGg5qPw== =WL0h -----END PGP SIGNATURE----- --------------IxwaWpZ4htWGZrWt7WxiwOkG--