Re: git: ca2a7262df5e - main - Free UMA zones when a pass(4) instance goes away.

  Kenneth,

On Thu, Jan 13, 2022 at 03:56:39PM +0000, Kenneth D. Merry wrote:
K> commit ca2a7262df5ec5fd07d4ac61738947f48c9cd7f2
K> Author:     Kenneth D. Merry <ken@FreeBSD.org>
K> AuthorDate: 2022-01-13 15:50:40 +0000
K> Commit:     Kenneth D. Merry <ken@FreeBSD.org>
K> CommitDate: 2022-01-13 15:54:56 +0000
K> 
K>     Free UMA zones when a pass(4) instance goes away.
K>     
K>     If the UMA zones are not freed, we get warnings about re-using the
K>     sysctl variables associated with the UMA zones, and we're leaking
K>     the other memory associated with the zone structures.  e.g.:
K>     
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.size)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.flags)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.bucket_size)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.bucket_size_max)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.keg.name)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.keg.rsize)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.keg.ppera)!
K>     sysctl_warn_reuse: can't re-use a leaf (vm.uma.pass44.keg.ipers)!
K>     
K>     Also, correctly clear the PASS_FLAG_ZONE_INPROG flag in
K>     passcreatezone().  The way it was previously done, it would have
K>     had set the flag and cleared all other flags that were set at
K>     that point.

Definitely not my area, but I wonder why would we create a zone per
device? Why not a global zone in the driver?

-- 
Gleb Smirnoff