From nobody Mon Jan 10 00:26:01 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 068FC193EC2A; Mon, 10 Jan 2022 00:26:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JXF3s5Gfsz54d3; Mon, 10 Jan 2022 00:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 90C791B9FB; Mon, 10 Jan 2022 00:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20A0Q1jH045879; Mon, 10 Jan 2022 00:26:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20A0Q1fs045878; Mon, 10 Jan 2022 00:26:01 GMT (envelope-from git) Date: Mon, 10 Jan 2022 00:26:01 GMT Message-Id: <202201100026.20A0Q1fs045878@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: cb1f5d11366d - main - Reduce minimum idle hardclock rate from 2Hz to 1Hz. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cb1f5d11366dc9b803f2755d83fe02599830882a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641774361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2+9WysZfOE0o8krZJKBFOjTBRRw9vOPsPsrV5oYyYwM=; b=YTRQI5e/Bcyzefv9lUd44Wq7SXTWnK1xhPtrYXsyWnIj12SISqDAEewfH3yuxFkF92kSES pAM2kAeN9BUTh9Pzr6NKhCygRNAXjCaFrvtEeVhIf76llRdq0VjXbyhv4QnmmSo0lWSAoF PZd8Wkw/BkIZHnW8/hew0Tq2EqF57q09kOSEsXzx9Eg8nUOwArK2UAhVvh4fAo1PJv3PJ9 UPXoXG4kKzLMql0Z9djulqsOj7gwFNhZWuvKaVsgEZqanPdz0alXtr9aINNzv416acFHL0 PYA9nszFsbzM0UH9ukiRtDtE8LjiLUGsk46nq8Qg4Hi59N/LmcXIJSQ/+0CdDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641774361; a=rsa-sha256; cv=none; b=U5tZFPK2rwEoydon7pWGkATzqk7960PhUwkdnvPnO9vGF1qzhx9BQDzR2o6Asye0LYfcQr qxT/QLfIP1udg+F7eUW0y6659Wx2spdM7O5sO35Khw39qQFdlQkKxUzcKDmwvDRHI1dqN1 UAga9eCPqeLD0rX/KzaqQlwDG8RFE57v0pFQc3P4Pc87NjEBkPn31XtGgTfzhn6JQ3xTEk Sj8DGsf6RGSj4ifrbJbrPz9AghtXzGRqI9WPx7gefyWsi1CSL66SgsOXH1KmgnWirXPEam MowjsutWJbmru/vWYLKDE8V7kuI8w5RTE5I/B7cRaWNJRHF7blONo9mKCf7XMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=cb1f5d11366dc9b803f2755d83fe02599830882a commit cb1f5d11366dc9b803f2755d83fe02599830882a Author: Alexander Motin AuthorDate: 2022-01-10 00:17:43 +0000 Commit: Alexander Motin CommitDate: 2022-01-10 00:25:56 +0000 Reduce minimum idle hardclock rate from 2Hz to 1Hz. On idle 80-thread system it allows to improve package-level idle state residency and so power consumption by several percent. MFC after: 2 weeks --- sys/kern/kern_clocksource.c | 5 +++-- sys/kern/kern_timeout.c | 5 ++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/kern_clocksource.c b/sys/kern/kern_clocksource.c index dfc9081ba9f6..48e06ee082fc 100644 --- a/sys/kern/kern_clocksource.c +++ b/sys/kern/kern_clocksource.c @@ -239,13 +239,14 @@ getnextcpuevent(int idle) /* Handle hardclock() events, skipping some if CPU is idle. */ event = state->nexthard; if (idle) { - hardfreq = (u_int)hz / 2; - if (tc_min_ticktock_freq > 2 + if (tc_min_ticktock_freq > 1 #ifdef SMP && curcpu == CPU_FIRST() #endif ) hardfreq = hz / tc_min_ticktock_freq; + else + hardfreq = hz; if (hardfreq > 1) event += tick_sbt * (hardfreq - 1); } diff --git a/sys/kern/kern_timeout.c b/sys/kern/kern_timeout.c index 91882ddb5fba..d0fb19661fa4 100644 --- a/sys/kern/kern_timeout.c +++ b/sys/kern/kern_timeout.c @@ -434,8 +434,7 @@ callout_process(sbintime_t now) struct callout_cpu *cc; struct callout_list *sc; struct thread *td; - sbintime_t first, last, max, tmp_max; - uint32_t lookahead; + sbintime_t first, last, lookahead, max, tmp_max; u_int firstb, lastb, nowb; #ifdef CALLOUT_PROFILING int depth_dir = 0, mpcalls_dir = 0, lockcalls_dir = 0; @@ -455,7 +454,7 @@ callout_process(sbintime_t now) else if (nowb - firstb == 1) lookahead = (SBT_1S / 8); else - lookahead = (SBT_1S / 2); + lookahead = SBT_1S; first = last = now; first += (lookahead / 2); last += lookahead;