From nobody Sun Jan 09 17:18:05 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C1F7B193969A; Sun, 9 Jan 2022 17:18:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JX3Z53dhZz4n3y; Sun, 9 Jan 2022 17:18:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 59F381610F; Sun, 9 Jan 2022 17:18:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 209HI5Bu071098; Sun, 9 Jan 2022 17:18:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 209HI5Do071097; Sun, 9 Jan 2022 17:18:05 GMT (envelope-from git) Date: Sun, 9 Jan 2022 17:18:05 GMT Message-Id: <202201091718.209HI5Do071097@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 85056a56f3bb - main - cam: Include more statuses as errors for CAM_IO_STATS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 85056a56f3bbd26fdbaf0f045b527acac7199589 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641748685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qOtK2EeVCIq6VtQyRGznYJ8qlCfQ0P8O4yl0wkD6XHM=; b=km1Dnxh8ugSpUinfX6w/cxd3URUavIuLL1jzaa2pK1x9p3pKWlactNGDLCtALwGc7gCSJT mjRQp34cCUPgw18+o6iO2WhHzVTYEzz9N9Z7eEuIUKacsVBJkqp69ei9JlSRqD04ccQpi4 96Znf91gJ+aj2Q1KacglHO6VVFN4rcxg4tplfHPwZDbq/E/m0RNiRKJgtNgYwOg7TNKKwo ZmBayjcurq72Cbp/jiE5luRVN0xUtK040gdowpJ1Q5cqbPvo3uYGAaTjmir0rX7Kvy+Cam lNRbnX3TYlFKtKATuvY6WeTeLRRVD9aAWp85TJUs29vl/j5TAWNgMEnQ8l4Rig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641748685; a=rsa-sha256; cv=none; b=tR0Obtb4jkA/WSGRV38HTJOj301KUdipMruYcdcvq2UmC/bIBa7kD6q+9FBfEBn2Lge2Gr GprXII/l6UdEpchjAFeImCLI9x7xI68UYYqMxzHXxWLhmFwGAJG6TRJiE7noBjlpmaW+af 9D1dK+InH1KSHuDwpvSU3U6s+AfLt9TfdKBFgzCiz6+hO9dC+qDO2CbuEVont7iG0YxkUP /3+RhqHkmSI2mcvkiQ8p8TGLerh05uBI2Zcf2gnwPTaM9OjaSqEwRCw7XvfrG8f9iKuYIK dCna0kb+A0zMZjoKANzJHezFPxhY4LgF0KAlC9aJ0zij0k/3FnuD0wPWZfoZEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=85056a56f3bbd26fdbaf0f045b527acac7199589 commit 85056a56f3bbd26fdbaf0f045b527acac7199589 Author: Warner Losh AuthorDate: 2022-01-09 17:13:05 +0000 Commit: Warner Losh CommitDate: 2022-01-09 17:13:05 +0000 cam: Include more statuses as errors for CAM_IO_STATS Tag more status return values as an error for the I/O. CAM_SCSI_STATUS_ERROR is returned for medium errors, for example, but the counts weren't increased. The added errors all indicate a problem with the device request. Sponsored by: Netflix PR: 260257 Feedback from: ken Reviewed by: asomers Differential Revision: https://reviews.freebsd.org/D33783 --- sys/cam/scsi/scsi_da.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c index 8dde9d5b056e..2a7b09adc21e 100644 --- a/sys/cam/scsi/scsi_da.c +++ b/sys/cam/scsi/scsi_da.c @@ -6002,6 +6002,8 @@ daerror(union ccb *ccb, u_int32_t cam_flags, u_int32_t sense_flags) case CAM_REQ_TERMIO: case CAM_UNREC_HBA_ERROR: case CAM_DATA_RUN_ERR: + case CAM_SCSI_STATUS_ERROR: + case CAM_ATA_STATUS_ERROR: softc->errors++; break; default: