From nobody Thu Jan 06 00:06:35 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8ED6B193993F for ; Thu, 6 Jan 2022 00:06:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTmqc37jkz4V9b for ; Thu, 6 Jan 2022 00:06:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92b.google.com with SMTP id c36so1352233uae.13 for ; Wed, 05 Jan 2022 16:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HUdUn3/7+jPDJZip7fLViuRsusa99o17I0VjLfEuASg=; b=K3it8opvurY9I3f8RJ0bfg+CCIJ7mYiRKhdbxxvmYLerXhRpsF3yOzvtfavciof2A1 Nd5gqqi1pJG9sRJiz5D5Liyfb9m+39aAxTfZilDz68SWtaE08ByMK2toZUKRjwjNnT7O H02IOoukj8Ak8YFlpH16QXbGrNztJ4BJUsOmfjU8LaocfmLjlJoahVsrMxGeCkaHhfB8 ua75MTiFXYOZ2EE4QMXa6TLCiBz8rAEPjXAgFlmUKwEOjepLiWi54AS153f2twO33BpG crNmWlyGGGjF+Qk+4MIEw6hs9KdhH22Ow9t5BfnU7GK6RJiUXFvp39548i9eV2wdM6KH ogsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HUdUn3/7+jPDJZip7fLViuRsusa99o17I0VjLfEuASg=; b=EkEMRJmObCl2PF5y/3Bt3FXT5oLeIVL225njkvwN2KNyeUOHUAMS5AErcAIrSXZ1uI lOuutPdsD+z8zLLs2GzD2GoGEcF+Em/pVFG/lPJuvQGOPu3jUH49WtmzV8xO9MGwZITR CEZ7o7UFrKKAriPKraUmzLcRONx3Qf/B/fzFMBwrTLoezAztMs0O+uoGISj/AQSEZ9pZ ohfy78Wi+1q2O+OJYFZseJ3vOl9ZdTPk4nDfcF++F/LHP8f7HgjMoZeXT6grrkIkWVd1 8Od5PmnTgWbq1H4AfA6InOHclBVTTeSgwuswPE+bljRu8GFiuGdqNxgnIUHy9o/nIom2 UPiQ== X-Gm-Message-State: AOAM532K5TyUZd3TEWM3P5LZVwqEsdNWAu5bS+nBSrj90n/QHbozE4jO 703IERi0MJDW1MN8u7re+WWhjkl5k/4hBTQNPyoBUb12KvE= X-Google-Smtp-Source: ABdhPJy5K7cYdgwQwXp34Kd8XX2vwAB6krQwgPo4m3n+VhMD9zQHVp2KmT0IAbjJ7D2wJPh7bP8XcJjOh5nHq1FyPZQ= X-Received: by 2002:a05:6102:3e86:: with SMTP id m6mr9120575vsv.77.1641427606141; Wed, 05 Jan 2022 16:06:46 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202201052013.205KD3HJ024209@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 5 Jan 2022 17:06:35 -0700 Message-ID: Subject: Re: git: ce881170088c - main - atkbd: Disable periodic polling by default. To: Gleb Smirnoff Cc: Alexander Motin , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000063a83005d4dea5f9" X-Rspamd-Queue-Id: 4JTmqc37jkz4V9b X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --00000000000063a83005d4dea5f9 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022 at 5:04 PM Gleb Smirnoff wrote: > On Wed, Jan 05, 2022 at 04:18:25PM -0700, Warner Losh wrote: > W> On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff wrote: > W> > W> > On Wed, Jan 05, 2022 at 08:13:03PM +0000, Alexander Motin wrote: > W> > A> commit ce881170088c4c98c036fe561f8ee8413c2e2585 > W> > A> Author: Alexander Motin > W> > A> AuthorDate: 2022-01-05 20:00:36 +0000 > W> > A> Commit: Alexander Motin > W> > A> CommitDate: 2022-01-05 20:12:58 +0000 > W> > A> > W> > A> atkbd: Disable periodic polling by default. > W> > A> > W> > A> It is one of the few remaining Giant-locked callouts. It > would be > W> > A> good to remove it, not mentioning that polling itself is not > good. > W> > A> > W> > A> If this cause keyboard/mouse freezes on some hardware, please > set > W> > A> loader tunable hw.atkbd.hz=1 as workaround and report the > issue. > W> > A> > W> > A> Submitted by: imp, jhb > W> > > W> > Lame question: this is related only to a keyboard plugged into PS/2, > isn't > W> > W> Yes. I think this part of the code is only for "legacy" keyboards. I > don't > W> think mice are affected, but since both attach to the keyboard > controller > W> there is a tiny chance mice might be affected in some weird hardware... > > I'd even say to legacy mainboards. Cause I have PS/2 keybooard plugged into > USB port and AFAIU it is not affected by this change in any way. > correct. Going through USB is unaffected. > I think that even if this change creates some regression, we never know > that. > Nobody would today run so old mainboard as a desktop. Might have it as a > headless appliance. > You'd be surprised what people run today :(. Doing the graphics stuff has shown me that. Nobody would build a new one today, but there's lots of systems that have been around a few years that have keyboards connected via PS/2. I doubt, though, any will see a regression because of the extreme age of this workaround. Warner --00000000000063a83005d4dea5f9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 5, 2022 at 5:04 PM Gleb S= mirnoff <glebius@freebsd.org&= gt; wrote:
On We= d, Jan 05, 2022 at 04:18:25PM -0700, Warner Losh wrote:
W> On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff <glebius@freebsd.org> wrote:
W>
W> > On Wed, Jan 05, 2022 at 08:13:03PM +0000, Alexander Motin wrote:=
W> > A> commit ce881170088c4c98c036fe561f8ee8413c2e2585
W> > A> Author:=C2=A0 =C2=A0 =C2=A0Alexander Motin <mav@FreeBSD= .org>
W> > A> AuthorDate: 2022-01-05 20:00:36 +0000
W> > A> Commit:=C2=A0 =C2=A0 =C2=A0Alexander Motin <mav@FreeBSD= .org>
W> > A> CommitDate: 2022-01-05 20:12:58 +0000
W> > A>
W> > A>=C2=A0 =C2=A0 =C2=A0atkbd: Disable periodic polling by defa= ult.
W> > A>
W> > A>=C2=A0 =C2=A0 =C2=A0It is one of the few remaining Giant-lo= cked callouts.=C2=A0 It would be
W> > A>=C2=A0 =C2=A0 =C2=A0good to remove it, not mentioning that = polling itself is not good.
W> > A>
W> > A>=C2=A0 =C2=A0 =C2=A0If this cause keyboard/mouse freezes on= some hardware, please set
W> > A>=C2=A0 =C2=A0 =C2=A0loader tunable hw.atkbd.hz=3D1 as worka= round and report the issue.
W> > A>
W> > A>=C2=A0 =C2=A0 =C2=A0Submitted by:=C2=A0 =C2=A0imp, jhb
W> >
W> > Lame question: this is related only to a keyboard plugged into P= S/2, isn't
W>
W> Yes. I think this part of the code is only for "legacy" key= boards. I don't
W> think mice are affected, but since both attach to the keyboard contro= ller
W> there is a tiny chance mice might be affected in some weird hardware.= ..

I'd even say to legacy mainboards. Cause I have PS/2 keybooard plugged = into
USB port and AFAIU it is not affected by this change in any way.

correct. Going through USB is unaffected.
=C2=A0
I think that even if this change creates some regression, we never know tha= t.
Nobody would today run so old mainboard as a desktop. Might have it as a headless appliance.

You'd be surpri= sed what people run today :(. Doing the graphics stuff has shown
= me that. Nobody would build a new one today, but there's lots of system= s that have
been around a few years that have keyboards connected= via PS/2. I doubt, though,
any will see a regression because of = the extreme age of this workaround.

Warner
--00000000000063a83005d4dea5f9--