From nobody Wed Jan 05 23:18:25 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C5F37192C769 for ; Wed, 5 Jan 2022 23:18:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTllx4xfwz3rT7 for ; Wed, 5 Jan 2022 23:18:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92d.google.com with SMTP id o1so1280037uap.4 for ; Wed, 05 Jan 2022 15:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M7GzP+PftAddoo/F4grjg957iPpnKVyXG9EoJ33udIo=; b=KxxJxkYZqBvMjOoNdjggB6c8eLyoUdwB/qXxNQt5y2KIawtuTR7vcimwRMEnNLonk/ GOLX7dhTo+ioc4dChe5kkzJX9s8IFxlMo2r9o5qpUe2hatgB56OeYXQkZ+7u4BJuh2gA EOhqDMiVFlEQTsU7/Rl7ifHOfMixoxfqjhVtIh/AM4LG8SJ1GhdnaI4JLH1BS05+4Qx7 15GU78UCONlbGy6k7opIBM9TCiheA5pRHoP7m7HcWaChtJJ6ViJmJjyUblDygWdP7pPC g2aZWzdQF/opylJ0X2p2UJy+oOnigl/DU96VT7AIz0w6YltdaQG0udUgidpFpmhT5J5I Rm1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7GzP+PftAddoo/F4grjg957iPpnKVyXG9EoJ33udIo=; b=l0fEXfP0P2KnG2OUgB71ZiMhOQApdX3W2uibVVKCxhTJC7eNvePXAEjdtRpIMmhyTd b9iCqZqE39rodP+jFPGkecrbZ+P+BwQeLhxwwxKIRXi/9Awy3Z/oj+NEt2LmHR380DI0 4HPd85oP2/5jWC2YBnvEmvHY6P9J1BaEheDIXRUCQs4hrSW+N6AfGJdgKZJVTiGlA/qC CMF7nHnzkSnhGO4QWLXopE5VotffzezNXvZLYjBuSlJjAgnXYpt2N6RumJLztQXeofGV +62hgmRcte/1AQN+qneoANYKlcKezH3lGJUr5xy4/maITlrrqVpJJkajDLWcqw9Ug3U0 gOzw== X-Gm-Message-State: AOAM531j6hO0rlKx3dYnd59eZk1TAu5SCFNpURSCtiw4uh0E0Ul7ksLo DzImSnZ8iteWxOwN5AiYT0RK8EifE8czSAJKDmPoZGQds5M= X-Google-Smtp-Source: ABdhPJzV5gXFyHGNMM/aFjOX+I+vrD6ytFSboz1Rs+ij3d/11uk1JMCJrwOieUZb+lcplJa3qEVabXlElSSYSlqSoPc= X-Received: by 2002:a05:6102:da:: with SMTP id u26mr18106936vsp.42.1641424717046; Wed, 05 Jan 2022 15:18:37 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202201052013.205KD3HJ024209@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 5 Jan 2022 16:18:25 -0700 Message-ID: Subject: Re: git: ce881170088c - main - atkbd: Disable periodic polling by default. To: Gleb Smirnoff Cc: Alexander Motin , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000002f783e05d4ddf997" X-Rspamd-Queue-Id: 4JTllx4xfwz3rT7 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --0000000000002f783e05d4ddf997 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff wrote: > On Wed, Jan 05, 2022 at 08:13:03PM +0000, Alexander Motin wrote: > A> commit ce881170088c4c98c036fe561f8ee8413c2e2585 > A> Author: Alexander Motin > A> AuthorDate: 2022-01-05 20:00:36 +0000 > A> Commit: Alexander Motin > A> CommitDate: 2022-01-05 20:12:58 +0000 > A> > A> atkbd: Disable periodic polling by default. > A> > A> It is one of the few remaining Giant-locked callouts. It would be > A> good to remove it, not mentioning that polling itself is not good. > A> > A> If this cause keyboard/mouse freezes on some hardware, please set > A> loader tunable hw.atkbd.hz=1 as workaround and report the issue. > A> > A> Submitted by: imp, jhb > > Lame question: this is related only to a keyboard plugged into PS/2, isn't > it? > Yes. I think this part of the code is only for "legacy" keyboards. I don't think mice are affected, but since both attach to the keyboard controller there is a tiny chance mice might be affected in some weird hardware... Warner > --0000000000002f783e05d4ddf997 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff <glebius@freebsd.org> wrote:
On Wed, Jan 05, 2022 at 08:13:03PM +0000, A= lexander Motin wrote:
A> commit ce881170088c4c98c036fe561f8ee8413c2e2585
A> Author:=C2=A0 =C2=A0 =C2=A0Alexander Motin <mav@FreeBSD.org> A> AuthorDate: 2022-01-05 20:00:36 +0000
A> Commit:=C2=A0 =C2=A0 =C2=A0Alexander Motin <mav@FreeBSD.org> A> CommitDate: 2022-01-05 20:12:58 +0000
A>
A>=C2=A0 =C2=A0 =C2=A0atkbd: Disable periodic polling by default.
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0It is one of the few remaining Giant-locked callou= ts.=C2=A0 It would be
A>=C2=A0 =C2=A0 =C2=A0good to remove it, not mentioning that polling its= elf is not good.
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0If this cause keyboard/mouse freezes on some hardw= are, please set
A>=C2=A0 =C2=A0 =C2=A0loader tunable hw.atkbd.hz=3D1 as workaround and r= eport the issue.
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0Submitted by:=C2=A0 =C2=A0imp, jhb

Lame question: this is related only to a keyboard plugged into PS/2, isn= 9;t it?

Yes. I think this part of the code is only for "legacy" ke= yboards. I don't think mice are affected, but since both attach to the = keyboard controller there is a tiny chance mice might be affected in some w= eird hardware...=C2=A0

W= arner
--0000000000002f783e05d4ddf997--